Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl: provide official variables in cmake_find_package #4597

Merged

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Feb 17, 2021

Specify library name and version: openssl/all

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

No more ugliness in downstream recipes forced to replace official cmake variables of openssl due to casing issues in cmake_find_package generator.
Requires conan >= 1.33.0

@conan-center-bot
Copy link
Collaborator

Failure in build 1 (e10f00b8ba038f7b29781d17b1bc7f9b8137630a):

  • openssl/1.0.2s@:
    Error running command 'conan export "conan-center-index/recipes/openssl/1.x.x/conanfile.py" openssl/1.0.2s@':

    ERROR: Error loading conanfile at '/home/conan/w/BuildSingleReference/conan-center-index/recipes/openssl/1.x.x/conanfile.py': Current Conan version (1.32.1) does not satisfy the defined one (>=1.33.0).
    
  • openssl/1.0.2u@:
    Error running command 'conan export "conan-center-index/recipes/openssl/1.x.x/conanfile.py" openssl/1.0.2u@':

    ERROR: Error loading conanfile at '/home/conan/w/BuildSingleReference/conan-center-index/recipes/openssl/1.x.x/conanfile.py': Current Conan version (1.32.1) does not satisfy the defined one (>=1.33.0).
    
  • openssl/1.0.2t@:
    Error running command 'conan export "conan-center-index/recipes/openssl/1.x.x/conanfile.py" openssl/1.0.2t@':

    ERROR: Error loading conanfile at '/home/conan/w/BuildSingleReference/conan-center-index/recipes/openssl/1.x.x/conanfile.py': Current Conan version (1.32.1) does not satisfy the defined one (>=1.33.0).
    
  • openssl/1.1.0k@:
    Error running command 'conan export "conan-center-index/recipes/openssl/1.x.x/conanfile.py" openssl/1.1.0k@':

    ERROR: Error loading conanfile at '/home/conan/w/BuildSingleReference/conan-center-index/recipes/openssl/1.x.x/conanfile.py': Current Conan version (1.32.1) does not satisfy the defined one (>=1.33.0).
    
  • openssl/1.1.0l@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.1c@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.1d@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.1f@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.1g@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.1i@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.1e@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.1h@:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@ghost
Copy link

ghost commented Feb 17, 2021

I detected other pull requests that are modifying openssl/1.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@SpaceIm SpaceIm mentioned this pull request Feb 17, 2021
4 tasks
@staticmethod
def _create_cmake_module_variables(module_file):
content = (
"if(OpenSSL_FOUND)\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have this as a separate file in the repo if it's possible?

Copy link
Contributor Author

@SpaceIm SpaceIm Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, I don't want to see the content of this file too far from package_info() because it's tightly related. It would be easy to change some values in package_info() and forget to update this file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to keep it embedded maybe use a multi line string (""")?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like multi lines because it breaks indentation and looks ugly in a python file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taste is different I guess :)
I actually prefer the zero indentation but for those who like to keep it I have seen this pattern used:

import textwrap

def foo():
    content = """\
        for
        bar
        baz
    """
    print(textwrap.dedent(content))

foo()

This is of course not an important topic, just want to share the pattern.

Copy link
Contributor Author

@SpaceIm SpaceIm Feb 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not produce the same string. You'll have plenty of unwanted spaces at the beginning of each line.

EDIT: ok I didn't see the textwrap, thanks good to know.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed in d5cb67d, indeed it's neater ;)

@mathbunnyru
Copy link
Contributor

Great change, @SpaceIm, I think it will make the life of many recipe creators much easier 👍

@conan-center-bot
Copy link
Collaborator

Failure in build 3 (64bcde0b221a669e55865b98ea15eb28b01be8da):

  • openssl/1.0.2s@:
    CI failed to create some packages (All logs)

    Logs for packageID 009a50ddeb47afbc9361cbc63650560c127e1234:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Debug
    compiler=Visual Studio
    compiler.runtime=MDd
    compiler.version=15
    os=Windows
    os_build=Windows
    [options]
    openssl:shared=False
    
    ********************************************************************************
    conan install openssl/1.0.2s@ --profile=C:\J\w\BuildSingleReference@3/5895/f66f89a6-a7bc-446e-b9b8-ef5a89dc939f/profile.txt --build=openssl
    ********************************************************************************
    Configuration:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Debug
    compiler=Visual Studio
    compiler.runtime=MDd
    compiler.version=15
    os=Windows
    os_build=Windows
    [options]
    openssl:shared=False
    [build_requires]
    [env]
    
    Traceback (most recent call last):
      File "c:\python36\lib\site-packages\conans\client\command.py", line 2115, in run
        method(args[0][1:])
      File "c:\python36\lib\site-packages\conans\client\command.py", line 531, in install
        lockfile_node_id=args.lockfile_node_id)
      File "c:\python36\lib\site-packages\conans\client\conan_api.py", line 94, in wrapper
        return f(api, *args, **kwargs)
      File "c:\python36\lib\site-packages\conans\client\conan_api.py", line 560, in install_reference
        lockfile_node_id=lockfile_node_id)
      File "c:\python36\lib\site-packages\conans\client\manager.py", line 57, in deps_install
        lockfile_node_id=lockfile_node_id)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_manager.py", line 116, in load_graph
        apply_build_requires=apply_build_requires)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_manager.py", line 246, in _resolve_graph
        graph_lock=graph_lock)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_manager.py", line 365, in _load_graph
        apply_build_requires=apply_build_requires)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_manager.py", line 286, in _recurse_build_requires
        self._binary_analyzer.evaluate_graph(graph, build_mode, update, remotes, nodes_subset, root)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_binaries.py", line 384, in evaluate_graph
        self._evaluate_node(node, build_mode, update, remotes)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_binaries.py", line 176, in _evaluate_node
        self._process_node(node, pref, build_mode, update, remotes)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_binaries.py", line 242, in _process_node
        self._evaluate_cache_pkg(node, package_layout, pref, metadata, remote, remotes, update)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_binaries.py", line 95, in _evaluate_cache_pkg
        assert node.prev, "PREV for %s is None: %s" % (str(pref), metadata.dumps())
    AssertionError: PREV for zlib/1.2.11:8cf01e2f50fcd6b63525e70584df0326550364e1 is None: {"recipe": {"revision": "25dad5342ca50f8d7b9e30f669c7ad37", "remote": "conan-center", "properties": {}, "checksums": {"conan_export.tgz": {"md5": "db9264b1045470dbd5fdcd6061826d56", "sha1": "236dbcdc167a595592a34ba09b169a0e2284944e"}, "conanmanifest.txt": {"md5": "9d162d2fd3c9074a984faac57ec334c7", "sha1": "93460f82e50a3f0d75e8d362f833d09d15df90f4"}, "conanfile.py": {"md5": "8415e6dd8f308504b68a3d014b534396", "sha1": "0c32e68f0ccefa6abec6ec08d8ad6b2b3382e843"}}}, "packages": {"8cf01e2f50fcd6b63525e70584df0326550364e1": {"revision": null, "recipe_revision": null, "remote": null, "properties": {}, "checksums": {}}}}
    
    ERROR: PREV for zlib/1.2.11:8cf01e2f50fcd6b63525e70584df0326550364e1 is None: {"recipe": {"revision": "25dad5342ca50f8d7b9e30f669c7ad37", "remote": "conan-center", "properties": {}, "checksums": {"conan_export.tgz": {"md5": "db9264b1045470dbd5fdcd6061826d56", "sha1": "236dbcdc167a595592a34ba09b169a0e2284944e"}, "conanmanifest.txt": {"md5": "9d162d2fd3c9074a984faac57ec334c7", "sha1": "93460f82e50a3f0d75e8d362f833d09d15df90f4"}, "conanfile.py": {"md5": "8415e6dd8f308504b68a3d014b534396", "sha1": "0c32e68f0ccefa6abec6ec08d8ad6b2b3382e843"}}}, "packages": {"8cf01e2f50fcd6b63525e70584df0326550364e1": {"revision": null, "recipe_revision": null, "remote": null, "properties": {}, "checksums": {}}}}
    
  • openssl/1.1.0k@:
    CI failed to create some packages (All logs)

    Logs for packageID 7bd6f2c3d5c4e48a75805376b58cde753392f711:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Release
    compiler=Visual Studio
    compiler.runtime=MT
    compiler.version=15
    os=Windows
    os_build=Windows
    [options]
    openssl:shared=False
    
    Configuration:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Release
    compiler=Visual Studio
    compiler.runtime=MT
    compiler.version=15
    os=Windows
    os_build=Windows
    [options]
    openssl:shared=False
    [build_requires]
    [env]
    
    openssl/1.1.0k: Forced build from source
    Traceback (most recent call last):
      File "c:\python36\lib\site-packages\conans\client\command.py", line 2115, in run
        method(args[0][1:])
      File "c:\python36\lib\site-packages\conans\client\command.py", line 531, in install
        lockfile_node_id=args.lockfile_node_id)
      File "c:\python36\lib\site-packages\conans\client\conan_api.py", line 94, in wrapper
        return f(api, *args, **kwargs)
      File "c:\python36\lib\site-packages\conans\client\conan_api.py", line 560, in install_reference
        lockfile_node_id=lockfile_node_id)
      File "c:\python36\lib\site-packages\conans\client\manager.py", line 57, in deps_install
        lockfile_node_id=lockfile_node_id)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_manager.py", line 116, in load_graph
        apply_build_requires=apply_build_requires)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_manager.py", line 246, in _resolve_graph
        graph_lock=graph_lock)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_manager.py", line 365, in _load_graph
        apply_build_requires=apply_build_requires)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_manager.py", line 343, in _recurse_build_requires
        _recurse_build_requires(br_all, profile_build_requires)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_manager.py", line 327, in _recurse_build_requires
        nodes_subset=nodessub, root=node)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_manager.py", line 286, in _recurse_build_requires
        self._binary_analyzer.evaluate_graph(graph, build_mode, update, remotes, nodes_subset, root)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_binaries.py", line 384, in evaluate_graph
        self._evaluate_node(node, build_mode, update, remotes)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_binaries.py", line 176, in _evaluate_node
        self._process_node(node, pref, build_mode, update, remotes)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_binaries.py", line 242, in _process_node
        self._evaluate_cache_pkg(node, package_layout, pref, metadata, remote, remotes, update)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_binaries.py", line 95, in _evaluate_cache_pkg
        assert node.prev, "PREV for %s is None: %s" % (str(pref), metadata.dumps())
    AssertionError: PREV for nasm/2.15.05:0a420ff5c47119e668867cdb51baff0eca1fdb68 is None: {"recipe": {"revision": "3b0fc0a593bbfd22ed8e922fd0a9e303", "remote": "conan-center", "properties": {}, "checksums": {"conan_export.tgz": {"md5": "d74e7aee83295b4efa262a86357996de", "sha1": "2ad66c8a8bebe58c81a2e40a162e508db109c527"}, "conanmanifest.txt": {"md5": "888beba3abf6092477903c358a359ed6", "sha1": "55a224eeaf5e5e5ff916ce2c6c060df9f9791b1c"}, "conanfile.py": {"md5": "e21c0ebc27f5837a9c651fb9809fab83", "sha1": "650ce5ae4d43f1ee219cae209fafbe279895c36f"}}}, "packages": {"0a420ff5c47119e668867cdb51baff0eca1fdb68": {"revision": null, "recipe_revision": null, "remote": null, "properties": {}, "checksums": {}}}}
    
    ERROR: PREV for nasm/2.15.05:0a420ff5c47119e668867cdb51baff0eca1fdb68 is None: {"recipe": {"revision": "3b0fc0a593bbfd22ed8e922fd0a9e303", "remote": "conan-center", "properties": {}, "checksums": {"conan_export.tgz": {"md5": "d74e7aee83295b4efa262a86357996de", "sha1": "2ad66c8a8bebe58c81a2e40a162e508db109c527"}, "conanmanifest.txt": {"md5": "888beba3abf6092477903c358a359ed6", "sha1": "55a224eeaf5e5e5ff916ce2c6c060df9f9791b1c"}, "conanfile.py": {"md5": "e21c0ebc27f5837a9c651fb9809fab83", "sha1": "650ce5ae4d43f1ee219cae209fafbe279895c36f"}}}, "packages": {"0a420ff5c47119e668867cdb51baff0eca1fdb68": {"revision": null, "recipe_revision": null, "remote": null, "properties": {}, "checksums": {}}}}
    
  • openssl/1.0.2t@:
    CI failed to create some packages (All logs)

    Logs for packageID c6eb1796d6a9d59338fa618b78b90859da126b06:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Release
    compiler=Visual Studio
    compiler.runtime=MT
    compiler.version=16
    os=Windows
    os_build=Windows
    [options]
    openssl:shared=False
    
    ********************************************************************************
    conan install openssl/1.0.2t@ --profile=C:\J\w\BuildSingleReference@3/5896/62833f46-6443-4808-961b-28aee5889cb7/profile.txt --build=openssl
    ********************************************************************************
    Configuration:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Release
    compiler=Visual Studio
    compiler.runtime=MT
    compiler.version=16
    os=Windows
    os_build=Windows
    [options]
    openssl:shared=False
    [build_requires]
    [env]
    
    Traceback (most recent call last):
      File "c:\python36\lib\site-packages\conans\client\command.py", line 2115, in run
        method(args[0][1:])
      File "c:\python36\lib\site-packages\conans\client\command.py", line 531, in install
        lockfile_node_id=args.lockfile_node_id)
      File "c:\python36\lib\site-packages\conans\client\conan_api.py", line 94, in wrapper
        return f(api, *args, **kwargs)
      File "c:\python36\lib\site-packages\conans\client\conan_api.py", line 560, in install_reference
        lockfile_node_id=lockfile_node_id)
      File "c:\python36\lib\site-packages\conans\client\manager.py", line 57, in deps_install
        lockfile_node_id=lockfile_node_id)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_manager.py", line 116, in load_graph
        apply_build_requires=apply_build_requires)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_manager.py", line 246, in _resolve_graph
        graph_lock=graph_lock)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_manager.py", line 365, in _load_graph
        apply_build_requires=apply_build_requires)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_manager.py", line 286, in _recurse_build_requires
        self._binary_analyzer.evaluate_graph(graph, build_mode, update, remotes, nodes_subset, root)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_binaries.py", line 384, in evaluate_graph
        self._evaluate_node(node, build_mode, update, remotes)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_binaries.py", line 176, in _evaluate_node
        self._process_node(node, pref, build_mode, update, remotes)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_binaries.py", line 242, in _process_node
        self._evaluate_cache_pkg(node, package_layout, pref, metadata, remote, remotes, update)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_binaries.py", line 95, in _evaluate_cache_pkg
        assert node.prev, "PREV for %s is None: %s" % (str(pref), metadata.dumps())
    AssertionError: PREV for zlib/1.2.11:a79a557254fabcb77849dd623fed97c9c5ab7651 is None: {"recipe": {"revision": "25dad5342ca50f8d7b9e30f669c7ad37", "remote": "conan-center", "properties": {}, "checksums": {"conan_export.tgz": {"md5": "db9264b1045470dbd5fdcd6061826d56", "sha1": "236dbcdc167a595592a34ba09b169a0e2284944e"}, "conanmanifest.txt": {"md5": "9d162d2fd3c9074a984faac57ec334c7", "sha1": "93460f82e50a3f0d75e8d362f833d09d15df90f4"}, "conanfile.py": {"md5": "8415e6dd8f308504b68a3d014b534396", "sha1": "0c32e68f0ccefa6abec6ec08d8ad6b2b3382e843"}}}, "packages": {"a79a557254fabcb77849dd623fed97c9c5ab7651": {"revision": null, "recipe_revision": null, "remote": null, "properties": {}, "checksums": {}}}}
    
    ERROR: PREV for zlib/1.2.11:a79a557254fabcb77849dd623fed97c9c5ab7651 is None: {"recipe": {"revision": "25dad5342ca50f8d7b9e30f669c7ad37", "remote": "conan-center", "properties": {}, "checksums": {"conan_export.tgz": {"md5": "db9264b1045470dbd5fdcd6061826d56", "sha1": "236dbcdc167a595592a34ba09b169a0e2284944e"}, "conanmanifest.txt": {"md5": "9d162d2fd3c9074a984faac57ec334c7", "sha1": "93460f82e50a3f0d75e8d362f833d09d15df90f4"}, "conanfile.py": {"md5": "8415e6dd8f308504b68a3d014b534396", "sha1": "0c32e68f0ccefa6abec6ec08d8ad6b2b3382e843"}}}, "packages": {"a79a557254fabcb77849dd623fed97c9c5ab7651": {"revision": null, "recipe_revision": null, "remote": null, "properties": {}, "checksums": {}}}}
    
  • openssl/1.0.2u@:
    CI failed to create some packages (All logs)

    Logs for packageID c6eb1796d6a9d59338fa618b78b90859da126b06:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Release
    compiler=Visual Studio
    compiler.runtime=MT
    compiler.version=16
    os=Windows
    os_build=Windows
    [options]
    openssl:shared=False
    
    ********************************************************************************
    conan install openssl/1.0.2u@ --profile=C:\J\w\BuildSingleReference@3/5898/a36ae44f-99fc-4cfc-8bb4-e17dbe4e63b8/profile.txt --build=openssl
    ********************************************************************************
    Configuration:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Release
    compiler=Visual Studio
    compiler.runtime=MT
    compiler.version=16
    os=Windows
    os_build=Windows
    [options]
    openssl:shared=False
    [build_requires]
    [env]
    
    Traceback (most recent call last):
      File "c:\python36\lib\site-packages\conans\client\command.py", line 2115, in run
        method(args[0][1:])
      File "c:\python36\lib\site-packages\conans\client\command.py", line 531, in install
        lockfile_node_id=args.lockfile_node_id)
      File "c:\python36\lib\site-packages\conans\client\conan_api.py", line 94, in wrapper
        return f(api, *args, **kwargs)
      File "c:\python36\lib\site-packages\conans\client\conan_api.py", line 560, in install_reference
        lockfile_node_id=lockfile_node_id)
      File "c:\python36\lib\site-packages\conans\client\manager.py", line 57, in deps_install
        lockfile_node_id=lockfile_node_id)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_manager.py", line 116, in load_graph
        apply_build_requires=apply_build_requires)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_manager.py", line 246, in _resolve_graph
        graph_lock=graph_lock)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_manager.py", line 365, in _load_graph
        apply_build_requires=apply_build_requires)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_manager.py", line 286, in _recurse_build_requires
        self._binary_analyzer.evaluate_graph(graph, build_mode, update, remotes, nodes_subset, root)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_binaries.py", line 384, in evaluate_graph
        self._evaluate_node(node, build_mode, update, remotes)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_binaries.py", line 176, in _evaluate_node
        self._process_node(node, pref, build_mode, update, remotes)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_binaries.py", line 242, in _process_node
        self._evaluate_cache_pkg(node, package_layout, pref, metadata, remote, remotes, update)
      File "c:\python36\lib\site-packages\conans\client\graph\graph_binaries.py", line 95, in _evaluate_cache_pkg
        assert node.prev, "PREV for %s is None: %s" % (str(pref), metadata.dumps())
    AssertionError: PREV for zlib/1.2.11:a79a557254fabcb77849dd623fed97c9c5ab7651 is None: {"recipe": {"revision": "25dad5342ca50f8d7b9e30f669c7ad37", "remote": "conan-center", "properties": {}, "checksums": {"conan_export.tgz": {"md5": "db9264b1045470dbd5fdcd6061826d56", "sha1": "236dbcdc167a595592a34ba09b169a0e2284944e"}, "conanmanifest.txt": {"md5": "9d162d2fd3c9074a984faac57ec334c7", "sha1": "93460f82e50a3f0d75e8d362f833d09d15df90f4"}, "conanfile.py": {"md5": "8415e6dd8f308504b68a3d014b534396", "sha1": "0c32e68f0ccefa6abec6ec08d8ad6b2b3382e843"}}}, "packages": {"a79a557254fabcb77849dd623fed97c9c5ab7651": {"revision": null, "recipe_revision": null, "remote": null, "properties": {}, "checksums": {}}}}
    
    ERROR: PREV for zlib/1.2.11:a79a557254fabcb77849dd623fed97c9c5ab7651 is None: {"recipe": {"revision": "25dad5342ca50f8d7b9e30f669c7ad37", "remote": "conan-center", "properties": {}, "checksums": {"conan_export.tgz": {"md5": "db9264b1045470dbd5fdcd6061826d56", "sha1": "236dbcdc167a595592a34ba09b169a0e2284944e"}, "conanmanifest.txt": {"md5": "9d162d2fd3c9074a984faac57ec334c7", "sha1": "93460f82e50a3f0d75e8d362f833d09d15df90f4"}, "conanfile.py": {"md5": "8415e6dd8f308504b68a3d014b534396", "sha1": "0c32e68f0ccefa6abec6ec08d8ad6b2b3382e843"}}}, "packages": {"a79a557254fabcb77849dd623fed97c9c5ab7651": {"revision": null, "recipe_revision": null, "remote": null, "properties": {}, "checksums": {}}}}
    
  • openssl/1.1.1d@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.1f@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.1g@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.1i@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.1h@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.0l@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.1e@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.1c@:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Feb 17, 2021

AssertionError: PREV for nasm/2.15.05:0a420ff5c47119e668867cdb51baff0eca1fdb68 is None: {"recipe": {"revision": "3b0fc0a593bbfd22ed8e922fd0a9e303", "remote": "conan-center", "properties": {}, "checksums": {"conan_export.tgz": {"md5": "d74e7aee83295b4efa262a86357996de", "sha1": "2ad66c8a8bebe58c81a2e40a162e508db109c527"}, "conanmanifest.txt": {"md5": "888beba3abf6092477903c358a359ed6", "sha1": "55a224eeaf5e5e5ff916ce2c6c060df9f9791b1c"}, "conanfile.py": {"md5": "e21c0ebc27f5837a9c651fb9809fab83", "sha1": "650ce5ae4d43f1ee219cae209fafbe279895c36f"}}}, "packages": {"0a420ff5c47119e668867cdb51baff0eca1fdb68": {"revision": null, "recipe_revision": null, "remote": null, "properties": {}, "checksums": {}}}}

ERROR: PREV for nasm/2.15.05:0a420ff5c47119e668867cdb51baff0eca1fdb68 is None: {"recipe": {"revision": "3b0fc0a593bbfd22ed8e922fd0a9e303", "remote": "conan-center", "properties": {}, "checksums": {"conan_export.tgz": {"md5": "d74e7aee83295b4efa262a86357996de", "sha1": "2ad66c8a8bebe58c81a2e40a162e508db109c527"}, "conanmanifest.txt": {"md5": "888beba3abf6092477903c358a359ed6", "sha1": "55a224eeaf5e5e5ff916ce2c6c060df9f9791b1c"}, "conanfile.py": {"md5": "e21c0ebc27f5837a9c651fb9809fab83", "sha1": "650ce5ae4d43f1ee219cae209fafbe279895c36f"}}}, "packages": {"0a420ff5c47119e668867cdb51baff0eca1fdb68": {"revision": null, "recipe_revision": null, "remote": null, "properties": {}, "checksums": {}}}}

What is that?

@jgsogo jgsogo self-assigned this Feb 17, 2021
@dmn-star
Copy link
Contributor

Maybe because of tools.os_info.is_windows in nams recipe, something like that almost always messes up CCI.

@ericLemanissier
Copy link
Contributor

it happened also in
#4589 (comment)
#4577 (comment)
#4412 (comment)

We have no clear explanation yet on what is causing this :/

@danimtb
Copy link
Member

danimtb commented Feb 17, 2021

I am opening an issue with that. Thanks @ericLemanissier

@jgsogo
Copy link
Contributor

jgsogo commented Feb 17, 2021

We have no clear explanation yet on what is causing this :/

TBH, neither do we. The first time we thought it was a glitch, but now it can no longer be a random failure. There is a bug somewhere and we need to find it 🕵️

@ericriff
Copy link
Contributor

ericriff commented Feb 17, 2021

I'm wondering if we can use this approach to add Protobuf_PROTOC_EXECUTABLE to the protobuf recipe. 🤔
https://cmake.org/cmake/help/latest/module/FindProtobuf.html

@jgsogo
Copy link
Contributor

jgsogo commented Feb 17, 2021

I'm wondering if we can use this approach to add Protobuf_PROTOC_EXECUTABLE to the protobuf recipe. 🤔
https://cmake.org/cmake/help/latest/module/FindProtobuf.html

@ericriff , my pedantic two cents 😅 : in a generic scenario (which is a cross-compiling one) you want the executable from the build-requires, not the one from host. Yes, we can write a build-module and take the protoc from the PATH (IIRC, CMake have some find_program facilities).

@ericLemanissier
Copy link
Contributor

That's the wrong Eric!

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Feb 17, 2021

@ericriff take a look at ec87edc

I've decided to not implement this feature in above mentioned PR because imported executable target will be implemented in conan from what I've understood.

Important part:

  • use IMPORTED_LOCATION property with ${CMAKE_CURRENT_LIST_DIR} and relative path between installed location of module file and bin folder, to make the package relocatable.
  • do not forget to set <component>_FOUND variable to ON

prince-chrismc
prince-chrismc previously approved these changes Feb 17, 2021
@conan-center-bot
Copy link
Collaborator

All green in build 4 (64bcde0b221a669e55865b98ea15eb28b01be8da):

  • openssl/1.0.2t@:
    All packages built successfully! (All logs)

  • openssl/1.0.2u@:
    All packages built successfully! (All logs)

  • openssl/1.0.2s@:
    All packages built successfully! (All logs)

  • openssl/1.1.0k@:
    All packages built successfully! (All logs)

  • openssl/1.1.1h@:
    All packages built successfully! (All logs)

  • openssl/1.1.0l@:
    All packages built successfully! (All logs)

  • openssl/1.1.1c@:
    All packages built successfully! (All logs)

  • openssl/1.1.1d@:
    All packages built successfully! (All logs)

  • openssl/1.1.1e@:
    All packages built successfully! (All logs)

  • openssl/1.1.1i@:
    All packages built successfully! (All logs)

  • openssl/1.1.1f@:
    All packages built successfully! (All logs)

  • openssl/1.1.1g@:
    All packages built successfully! (All logs)

prince-chrismc
prince-chrismc previously approved these changes Feb 20, 2021
@conan-center-bot
Copy link
Collaborator

All green in build 5 (c5f1d5de036ff30ce0be1f026e1d0bd08e08e967):

  • openssl/1.0.2s@:
    All packages built successfully! (All logs)

  • openssl/1.0.2t@:
    All packages built successfully! (All logs)

  • openssl/1.0.2u@:
    All packages built successfully! (All logs)

  • openssl/1.1.0k@:
    All packages built successfully! (All logs)

  • openssl/1.1.0l@:
    All packages built successfully! (All logs)

  • openssl/1.1.1c@:
    All packages built successfully! (All logs)

  • openssl/1.1.1d@:
    All packages built successfully! (All logs)

  • openssl/1.1.1e@:
    All packages built successfully! (All logs)

  • openssl/1.1.1g@:
    All packages built successfully! (All logs)

  • openssl/1.1.1h@:
    All packages built successfully! (All logs)

  • openssl/1.1.1f@:
    All packages built successfully! (All logs)

  • openssl/1.1.1i@:
    All packages built successfully! (All logs)

  • openssl/1.1.1j@:
    All packages built successfully! (All logs)

SSE4
SSE4 previously approved these changes Feb 21, 2021
@SpaceIm SpaceIm dismissed stale reviews from SSE4 and prince-chrismc via 761aae3 February 21, 2021 09:15
@conan-center-bot
Copy link
Collaborator

Failure in build 6 (761aae3182d004c52879b0faf4f56e06e988d5ff):

  • openssl/1.0.2s@:
    All packages built successfully! (All logs)

  • openssl/1.0.2t@:
    An unexpected error happened and has been reported

  • openssl/1.1.0k@:
    An unexpected error happened and has been reported

  • openssl/1.0.2u@:
    All packages built successfully! (All logs)

  • openssl/1.1.0l@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.1d@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.1h@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.1c@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.1j@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.1e@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.1f@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.1g@:
    Didn't run or was cancelled before finishing

  • openssl/1.1.1i@:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@conan-center-bot
Copy link
Collaborator

All green in build 7 (761aae3182d004c52879b0faf4f56e06e988d5ff):

  • openssl/1.0.2s@:
    All packages built successfully! (All logs)

  • openssl/1.0.2t@:
    All packages built successfully! (All logs)

  • openssl/1.0.2u@:
    All packages built successfully! (All logs)

  • openssl/1.1.1i@:
    All packages built successfully! (All logs)

  • openssl/1.1.0k@:
    All packages built successfully! (All logs)

  • openssl/1.1.1c@:
    All packages built successfully! (All logs)

  • openssl/1.1.0l@:
    All packages built successfully! (All logs)

  • openssl/1.1.1d@:
    All packages built successfully! (All logs)

  • openssl/1.1.1e@:
    All packages built successfully! (All logs)

  • openssl/1.1.1h@:
    All packages built successfully! (All logs)

  • openssl/1.1.1g@:
    All packages built successfully! (All logs)

  • openssl/1.1.1j@:
    All packages built successfully! (All logs)

  • openssl/1.1.1f@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 8e2f2f9 into conan-io:master Feb 22, 2021
@SpaceIm SpaceIm deleted the fix/openssl-cmake-find-variables branch February 22, 2021 12:05
ericLemanissier added a commit to ericLemanissier/conan-center-index that referenced this pull request Mar 16, 2021
useless now that conan-io#4597 is merged
conan-center-bot pushed a commit that referenced this pull request Mar 21, 2021
* civetweb: bump openssl

* remove openssl patching

useless now that #4597 is merged

* disable lto

this avoids following error in test recipe:
libcivetweb-cpp.a: error adding symbols: Archive has no index; run ranlib to add one
Croydon added a commit to bincrafters/conan-center-index that referenced this pull request Sep 9, 2021
conan-center-bot pushed a commit that referenced this pull request Sep 11, 2021
* openssl: create 3.x.x directory

* openssl/3.x.x: Update license to Apache-2.0

* openssl/3.x.x: Update reporting issues URL

* openssl/3.x.x: Add no_deprecated, no_legacy and no_fips options

* openssl/3.x.x: Delete patch for 1.1.1

* openssl/3.x.x: Update option from no_zlib to zlib

* openssl/3.x.x: Remove removed options no_md2 and no_rc5

* openssl/3.x.x.: no_rc4 is still a valid option

https://github.com/openssl/openssl/blob/1b495200436b57309ca958a7a72affaf75171c1a/INSTALL.md#no-algorithm

* openssl/3.x.x: Remove legacy target names

* openssl/3.x.x.: Remove more legacy conditions

* openssl/3.x.x: Fix zlib option name

* Revert "openssl/3.x.x: Update license to Apache-2.0"

This reverts commit 13852ab1da9678d3700440bee862561af7878b37.

* openssl/3.x.x: Actually update license to Apache-2.0

* openssl/3.x.x.: Remove all legacy version switches

* openssl/3.x.x: Use OpenSSL_version instead of legacy SSLeay_version

* openssl/3.x.x.: update test_package to never  use find_package()

Several reasons for this decision:

1) No matter the value of the paramter use_find_package CMake did always use a FindOpenSSL.cmake file

2) On my machine that meant that CMake used a FindOpenSSL.cmake file from my Python installation, which can't yet handle version 3.0.0 due to a regex error

3) Even when I addded the Conan cmake_find_package generator, it did not work (more cpp_info work needed, maybe?)

4) Even when 3) would be fixed, it would still always use the FindOpenSSL.cmake approach for some reason (I guess), so the entire use_find_package switch is pointless

* openssl/3.x.x.: Remove custom OpenSSLVersion object

* openssl/3.x.x.: Remove legacy target_prefix

* openssl/3.x.x.: Remove custom _cross_building method

Since tools.cross_building() has now a skip_x64_x86 flag

* openssl/3.x.x: Some formatting

* openssl/3.x.x: Remove old workaround for MinGW

This got fixed in the meantime via openssl/openssl@9694ebf

See also openssl/openssl#7653

* openssl/3.x.x: add no_engine option

* openssl/3.x.x: Add 3.0.0-alpha5

* openssl/3.x.x: Port #1782 from @syoliver - add components

* openssl/3.x.x: Fix license test

The LICENSE file got renamed to LICENSE.txt

* openssl/3.x.x: add old/ URLs as mirrors

* openssl/3.x.x: threat URLs explicit as strings

* openssl/3.x.x: add 3.0.0-alpha6

* openssl/3.x.x: the downloads have permament locations now

This seems to be the case for a while now, but not for all old versions we support in the recipe for the 1.x.x versions

It also does not seem to apply for pre-release versions, which rather  seem to get de-published

See also here: openssl/openssl#4469

* openssl: Update Conan conventions

Automatically created by bincrafters-conventions 0.26.0

* openssl/3.x.x: reorder methods

* openssl/3.x.x: add 3.0.0-alpha7

* openssl/3.x.x: test upstream PR 13225

openssl/openssl#13225

* openssl/3.x.x: update patch from upstream PR13225

* openssl/3.x.x: port #2944 Require installation of msys2 for MinGW builds

* openssl/3.x.x: port #3214 fix openssl/** build with shared and fPIC option for OS Neutrino

* openssl/3.x.x: add 3.0.0-alpha8

* openssl/3.x.x: remove fPIC when shared

Co-authored-by: Anonymous Maarten <[email protected]>

* openssl/3.x.x: add 3.0.0-alpha9

* openssl/3.x.x: use get_safe for fPIC

* openssl/3.x.x: don't use get_safe for zlib option

Co-authored-by: Anonymous Maarten <[email protected]>

* openssl/3.x.x: add 3.0.0-alpha10

* openssl/3.x.x: add openssl/3.0.0-alpha11

* openssl: Update Conan conventions

Automatically created by bincrafters-conventions 0.30.2

* openssl/3.x.x: add openssl/3.0.0

* openssl: Update Conan conventions

Automatically created by bincrafters-conventions 0.30.5

* openssl/3.x.x: modernize

Co-Authored-By: Anonymous Maarten <[email protected]>

* openssl/3.x.x: modernize

Co-Authored-By: Anonymous Maarten <[email protected]>

* openssl/3.x.x: replace os.rename -> tools.rename

* opeensl/3.x.x.: nit

Co-authored-by: Anonymous Maarten <[email protected]>

* openssl/3.x.x: readd old versions to config.yml

Co-Authored-By: Anonymous Maarten <[email protected]>

* openssl/3.x.x: remove platform import

Co-authored-by: Anonymous Maarten <[email protected]>

* openssl/3.x.x: fix typo in option name

* openssl/3.x.x: more tools modernizations

* openssl/3.x.x: use textwrap

Co-authored-by: Anonymous Maarten <[email protected]>

* openssl/3.x.x: remove MD5 and SHA1 from test_package

* openssl/3.x.x: use self.options.get_safe()

* openssl: add openssl.pc + fix libdir

* openssl: convert test to pure C source

* openssl: use spaces in test source

* openssl/3.x.x: remove SSL_library_init from test_package

* openssl: run openssl binary in test package

* openssl: digest.c only needs crypto library

* openssl: remove unused definitions for cmake

* openssl: enable fPIC when not enabled + use zlib's shared option correctly

* openssl: don't echo args (there is log.print_run_commands) + don't add shared/zlib multiple times

* openssl: tools.XCRun only acceps Settings object

* openssl: use self.settings.os

* openssl: reformatting + be the first to use f-strings + functools.lru_cache

* openssl: ./Configure --help does not print any targets.

* openssl: fix critical typo

* openssl: fix sneaky usage of tools.os_info in build_requirements

* openssl/3.x.x: remove patch for macOS shared

Co-Authored-By: Bowb <[email protected]>

* openssl/3.x.x: port #4460 remove explicit apple deployment target flag

Co-Authored-By: SSE4 <[email protected]>

* openssl/3.x.x: port #4597 provide official variables in cmake_find_package

Co-Authored-By: SpaceIm <[email protected]>

* openssl/3.x.x: port #4698 fix rt dependency for SUSE11

Co-Authored-By: Alexey Klimkin <[email protected]>

* openssl/3.x.x: port #4772 fix builddirs and add vars module to cmake_find_package only

Co-Authored-By: SpaceIm <[email protected]>

* openssl/3.x.x: port #5441 closes #4740

Co-Authored-By: Dmitry Bely <[email protected]>

* openssl/3.x.x: port #3998 add libatomic in build dependency for Neutrino OS

Co-Authored-By: Arenoros <[email protected]>

* openssl/3.x.x: port #6337 OpenSSL on Windows: multi-profile support

Co-Authored-By: Stefan Floeren <[email protected]>

* openssl/3.x.x: port #6588 Add macOS ARM target

Co-Authored-By: gmeeker <[email protected]>

* openssl/3.x.x: port #6884 Build openssl for emscripten

Co-Authored-By: Volodymyr B. <[email protected]>

* openssl: reformatting fixes

* openssl: make method property + remove unused import

* openssl: reverse sort openssl's config.yml

* openssl: only run openssl when not cross building

* openssl: port options of openssl 1.1.1

* openssl: fix MSVC install + remove options unsupported by openssl 3 + openssl exe is only available when building with no_stio=False

* force push

Signed-off-by: Uilian Ries <[email protected]>

* openssl: add missing options + various reformatting

Co-authored-by: bincrafters-user <[email protected]>
Co-authored-by: Anonymous Maarten <[email protected]>
Co-authored-by: Anonymous Maarten <[email protected]>
Co-authored-by: Bowb <[email protected]>
Co-authored-by: SSE4 <[email protected]>
Co-authored-by: SpaceIm <[email protected]>
Co-authored-by: Alexey Klimkin <[email protected]>
Co-authored-by: Dmitry Bely <[email protected]>
Co-authored-by: Arenoros <[email protected]>
Co-authored-by: Stefan Floeren <[email protected]>
Co-authored-by: gmeeker <[email protected]>
Co-authored-by: Volodymyr B. <[email protected]>
Co-authored-by: Uilian Ries <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.