-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
civetweb: bump openssl #4899
civetweb: bump openssl #4899
Conversation
Failure in build 1 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's take advantage of this change to also remove OPENSSL_INCLUDE_DIR variables patching.
It will make recipe easier and more future-proof.
@ericLemanissier I also don't know what the issue is with the linkage :( |
54ffc53
useless now that conan-io#4597 is merged
Failure in build 2 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
this avoids following error in test recipe: libcivetweb-cpp.a: error adding symbols: Archive has no index; run ranlib to add one
All green in build 3 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with disabling LTO, but I don't know CCI policy about it.
My ideas are not very clear regarding LTO interaction with conan, but I think that as soon as there is one LTO object file, then the linker must use the LTO flag. This means that conan would have to magically inject the LTO flag when linking a project, if any of the requirements use LTO. This is quite an important bit of circuitry, which I don't think is implemented in conan yet. The following paragraph is most probably based on a false premise: |
@SSE4 @uilianries What do you think about this one ? |
IMO LTO and few other flags (e.g. RTTI, exceptions, etc.) fall into the category that should be enabled for all libraries, but we're not modelling them right now. I'd assume LTO=off by default for now. |
Specify library name and version: civetweb/*
conan-center hook activated.