Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

civetweb: bump openssl #4899

Merged
merged 3 commits into from
Mar 21, 2021
Merged

Conversation

ericLemanissier
Copy link
Contributor

Specify library name and version: civetweb/*

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

Croydon
Croydon previously approved these changes Mar 16, 2021
@conan-center-bot
Copy link
Collaborator

Failure in build 1 (84408a6f5ded565fa0073003ab0b4fe8e491e8f7):

  • civetweb/1.13@:
    CI failed to create some packages (All logs)

    Logs for packageID 53e59cbd14ceadd0dce7a712ed5ccb3ff08e68be:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Release
    compiler=clang
    compiler.libcxx=libstdc++
    compiler.version=10
    os=Linux
    os_build=Linux
    [options]
    civetweb:shared=False
    
    -- The CXX compiler identification is Clang 10.0.1
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Check for working CXX compiler: /usr/bin/clang++ - skipped
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Conan: called by CMake conan helper
    -- Conan: Adjusting output directories
    -- Conan: Using cmake global configuration
    -- Conan: Adjusting default RPATHs Conan policies
    -- Conan: Adjusting language standard
    -- Conan: Compiler Clang>=8, checking major version 10
    -- Conan: Checking correct version: 10
    -- Conan: C++ stdlib: libstdc++
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /home/conan/w/BuildSingleReference/conan-center-index/recipes/civetweb/all/test_package/build/12104616acc010ea5ae3efa8aa48650cb62e8c82
    
    ----Running------
    > cmake --build '/home/conan/w/BuildSingleReference/conan-center-index/recipes/civetweb/all/test_package/build/12104616acc010ea5ae3efa8aa48650cb62e8c82' '--' '-j3'
    -----------------
    Scanning dependencies of target test_package
    [ 50%] Building CXX object CMakeFiles/test_package.dir/test_package.cpp.o
    [100%] Linking CXX executable bin/test_package
    CMakeFiles/test_package.dir/build.make:102: recipe for target 'bin/test_package' failed
    CMakeFiles/Makefile2:94: recipe for target 'CMakeFiles/test_package.dir/all' failed
    Makefile:102: recipe for target 'all' failed
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_EXPORT_NO_PACKAGE_REGISTRY
        CMAKE_INSTALL_BINDIR
        CMAKE_INSTALL_DATAROOTDIR
        CMAKE_INSTALL_INCLUDEDIR
        CMAKE_INSTALL_LIBDIR
        CMAKE_INSTALL_LIBEXECDIR
        CMAKE_INSTALL_OLDINCLUDEDIR
        CMAKE_INSTALL_SBINDIR
    
    
    /home/conan/w/BuildSingleReference/.conan/data/civetweb/1.13/_/_/package/53e59cbd14ceadd0dce7a712ed5ccb3ff08e68be/lib/libcivetweb-cpp.a: error adding symbols: Archive has no index; run ranlib to add one
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    make[2]: *** [bin/test_package] Error 1
    make[1]: *** [CMakeFiles/test_package.dir/all] Error 2
    make: *** [all] Error 2
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component openssl::openssl libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component civetweb::civetweb libdir "lib" does not contain any declared library
    ERROR: civetweb/1.13 (test package): Error in build() method, line 12
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build '/home/conan/w/BuildSingleReference/conan-center-index/recipes/civetweb/all/test_package/build/12104616acc010ea5ae3efa8aa48650cb62e8c82' '--' '-j3'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@ericLemanissier

This comment has been minimized.

mathbunnyru
mathbunnyru previously approved these changes Mar 16, 2021
Copy link
Contributor

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's take advantage of this change to also remove OPENSSL_INCLUDE_DIR variables patching.
It will make recipe easier and more future-proof.

@mathbunnyru
Copy link
Contributor

@ericLemanissier I also don't know what the issue is with the linkage :(

@ericLemanissier ericLemanissier dismissed stale reviews from mathbunnyru and Croydon via 54ffc53 March 16, 2021 11:30
useless now that conan-io#4597 is merged
mathbunnyru
mathbunnyru previously approved these changes Mar 16, 2021
@conan-center-bot
Copy link
Collaborator

Failure in build 2 (54ffc536c13413e4ef3b95a5c3f3d3635cef9d98):

  • civetweb/1.13@:
    CI failed to create some packages (All logs)

    Logs for packageID 53e59cbd14ceadd0dce7a712ed5ccb3ff08e68be:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Release
    compiler=clang
    compiler.libcxx=libstdc++
    compiler.version=10
    os=Linux
    os_build=Linux
    [options]
    civetweb:shared=False
    
    -- The CXX compiler identification is Clang 10.0.1
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Check for working CXX compiler: /usr/bin/clang++ - skipped
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Conan: called by CMake conan helper
    -- Conan: Adjusting output directories
    -- Conan: Using cmake global configuration
    -- Conan: Adjusting default RPATHs Conan policies
    -- Conan: Adjusting language standard
    -- Conan: Compiler Clang>=8, checking major version 10
    -- Conan: Checking correct version: 10
    -- Conan: C++ stdlib: libstdc++
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /home/conan/w/BuildSingleReference/conan-center-index/recipes/civetweb/all/test_package/build/12104616acc010ea5ae3efa8aa48650cb62e8c82
    
    ----Running------
    > cmake --build '/home/conan/w/BuildSingleReference/conan-center-index/recipes/civetweb/all/test_package/build/12104616acc010ea5ae3efa8aa48650cb62e8c82' '--' '-j3'
    -----------------
    Scanning dependencies of target test_package
    [ 50%] Building CXX object CMakeFiles/test_package.dir/test_package.cpp.o
    [100%] Linking CXX executable bin/test_package
    CMakeFiles/test_package.dir/build.make:102: recipe for target 'bin/test_package' failed
    CMakeFiles/Makefile2:94: recipe for target 'CMakeFiles/test_package.dir/all' failed
    Makefile:102: recipe for target 'all' failed
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_EXPORT_NO_PACKAGE_REGISTRY
        CMAKE_INSTALL_BINDIR
        CMAKE_INSTALL_DATAROOTDIR
        CMAKE_INSTALL_INCLUDEDIR
        CMAKE_INSTALL_LIBDIR
        CMAKE_INSTALL_LIBEXECDIR
        CMAKE_INSTALL_OLDINCLUDEDIR
        CMAKE_INSTALL_SBINDIR
    
    
    /home/conan/w/BuildSingleReference/.conan/data/civetweb/1.13/_/_/package/53e59cbd14ceadd0dce7a712ed5ccb3ff08e68be/lib/libcivetweb-cpp.a: error adding symbols: Archive has no index; run ranlib to add one
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    make[2]: *** [bin/test_package] Error 1
    make[1]: *** [CMakeFiles/test_package.dir/all] Error 2
    make: *** [all] Error 2
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component openssl::openssl libdir "lib" does not contain any declared library
    [HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component civetweb::civetweb libdir "lib" does not contain any declared library
    ERROR: civetweb/1.13 (test package): Error in build() method, line 12
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build '/home/conan/w/BuildSingleReference/conan-center-index/recipes/civetweb/all/test_package/build/12104616acc010ea5ae3efa8aa48650cb62e8c82' '--' '-j3'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

this avoids following error in test recipe:
libcivetweb-cpp.a: error adding symbols: Archive has no index; run ranlib to add one
@conan-center-bot
Copy link
Collaborator

All green in build 3 (7a3a92df36a5b23d700d10278d3c18ee0562d6c8):

  • civetweb/1.13@:
    All packages built successfully! (All logs)

Copy link
Contributor

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with disabling LTO, but I don't know CCI policy about it.

@ericLemanissier
Copy link
Contributor Author

ericLemanissier commented Mar 18, 2021

My ideas are not very clear regarding LTO interaction with conan, but I think that as soon as there is one LTO object file, then the linker must use the LTO flag. This means that conan would have to magically inject the LTO flag when linking a project, if any of the requirements use LTO. This is quite an important bit of circuitry, which I don't think is implemented in conan yet.

The following paragraph is most probably based on a false premise:
when linking a program with LTO (as a consumer), all the object files (conan requirements) need to be compiled with LTO. So it does not seem to me that it can work, except if conan treats LTO option of recipes as a "special" option, and automatically checks that the full dependency graph uses LTO during validate step.

@ericLemanissier
Copy link
Contributor Author

@SSE4 @uilianries What do you think about this one ?

@SSE4
Copy link
Contributor

SSE4 commented Mar 19, 2021

IMO LTO and few other flags (e.g. RTTI, exceptions, etc.) fall into the category that should be enabled for all libraries, but we're not modelling them right now. I'd assume LTO=off by default for now.

@conan-center-bot conan-center-bot merged commit 9f1a78c into conan-io:master Mar 21, 2021
@ericLemanissier ericLemanissier deleted the patch-6 branch March 21, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants