Build openssl for emscripten #6884

3d4m-volodymyr · 2021-08-16T16:16:29Z

Made few changes which make it possible to build OpenSSL for Emsccripten very easy.

Emscripten installed as per manual on official website emscripten.org.
Emscripten activated in terminal/console and using custom profile below.

[settings]
os=Emscripten
arch=wasm
compiler=emcc
compiler.version=2.0.13
compiler.libcxx=libc++
build_type=Release
[options]

[env]
CONAN_CMAKE_FIND_ROOT_PATH=$EMSDK/upstream/emscripten/system
CONAN_CMAKE_TOOLCHAIN_FILE=$EMSDK/upstream/emscripten/cmake/Modules/Platform/Emscripten.cmake
CC="emcc"
AR="emar"
RANLIB="emranlib"

the command used to build library
conan create . openssl/1.1.1k@ -pr emsdk_profile

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

…patible.

CLAassistant · 2021-08-16T16:16:34Z

All committers have signed the CLA.

madebr · 2021-08-16T16:21:21Z

recipes/openssl/1.x.x/conanfile.py

+               "no_stdio": [True, False],
+               "no_tests": [True, False],


You need to add default values to default_options as well.

Nevermind. Openssl does this with a loop.

madebr · 2021-08-16T16:24:15Z

recipes/openssl/1.x.x/conanfile.py

+            self.options.no_asm = True
+            self.options.no_deprecated = True
+            self.options.no_dso = True
+            self.options.no_threads = True
+            self.options.no_stdio = True
+            self.options.no_tests = True


This makes it still possible to run:

conan create . openssl/1.1.1k@ -pr emsdk_profile -o openssl:no_stdio=False

Should this also be tested in a validate method?

def validate(self): if self.settings.or == "Emscripten": if not all((self.options.no_asm, self.options.no_deprecated, self.options.no_dso, self.options.no_threads, self.options.no_stdio, self.options.no_tests)): raise ConanInvalidConfiguration("os=Emscripten requires openssl:{no_asm,no_deprecated,no_dso,no_threads,no_stdio,no_tests}=True")

thanks, I will add this check

I'm wondering whether the test should be self.settings.os == "Emscripten" or self.settings.arch == "wasm".

Does my suggestion actually work? Does it block -o openssl:no_asm=False? I didn't verify locally.

this is good question! But idk any other sdks that are capable of compiling that complicated code to wasm.

Does my suggestion actually work? Does it block -o openssl:no_asm=False? I didn't verify locally.

yes it does

madebr · 2021-08-17T09:26:46Z

recipes/openssl/1.x.x/conanfile.py

+    def validate(self):
+        if self.settings.os == "Emscripten":
+            if not all((self.options.no_asm, self.options.no_threads, self.options.no_stdio, self.options.no_tests)):
+                raise ConanInvalidConfiguration("os=Emscripten requires openssl:{no_asm,,no_threads,no_stdio,no_tests}=True")


Suggested change

raise ConanInvalidConfiguration("os=Emscripten requires openssl:{no_asm,,no_threads,no_stdio,no_tests}=True")

raise ConanInvalidConfiguration("os=Emscripten requires openssl:{no_asm,no_threads,no_stdio,no_tests}=True")

3d4m-volodymyr · 2021-08-18T18:14:00Z

@madebr I removed few things that are not necessary for Emscripten. Do you have an idea why the build failed?

madebr · 2021-08-18T18:19:14Z

It's an internal c3i error. Probably something timed out.
Try closing, waiting 10 secons, and re-opening this pr.

3d4m-volodymyr · 2021-08-18T19:35:20Z

Pending — Contributor License Agreement is not signed yet.

I did sign, strange :)

prince-chrismc · 2021-08-21T01:51:38Z

CLA is not passing FYI

Seems the authorship on your commits is not you github user account that signed the CLA

SSE4 · 2021-08-21T07:34:25Z

@3d4m-vladimir please sign CLA

ghost · 2021-08-24T17:25:41Z

I detected other pull requests that are modifying openssl/1.x.x recipe:

add openssl/1.1.1l #7034

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

3d4m-volodymyr · 2021-08-25T15:26:17Z

@3d4m-vladimir please sign CLA

I did sign, don't know why it showing if I'm not

3d4m-volodymyr · 2021-08-25T15:31:18Z

@SSE4 @prince-chrismc sorry, found what is wrong

conan-center-bot · 2021-08-25T19:46:10Z

All green in build 7 (6b3b7f164c84456cab820c3b5c78aa9513763c60):

openssl/1.0.2s@:
All packages built successfully! (All logs)
openssl/1.0.2t@:
All packages built successfully! (All logs)
openssl/1.0.2u@:
All packages built successfully! (All logs)
openssl/1.1.1i@:
All packages built successfully! (All logs)
openssl/1.1.0k@:
All packages built successfully! (All logs)
openssl/1.1.0l@:
All packages built successfully! (All logs)
openssl/1.1.1c@:
All packages built successfully! (All logs)
openssl/1.1.1d@:
All packages built successfully! (All logs)
openssl/1.1.1e@:
All packages built successfully! (All logs)
openssl/1.1.1f@:
All packages built successfully! (All logs)
openssl/1.1.1g@:
All packages built successfully! (All logs)
openssl/1.1.1h@:
All packages built successfully! (All logs)
openssl/1.1.1j@:
All packages built successfully! (All logs)
openssl/1.1.1k@:
All packages built successfully! (All logs)

Co-Authored-By: Volodymyr B. <[email protected]>

@syoliver

* openssl: create 3.x.x directory * openssl/3.x.x: Update license to Apache-2.0 * openssl/3.x.x: Update reporting issues URL * openssl/3.x.x: Add no_deprecated, no_legacy and no_fips options * openssl/3.x.x: Delete patch for 1.1.1 * openssl/3.x.x: Update option from no_zlib to zlib * openssl/3.x.x: Remove removed options no_md2 and no_rc5 * openssl/3.x.x.: no_rc4 is still a valid option https://github.com/openssl/openssl/blob/1b495200436b57309ca958a7a72affaf75171c1a/INSTALL.md#no-algorithm * openssl/3.x.x: Remove legacy target names * openssl/3.x.x.: Remove more legacy conditions * openssl/3.x.x: Fix zlib option name * Revert "openssl/3.x.x: Update license to Apache-2.0" This reverts commit 13852ab1da9678d3700440bee862561af7878b37. * openssl/3.x.x: Actually update license to Apache-2.0 * openssl/3.x.x.: Remove all legacy version switches * openssl/3.x.x: Use OpenSSL_version instead of legacy SSLeay_version * openssl/3.x.x.: update test_package to never use find_package() Several reasons for this decision: 1) No matter the value of the paramter use_find_package CMake did always use a FindOpenSSL.cmake file 2) On my machine that meant that CMake used a FindOpenSSL.cmake file from my Python installation, which can't yet handle version 3.0.0 due to a regex error 3) Even when I addded the Conan cmake_find_package generator, it did not work (more cpp_info work needed, maybe?) 4) Even when 3) would be fixed, it would still always use the FindOpenSSL.cmake approach for some reason (I guess), so the entire use_find_package switch is pointless * openssl/3.x.x.: Remove custom OpenSSLVersion object * openssl/3.x.x.: Remove legacy target_prefix * openssl/3.x.x.: Remove custom _cross_building method Since tools.cross_building() has now a skip_x64_x86 flag * openssl/3.x.x: Some formatting * openssl/3.x.x: Remove old workaround for MinGW This got fixed in the meantime via openssl/openssl@9694ebf See also openssl/openssl#7653 * openssl/3.x.x: add no_engine option * openssl/3.x.x: Add 3.0.0-alpha5 * openssl/3.x.x: Port #1782 from @syoliver - add components * openssl/3.x.x: Fix license test The LICENSE file got renamed to LICENSE.txt * openssl/3.x.x: add old/ URLs as mirrors * openssl/3.x.x: threat URLs explicit as strings * openssl/3.x.x: add 3.0.0-alpha6 * openssl/3.x.x: the downloads have permament locations now This seems to be the case for a while now, but not for all old versions we support in the recipe for the 1.x.x versions It also does not seem to apply for pre-release versions, which rather seem to get de-published See also here: openssl/openssl#4469 * openssl: Update Conan conventions Automatically created by bincrafters-conventions 0.26.0 * openssl/3.x.x: reorder methods * openssl/3.x.x: add 3.0.0-alpha7 * openssl/3.x.x: test upstream PR 13225 openssl/openssl#13225 * openssl/3.x.x: update patch from upstream PR13225 * openssl/3.x.x: port #2944 Require installation of msys2 for MinGW builds * openssl/3.x.x: port #3214 fix openssl/** build with shared and fPIC option for OS Neutrino * openssl/3.x.x: add 3.0.0-alpha8 * openssl/3.x.x: remove fPIC when shared Co-authored-by: Anonymous Maarten <[email protected]> * openssl/3.x.x: add 3.0.0-alpha9 * openssl/3.x.x: use get_safe for fPIC * openssl/3.x.x: don't use get_safe for zlib option Co-authored-by: Anonymous Maarten <[email protected]> * openssl/3.x.x: add 3.0.0-alpha10 * openssl/3.x.x: add openssl/3.0.0-alpha11 * openssl: Update Conan conventions Automatically created by bincrafters-conventions 0.30.2 * openssl/3.x.x: add openssl/3.0.0 * openssl: Update Conan conventions Automatically created by bincrafters-conventions 0.30.5 * openssl/3.x.x: modernize Co-Authored-By: Anonymous Maarten <[email protected]> * openssl/3.x.x: modernize Co-Authored-By: Anonymous Maarten <[email protected]> * openssl/3.x.x: replace os.rename -> tools.rename * opeensl/3.x.x.: nit Co-authored-by: Anonymous Maarten <[email protected]> * openssl/3.x.x: readd old versions to config.yml Co-Authored-By: Anonymous Maarten <[email protected]> * openssl/3.x.x: remove platform import Co-authored-by: Anonymous Maarten <[email protected]> * openssl/3.x.x: fix typo in option name * openssl/3.x.x: more tools modernizations * openssl/3.x.x: use textwrap Co-authored-by: Anonymous Maarten <[email protected]> * openssl/3.x.x: remove MD5 and SHA1 from test_package * openssl/3.x.x: use self.options.get_safe() * openssl: add openssl.pc + fix libdir * openssl: convert test to pure C source * openssl: use spaces in test source * openssl/3.x.x: remove SSL_library_init from test_package * openssl: run openssl binary in test package * openssl: digest.c only needs crypto library * openssl: remove unused definitions for cmake * openssl: enable fPIC when not enabled + use zlib's shared option correctly * openssl: don't echo args (there is log.print_run_commands) + don't add shared/zlib multiple times * openssl: tools.XCRun only acceps Settings object * openssl: use self.settings.os * openssl: reformatting + be the first to use f-strings + functools.lru_cache * openssl: ./Configure --help does not print any targets. * openssl: fix critical typo * openssl: fix sneaky usage of tools.os_info in build_requirements * openssl/3.x.x: remove patch for macOS shared Co-Authored-By: Bowb <[email protected]> * openssl/3.x.x: port #4460 remove explicit apple deployment target flag Co-Authored-By: SSE4 <[email protected]> * openssl/3.x.x: port #4597 provide official variables in cmake_find_package Co-Authored-By: SpaceIm <[email protected]> * openssl/3.x.x: port #4698 fix rt dependency for SUSE11 Co-Authored-By: Alexey Klimkin <[email protected]> * openssl/3.x.x: port #4772 fix builddirs and add vars module to cmake_find_package only Co-Authored-By: SpaceIm <[email protected]> * openssl/3.x.x: port #5441 closes #4740 Co-Authored-By: Dmitry Bely <[email protected]> * openssl/3.x.x: port #3998 add libatomic in build dependency for Neutrino OS Co-Authored-By: Arenoros <[email protected]> * openssl/3.x.x: port #6337 OpenSSL on Windows: multi-profile support Co-Authored-By: Stefan Floeren <[email protected]> * openssl/3.x.x: port #6588 Add macOS ARM target Co-Authored-By: gmeeker <[email protected]> * openssl/3.x.x: port #6884 Build openssl for emscripten Co-Authored-By: Volodymyr B. <[email protected]> * openssl: reformatting fixes * openssl: make method property + remove unused import * openssl: reverse sort openssl's config.yml * openssl: only run openssl when not cross building * openssl: port options of openssl 1.1.1 * openssl: fix MSVC install + remove options unsupported by openssl 3 + openssl exe is only available when building with no_stio=False * force push Signed-off-by: Uilian Ries <[email protected]> * openssl: add missing options + various reformatting Co-authored-by: bincrafters-user <[email protected]> Co-authored-by: Anonymous Maarten <[email protected]> Co-authored-by: Anonymous Maarten <[email protected]> Co-authored-by: Bowb <[email protected]> Co-authored-by: SSE4 <[email protected]> Co-authored-by: SpaceIm <[email protected]> Co-authored-by: Alexey Klimkin <[email protected]> Co-authored-by: Dmitry Bely <[email protected]> Co-authored-by: Arenoros <[email protected]> Co-authored-by: Stefan Floeren <[email protected]> Co-authored-by: gmeeker <[email protected]> Co-authored-by: Volodymyr B. <[email protected]> Co-authored-by: Uilian Ries <[email protected]>

3d4m-volodymyr added 3 commits August 16, 2021 16:56

Build openssl package for Emscripten. Disable things that are not com…

d55af66

…patible.

remove disable things; some algorithms work faster with those options;

d245561

remove unused things

c649384

madebr reviewed Aug 16, 2021

View reviewed changes

add validate

b42a9c7

This comment has been minimized.

Sign in to view

remove unnecessary disabled things

058240f

madebr reviewed Aug 17, 2021

View reviewed changes

fix typo

6b3b7f1

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Aug 17, 2021

3d4m-volodymyr closed this Aug 18, 2021

3d4m-volodymyr reopened this Aug 18, 2021

This comment has been minimized.

Sign in to view

conan-center-bot added the Unexpected Error label Aug 19, 2021

This comment has been minimized.

Sign in to view

conan-center-bot removed Unexpected Error Failed labels Aug 19, 2021

madebr approved these changes Aug 19, 2021

View reviewed changes

github-actions bot mentioned this pull request Aug 19, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

uilianries approved these changes Aug 20, 2021

View reviewed changes

prince-chrismc mentioned this pull request Aug 21, 2021

core: always display prs with no reivews prince-chrismc/conan-center-index-pending-review#24

Merged

prince-chrismc approved these changes Aug 21, 2021

View reviewed changes

SSE4 approved these changes Aug 21, 2021

View reviewed changes

This was referenced Aug 24, 2021

[service] Potentially conflicting recipes #3571

Closed

add openssl/1.1.1l #7034

Merged

3d4m-volodymyr closed this Aug 25, 2021

3d4m-volodymyr reopened this Aug 25, 2021

conan-center-bot merged commit 3a6dfb9 into conan-io:master Aug 25, 2021

3d4m-volodymyr deleted the build-openssl-for-emscripten branch August 26, 2021 08:26

Croydon added a commit to bincrafters/conan-center-index that referenced this pull request Sep 9, 2021

openssl/3.x.x: port conan-io#6884 Build openssl for emscripten

cf6eee7

Co-Authored-By: Volodymyr B. <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build openssl for emscripten #6884

Build openssl for emscripten #6884

3d4m-volodymyr commented Aug 16, 2021 •

edited

Loading

CLAassistant commented Aug 16, 2021 •

edited

Loading

madebr Aug 16, 2021

madebr Aug 16, 2021

madebr Aug 16, 2021 •

edited

Loading

3d4m-volodymyr Aug 16, 2021

madebr Aug 16, 2021

madebr Aug 16, 2021

3d4m-volodymyr Aug 16, 2021

3d4m-volodymyr Aug 16, 2021

This comment has been minimized.

madebr Aug 17, 2021

This comment has been minimized.

3d4m-volodymyr commented Aug 18, 2021

madebr commented Aug 18, 2021

3d4m-volodymyr commented Aug 18, 2021

This comment has been minimized.

This comment has been minimized.

prince-chrismc commented Aug 21, 2021 •

edited

Loading

SSE4 commented Aug 21, 2021

ghost commented Aug 24, 2021

3d4m-volodymyr commented Aug 25, 2021

3d4m-volodymyr commented Aug 25, 2021

conan-center-bot commented Aug 25, 2021

	raise ConanInvalidConfiguration("os=Emscripten requires openssl:{no_asm,,no_threads,no_stdio,no_tests}=True")
	raise ConanInvalidConfiguration("os=Emscripten requires openssl:{no_asm,no_threads,no_stdio,no_tests}=True")

Build openssl for emscripten #6884

Build openssl for emscripten #6884

Conversation

3d4m-volodymyr commented Aug 16, 2021 • edited Loading

CLAassistant commented Aug 16, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

madebr Aug 16, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

Choose a reason for hiding this comment

This comment has been minimized.

3d4m-volodymyr commented Aug 18, 2021

madebr commented Aug 18, 2021

3d4m-volodymyr commented Aug 18, 2021

This comment has been minimized.

This comment has been minimized.

prince-chrismc commented Aug 21, 2021 • edited Loading

SSE4 commented Aug 21, 2021

ghost commented Aug 24, 2021

3d4m-volodymyr commented Aug 25, 2021

3d4m-volodymyr commented Aug 25, 2021

conan-center-bot commented Aug 25, 2021

3d4m-volodymyr commented Aug 16, 2021 •

edited

Loading

CLAassistant commented Aug 16, 2021 •

edited

Loading

madebr Aug 16, 2021 •

edited

Loading

prince-chrismc commented Aug 21, 2021 •

edited

Loading