add openssl/3.0.0 #7229
Merged
add openssl/3.0.0 #7229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 13852ab1da9678d3700440bee862561af7878b37.
Several reasons for this decision: 1) No matter the value of the paramter use_find_package CMake did always use a FindOpenSSL.cmake file 2) On my machine that meant that CMake used a FindOpenSSL.cmake file from my Python installation, which can't yet handle version 3.0.0 due to a regex error 3) Even when I addded the Conan cmake_find_package generator, it did not work (more cpp_info work needed, maybe?) 4) Even when 3) would be fixed, it would still always use the FindOpenSSL.cmake approach for some reason (I guess), so the entire use_find_package switch is pointless
Since tools.cross_building() has now a skip_x64_x86 flag
This got fixed in the meantime via openssl/openssl@9694ebf See also openssl/openssl#7653
The LICENSE file got renamed to LICENSE.txt
This seems to be the case for a while now, but not for all old versions we support in the recipe for the 1.x.x versions It also does not seem to apply for pre-release versions, which rather seem to get de-published See also here: openssl/openssl#4469
Automatically created by bincrafters-conventions 0.26.0
… openssl exe is only available when building with no_stio=False
This comment has been minimized.
This comment has been minimized.
madebr
previously approved these changes
Sep 10, 2021
uilianries
previously approved these changes
Sep 10, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <[email protected]>
|
@Croydon there was some conflicts from master, I executed |
uilianries
approved these changes
Sep 10, 2021
|
All green in build 29 (
|
|
Right, because we merged #7219 quicker now |
|
@madebr Did you check for every single option that you added that they are still supported by 3.0? |
madebr
approved these changes
Sep 10, 2021
|
Yesterday, I did a build with all all |
|
Thanks @madebr I'm fine with the state of this PR |
prince-chrismc
approved these changes
Sep 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: openssl/3.0.0
conan-center hook activated.
Continuation of #2054
The intention of this is NOT:
The intention of this is:
Important resources:
Upstream bugs:
@build fails if build path contains @ openssl/openssl#12078Open questions / TODO (certainly incomplete):
fork(). OpenSSL merged in the meantime a "partial fix" (openssl/openssl@ca81124), so even when we set one of the flags (HAVE_FORKorNO_FORK, which one would it be anyway? Why two of them?) it does not seem to be fixed upstream. But we should probably wait a few pre-releases longer, before we might patch from our side again. See also Issue building 1.1.1 on OSX with iOS and tvOS architectures openssl/openssl#7607package()whennmakeis usedbuild_typeisDebugwe give the lib files adprefix. Why? Is this really wanted and still needed for >= 3.0.0?find_package(OpenSSL)/FindOpenSSL.cmake, see my comments here: a2bb89btest_packagewill probably fail in its current form with certain different option valuesCROSS_COMPILE[WIP] add openssl/3.0.0 #2054 (comment)