Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libatomic in build dependency for Neutrino OS #3998

Merged
merged 1 commit into from
May 25, 2021

Conversation

Arenoros
Copy link
Contributor

openssl/all

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

Fix build error on QNX.

....
./libcrypto.a(rsa_lib.o): In function `RSA_up_ref':
rsa_lib.c:(.text+0x37c): undefined reference to `__atomic_fetch_add_4'
./libcrypto.a(threads_pthread.o): In function `CRYPTO_atomic_add':
threads_pthread.c:(.text+0x1cc): undefined reference to `__atomic_is_lock_free'
threads_pthread.c:(.text+0x21c): undefined reference to `__atomic_fetch_add_4'
./libcrypto.a(x509_lu.o): In function `X509_STORE_free':
x509_lu.c:(.text+0x5f4): undefined reference to `__atomic_fetch_sub_4'
./libcrypto.a(x509_lu.o): In function `X509_STORE_up_ref':
x509_lu.c:(.text+0x6bc): undefined reference to `__atomic_fetch_add_4'
./libcrypto.a(x509_set.o): In function `X509_up_ref':
x509_set.c:(.text+0x138): undefined reference to `__atomic_fetch_add_4'
./libcrypto.a(x509cset.o): In function `X509_CRL_up_ref':
x509cset.c:(.text+0xe8): undefined reference to `__atomic_fetch_add_4'
...

@ghost
Copy link

ghost commented Dec 26, 2020

I detected other pull requests that are modifying openssl/1.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@prince-chrismc
Copy link
Contributor

Just to confirm, your logs only show it's required for crypto, is it also required for ssl?

@madebr
Copy link
Contributor

madebr commented Dec 26, 2020

Just to confirm, your logs only show it's required for crypto, is it also required for ssl?

crypto is a dependency of ssl, so adding it to only one should suffice.
The link order will always be: -lssl -lcrypto -latomic.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Jan 25, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 25, 2021
@dmn-star
Copy link
Contributor

@Arenoros If you still want to merge your changes, the nasm GPF is fixed.

nasm.EXE' : return code '0xc0000005

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Apr 27, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 27, 2021
@ghost ghost mentioned this pull request May 5, 2021
4 tasks
@ghost ghost mentioned this pull request May 21, 2021
4 tasks
@SSE4 SSE4 closed this May 25, 2021
@SSE4 SSE4 reopened this May 25, 2021
@stale stale bot removed the stale label May 25, 2021
@conan-center-bot
Copy link
Collaborator

All green in build 3 (67fda52e08639f84705d0dd9814158e40519e895):

  • openssl/1.0.2s@:
    All packages built successfully! (All logs)

  • openssl/1.0.2u@:
    All packages built successfully! (All logs)

  • openssl/1.1.0k@:
    All packages built successfully! (All logs)

  • openssl/1.0.2t@:
    All packages built successfully! (All logs)

  • openssl/1.1.0l@:
    All packages built successfully! (All logs)

  • openssl/1.1.1d@:
    All packages built successfully! (All logs)

  • openssl/1.1.1e@:
    All packages built successfully! (All logs)

  • openssl/1.1.1c@:
    All packages built successfully! (All logs)

  • openssl/1.1.1j@:
    All packages built successfully! (All logs)

  • openssl/1.1.1k@:
    All packages built successfully! (All logs)

  • openssl/1.1.1f@:
    All packages built successfully! (All logs)

  • openssl/1.1.1i@:
    All packages built successfully! (All logs)

  • openssl/1.1.1g@:
    All packages built successfully! (All logs)

  • openssl/1.1.1h@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 6afd411 into conan-io:master May 25, 2021
madebr pushed a commit to madebr/conan-center-index that referenced this pull request Jun 21, 2021
Croydon added a commit to bincrafters/conan-center-index that referenced this pull request Sep 9, 2021
conan-center-bot pushed a commit that referenced this pull request Sep 11, 2021
* openssl: create 3.x.x directory

* openssl/3.x.x: Update license to Apache-2.0

* openssl/3.x.x: Update reporting issues URL

* openssl/3.x.x: Add no_deprecated, no_legacy and no_fips options

* openssl/3.x.x: Delete patch for 1.1.1

* openssl/3.x.x: Update option from no_zlib to zlib

* openssl/3.x.x: Remove removed options no_md2 and no_rc5

* openssl/3.x.x.: no_rc4 is still a valid option

https://github.com/openssl/openssl/blob/1b495200436b57309ca958a7a72affaf75171c1a/INSTALL.md#no-algorithm

* openssl/3.x.x: Remove legacy target names

* openssl/3.x.x.: Remove more legacy conditions

* openssl/3.x.x: Fix zlib option name

* Revert "openssl/3.x.x: Update license to Apache-2.0"

This reverts commit 13852ab1da9678d3700440bee862561af7878b37.

* openssl/3.x.x: Actually update license to Apache-2.0

* openssl/3.x.x.: Remove all legacy version switches

* openssl/3.x.x: Use OpenSSL_version instead of legacy SSLeay_version

* openssl/3.x.x.: update test_package to never  use find_package()

Several reasons for this decision:

1) No matter the value of the paramter use_find_package CMake did always use a FindOpenSSL.cmake file

2) On my machine that meant that CMake used a FindOpenSSL.cmake file from my Python installation, which can't yet handle version 3.0.0 due to a regex error

3) Even when I addded the Conan cmake_find_package generator, it did not work (more cpp_info work needed, maybe?)

4) Even when 3) would be fixed, it would still always use the FindOpenSSL.cmake approach for some reason (I guess), so the entire use_find_package switch is pointless

* openssl/3.x.x.: Remove custom OpenSSLVersion object

* openssl/3.x.x.: Remove legacy target_prefix

* openssl/3.x.x.: Remove custom _cross_building method

Since tools.cross_building() has now a skip_x64_x86 flag

* openssl/3.x.x: Some formatting

* openssl/3.x.x: Remove old workaround for MinGW

This got fixed in the meantime via openssl/openssl@9694ebf

See also openssl/openssl#7653

* openssl/3.x.x: add no_engine option

* openssl/3.x.x: Add 3.0.0-alpha5

* openssl/3.x.x: Port #1782 from @syoliver - add components

* openssl/3.x.x: Fix license test

The LICENSE file got renamed to LICENSE.txt

* openssl/3.x.x: add old/ URLs as mirrors

* openssl/3.x.x: threat URLs explicit as strings

* openssl/3.x.x: add 3.0.0-alpha6

* openssl/3.x.x: the downloads have permament locations now

This seems to be the case for a while now, but not for all old versions we support in the recipe for the 1.x.x versions

It also does not seem to apply for pre-release versions, which rather  seem to get de-published

See also here: openssl/openssl#4469

* openssl: Update Conan conventions

Automatically created by bincrafters-conventions 0.26.0

* openssl/3.x.x: reorder methods

* openssl/3.x.x: add 3.0.0-alpha7

* openssl/3.x.x: test upstream PR 13225

openssl/openssl#13225

* openssl/3.x.x: update patch from upstream PR13225

* openssl/3.x.x: port #2944 Require installation of msys2 for MinGW builds

* openssl/3.x.x: port #3214 fix openssl/** build with shared and fPIC option for OS Neutrino

* openssl/3.x.x: add 3.0.0-alpha8

* openssl/3.x.x: remove fPIC when shared

Co-authored-by: Anonymous Maarten <[email protected]>

* openssl/3.x.x: add 3.0.0-alpha9

* openssl/3.x.x: use get_safe for fPIC

* openssl/3.x.x: don't use get_safe for zlib option

Co-authored-by: Anonymous Maarten <[email protected]>

* openssl/3.x.x: add 3.0.0-alpha10

* openssl/3.x.x: add openssl/3.0.0-alpha11

* openssl: Update Conan conventions

Automatically created by bincrafters-conventions 0.30.2

* openssl/3.x.x: add openssl/3.0.0

* openssl: Update Conan conventions

Automatically created by bincrafters-conventions 0.30.5

* openssl/3.x.x: modernize

Co-Authored-By: Anonymous Maarten <[email protected]>

* openssl/3.x.x: modernize

Co-Authored-By: Anonymous Maarten <[email protected]>

* openssl/3.x.x: replace os.rename -> tools.rename

* opeensl/3.x.x.: nit

Co-authored-by: Anonymous Maarten <[email protected]>

* openssl/3.x.x: readd old versions to config.yml

Co-Authored-By: Anonymous Maarten <[email protected]>

* openssl/3.x.x: remove platform import

Co-authored-by: Anonymous Maarten <[email protected]>

* openssl/3.x.x: fix typo in option name

* openssl/3.x.x: more tools modernizations

* openssl/3.x.x: use textwrap

Co-authored-by: Anonymous Maarten <[email protected]>

* openssl/3.x.x: remove MD5 and SHA1 from test_package

* openssl/3.x.x: use self.options.get_safe()

* openssl: add openssl.pc + fix libdir

* openssl: convert test to pure C source

* openssl: use spaces in test source

* openssl/3.x.x: remove SSL_library_init from test_package

* openssl: run openssl binary in test package

* openssl: digest.c only needs crypto library

* openssl: remove unused definitions for cmake

* openssl: enable fPIC when not enabled + use zlib's shared option correctly

* openssl: don't echo args (there is log.print_run_commands) + don't add shared/zlib multiple times

* openssl: tools.XCRun only acceps Settings object

* openssl: use self.settings.os

* openssl: reformatting + be the first to use f-strings + functools.lru_cache

* openssl: ./Configure --help does not print any targets.

* openssl: fix critical typo

* openssl: fix sneaky usage of tools.os_info in build_requirements

* openssl/3.x.x: remove patch for macOS shared

Co-Authored-By: Bowb <[email protected]>

* openssl/3.x.x: port #4460 remove explicit apple deployment target flag

Co-Authored-By: SSE4 <[email protected]>

* openssl/3.x.x: port #4597 provide official variables in cmake_find_package

Co-Authored-By: SpaceIm <[email protected]>

* openssl/3.x.x: port #4698 fix rt dependency for SUSE11

Co-Authored-By: Alexey Klimkin <[email protected]>

* openssl/3.x.x: port #4772 fix builddirs and add vars module to cmake_find_package only

Co-Authored-By: SpaceIm <[email protected]>

* openssl/3.x.x: port #5441 closes #4740

Co-Authored-By: Dmitry Bely <[email protected]>

* openssl/3.x.x: port #3998 add libatomic in build dependency for Neutrino OS

Co-Authored-By: Arenoros <[email protected]>

* openssl/3.x.x: port #6337 OpenSSL on Windows: multi-profile support

Co-Authored-By: Stefan Floeren <[email protected]>

* openssl/3.x.x: port #6588 Add macOS ARM target

Co-Authored-By: gmeeker <[email protected]>

* openssl/3.x.x: port #6884 Build openssl for emscripten

Co-Authored-By: Volodymyr B. <[email protected]>

* openssl: reformatting fixes

* openssl: make method property + remove unused import

* openssl: reverse sort openssl's config.yml

* openssl: only run openssl when not cross building

* openssl: port options of openssl 1.1.1

* openssl: fix MSVC install + remove options unsupported by openssl 3 + openssl exe is only available when building with no_stio=False

* force push

Signed-off-by: Uilian Ries <[email protected]>

* openssl: add missing options + various reformatting

Co-authored-by: bincrafters-user <[email protected]>
Co-authored-by: Anonymous Maarten <[email protected]>
Co-authored-by: Anonymous Maarten <[email protected]>
Co-authored-by: Bowb <[email protected]>
Co-authored-by: SSE4 <[email protected]>
Co-authored-by: SpaceIm <[email protected]>
Co-authored-by: Alexey Klimkin <[email protected]>
Co-authored-by: Dmitry Bely <[email protected]>
Co-authored-by: Arenoros <[email protected]>
Co-authored-by: Stefan Floeren <[email protected]>
Co-authored-by: gmeeker <[email protected]>
Co-authored-by: Volodymyr B. <[email protected]>
Co-authored-by: Uilian Ries <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants