openssl: closes #4740

[db4]

openssl/1.1.1h

Closes #4740

---

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the
  conan-center hook activated.

[ghost]

I detected other pull requests that are modifying openssl/1.x.x recipe:

• add libatomic in build dependency for Neutrino OS #3998

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

[madebr]

This modifies the environment permanently.
When using a context, the changes to the environment are undone.

e.g.

from contextlib import contextmanager

@contextmanager
def _build_context(self):
    if self._use_nmake:
        def sanitize_env_var(var):
            return '"{}"'.format(var) if '"' not in var else var
        env = {key: sanitize_env_var(tools.get_env(key)) for key in ("CC", "CXX", "RC") if tools.get_env(key)}
        with tools.environment_append(env):
            yield
    else:
        yield

def build(self):
    with self._build_context():
        self.run("perl ./Configure")
        ...
        self._run_make()

[db4]

Yes, it sounds reasonable. But the environment modification should only be done for nmake (it breaks perl configure). I've committed the appropriate changes.

[db4]

openssl/1.0.2t: Forced build from source
Installing package: openssl/1.0.2t
Requirements
    openssl/1.0.2t from local cache - Cache
    zlib/1.2.11 from 'conan-center' - Cache
Packages
    openssl/1.0.2t:ac9d5cdf5785dec11eebde092369aebc238741d2 - Build
    zlib/1.2.11:2345d377da94e8ffae1333469573b8215c98c514 - Missing

Installing (downloading, building) binaries...

ERROR: Missing binary: zlib/1.2.11:2345d377da94e8ffae1333469573b8215c98c514
zlib/1.2.11: WARN: Can't find a 'zlib/1.2.11' package for the specified settings, options and dependencies:
- Settings: arch=x86_64, build_type=Debug, compiler=gcc, compiler.version=4.9, os=Linux
- Options: fPIC=True, minizip=deprecated, shared=False
- Dependencies: 
- Requirements: 
- Package ID: 2345d377da94e8ffae1333469573b8215c98c514

ERROR: Missing prebuilt package for 'zlib/1.2.11'

can anyone explain why it is failing now but succeeded yesterday?

[madebr]

I think this needs to be indented an extra level.

[db4]

Thanks for noting this!

[madebr]

A few lines above, env_vars is already setting the CC environment variable.
Maybe combine the sanitizing done in _make_context with that or refactor the env_vars on the top into a _build_context helper method?

[db4]

A few lines above, env_vars is already setting the CC environment variable.
Maybe combine the sanitizing done in _make_context with that or refactor the env_vars on the top into a _build_context helper method?

You can't do that easily: if your environment modification affects self._patch_configure(), the recipe will be broken because _patch_configure expects CC variable value without quotes. Anyway this _make_context solves one very special problem and IMHO should not be mixed with anything else.

[conan-center-bot]

All green in build 7 (5ff0eee178bb4471cf76013a758baad00e774846):

• openssl/1.0.2s@:
  All packages built successfully! (All logs)

• openssl/1.0.2u@:
  All packages built successfully! (All logs)

• openssl/1.1.1e@:
  All packages built successfully! (All logs)

• openssl/1.0.2t@:
  All packages built successfully! (All logs)

• openssl/1.1.0k@:
  All packages built successfully! (All logs)

• openssl/1.1.0l@:
  All packages built successfully! (All logs)

• openssl/1.1.1c@:
  All packages built successfully! (All logs)

• openssl/1.1.1i@:
  All packages built successfully! (All logs)

• openssl/1.1.1d@:
  All packages built successfully! (All logs)

• openssl/1.1.1g@:
  All packages built successfully! (All logs)

• openssl/1.1.1k@:
  All packages built successfully! (All logs)

• openssl/1.1.1f@:
  All packages built successfully! (All logs)

• openssl/1.1.1h@:
  All packages built successfully! (All logs)

• openssl/1.1.1j@:
  All packages built successfully! (All logs)