Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libtins 4.2 #4587

Merged
merged 17 commits into from
Feb 20, 2021
Merged

Add libtins 4.2 #4587

merged 17 commits into from
Feb 20, 2021

Conversation

Fefer-Ivan
Copy link
Contributor

Specify library name and version: libtins/4.2

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

recipes/libtins/all/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/libtins/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libtins/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libtins/all/test_package/test_package.cpp Outdated Show resolved Hide resolved
recipes/libtins/all/test_package/conanfile.py Outdated Show resolved Hide resolved
recipes/libtins/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot
Copy link
Collaborator

Failure in build 4 (55cb21255fcb90e91cb07960cd3336d9d7fc2841):

  • libtins/4.2@:
    CI failed to create some packages (All logs)

    Logs for packageID f0dc063e99ade83ae4bf499c338a37994291c9f9:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++
    compiler.version=5
    os=Linux
    os_build=Linux
    [options]
    libtins:shared=False
    
    -- Conan: Adjusting default RPATHs Conan policies
    -- Conan: Adjusting language standard
    -- Conan: Compiler GCC>=5, checking major version 5
    -- Conan: Checking correct version: 5
    -- Conan: C++ stdlib: libstdc++
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /home/conan/w/BuildSingleReference/conan-center-index/recipes/libtins/all/test_package/build/be80431928c1b7d90676bdbd72d7ae3da3e78547
    
    ----Running------
    > cmake --build '/home/conan/w/BuildSingleReference/conan-center-index/recipes/libtins/all/test_package/build/be80431928c1b7d90676bdbd72d7ae3da3e78547' '--' '-j3'
    -----------------
    Scanning dependencies of target test_package
    [ 50%] Building CXX object CMakeFiles/test_package.dir/test_package.cpp.o
    CMakeFiles/test_package.dir/build.make:81: recipe for target 'CMakeFiles/test_package.dir/test_package.cpp.o' failed
    CMakeFiles/Makefile2:94: recipe for target 'CMakeFiles/test_package.dir/all' failed
    Makefile:102: recipe for target 'all' failed
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    
    
    In file included from /home/conan/w/BuildSingleReference/.conan/data/libtins/4.2/_/_/package/f0dc063e99ade83ae4bf499c338a37994291c9f9/include/tins/tins.h:62:0,
                     from /home/conan/w/BuildSingleReference/conan-center-index/recipes/libtins/all/test_package/test_package.cpp:1:
    /home/conan/w/BuildSingleReference/.conan/data/libtins/4.2/_/_/package/f0dc063e99ade83ae4bf499c338a37994291c9f9/include/tins/crypto.h:271:18: error: ‘function’ in namespace ‘std’ does not name a template type
         typedef std::function<void(const std::string&,
                      ^
    /home/conan/w/BuildSingleReference/.conan/data/libtins/4.2/_/_/package/f0dc063e99ade83ae4bf499c338a37994291c9f9/include/tins/crypto.h:282:18: error: ‘function’ in namespace ‘std’ does not name a template type
         typedef std::function<void(const std::string&,
                      ^
    /home/conan/w/BuildSingleReference/.conan/data/libtins/4.2/_/_/package/f0dc063e99ade83ae4bf499c338a37994291c9f9/include/tins/crypto.h:375:44: error: ‘handshake_captured_callback_type’ does not name a type
         void handshake_captured_callback(const handshake_captured_callback_type& callback);
                                                ^
    /home/conan/w/BuildSingleReference/.conan/data/libtins/4.2/_/_/package/f0dc063e99ade83ae4bf499c338a37994291c9f9/include/tins/crypto.h:386:34: error: ‘ap_found_callback_type’ does not name a type
         void ap_found_callback(const ap_found_callback_type& callback);
                                      ^
    /home/conan/w/BuildSingleReference/.conan/data/libtins/4.2/_/_/package/f0dc063e99ade83ae4bf499c338a37994291c9f9/include/tins/crypto.h:419:9: error: ‘handshake_captured_callback_type’ does not name a type
             handshake_captured_callback_type handshake_captured_callback_;
             ^
    /home/conan/w/BuildSingleReference/.conan/data/libtins/4.2/_/_/package/f0dc063e99ade83ae4bf499c338a37994291c9f9/include/tins/crypto.h:420:9: error: ‘ap_found_callback_type’ does not name a type
             ap_found_callback_type ap_found_callback_;
             ^
    make[2]: *** [CMakeFiles/test_package.dir/test_package.cpp.o] Error 1
    make[1]: *** [CMakeFiles/test_package.dir/all] Error 2
    make: *** [all] Error 2
    boost/1.75.0: WARN: Picked up a system libbacktrace library
    ERROR: libtins/4.2 (test package): Error in build() method, line 12
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build '/home/conan/w/BuildSingleReference/conan-center-index/recipes/libtins/all/test_package/build/be80431928c1b7d90676bdbd72d7ae3da3e78547' '--' '-j3'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@conan-center-bot
Copy link
Collaborator

Failure in build 6 (cf15052617e96afa84839912096babf12a5072a5):

  • libtins/4.2@:
    CI failed to create some packages (All logs)

    Logs for packageID 173d8770ea3cdc2bd1bd73cba3a82b24d29f3e7c:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Release
    compiler=apple-clang
    compiler.libcxx=libc++
    compiler.version=11.0
    os=Macos
    os_build=Macos
    [options]
    libtins:shared=True
    
    libtins/4.2: 
    CMake Warning at source_subfolder/CMakeLists.txt:118 (MESSAGE):
      Disabling C++11 features.  Use LIBTINS_ENABLE_CXX11=1 to enable them.
      Unless you are using an old compiler, you should enable this option, as it
      increases the library's performance
    
    
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_INSTALL_DATAROOTDIR
        CMAKE_INSTALL_INCLUDEDIR
        CMAKE_INSTALL_LIBEXECDIR
        CMAKE_INSTALL_OLDINCLUDEDIR
        CMAKE_INSTALL_SBINDIR
    
    
    In file included from /Users/jenkins/w/BuildSingleReference@3/.conan/data/libtins/4.2/_/_/build/173d8770ea3cdc2bd1bd73cba3a82b24d29f3e7c/source_subfolder/src/ip_reassembler.cpp:32:
    /Users/jenkins/w/BuildSingleReference@3/.conan/data/libtins/4.2/_/_/build/173d8770ea3cdc2bd1bd73cba3a82b24d29f3e7c/source_subfolder/src/../include/tins/ip_reassembler.h:195:26: warning: private field 'technique_' is not used [-Wunused-private-field]
        OverlappingTechnique technique_;
                             ^
    1 warning generated.
    /Users/jenkins/w/BuildSingleReference@3/.conan/data/libtins/4.2/_/_/build/173d8770ea3cdc2bd1bd73cba3a82b24d29f3e7c/source_subfolder/src/utils/radiotap_parser.cpp:134:81: warning: unused parameter 'size' [-Wunused-parameter]
    void align_buffer(const uint8_t* buffer_start, const uint8_t*& buffer, uint32_t size, size_t n) {
                                                                                    ^
    1 warning generated.
    Undefined symbols for architecture x86_64:
      "_AES_encrypt", referenced from:
          Tins::Crypto::WPA2::SessionKeys::ccmp_decrypt_unicast(Tins::Dot11Data const&, Tins::RawPDU&) const in crypto.cpp.o
      "_AES_set_encrypt_key", referenced from:
          Tins::Crypto::WPA2::SessionKeys::ccmp_decrypt_unicast(Tins::Dot11Data const&, Tins::RawPDU&) const in crypto.cpp.o
      "_EVP_md5", referenced from:
          Tins::Crypto::WPA2::SessionKeys::SessionKeys(Tins::EAPOLHandshake<Tins::RSNEAPOL> const&, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > const&) in crypto.cpp.o
      "_EVP_sha1", referenced from:
          Tins::Crypto::WPA2::SessionKeys::SessionKeys(Tins::EAPOLHandshake<Tins::RSNEAPOL> const&, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > const&) in crypto.cpp.o
      "_HMAC", referenced from:
          Tins::Crypto::WPA2::SessionKeys::SessionKeys(Tins::EAPOLHandshake<Tins::RSNEAPOL> const&, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > const&) in crypto.cpp.o
      "_PKCS5_PBKDF2_HMAC_SHA1", referenced from:
          Tins::Crypto::WPA2::SupplicantData::SupplicantData(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in crypto.cpp.o
    ld: symbol(s) not found for architecture x86_64
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    make[2]: *** [lib/libtins.4.2.dylib] Error 1
    make[1]: *** [source_subfolder/src/CMakeFiles/tins.dir/all] Error 2
    make: *** [all] Error 2
    libtins/4.2: WARN: Build folder is dirty, removing it: /Users/jenkins/w/BuildSingleReference@3/.conan/data/libtins/4.2/_/_/build/173d8770ea3cdc2bd1bd73cba3a82b24d29f3e7c
    libtins/4.2: ERROR: Package '173d8770ea3cdc2bd1bd73cba3a82b24d29f3e7c' build failed
    libtins/4.2: WARN: Build folder /Users/jenkins/w/BuildSingleReference@3/.conan/data/libtins/4.2/_/_/build/173d8770ea3cdc2bd1bd73cba3a82b24d29f3e7c
    ERROR: libtins/4.2: Error in build() method, line 78
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build '/Users/jenkins/w/BuildSingleReference@3/.conan/data/libtins/4.2/_/_/build/173d8770ea3cdc2bd1bd73cba3a82b24d29f3e7c/build_subfolder' '--' '-j8'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@conan-center-bot
Copy link
Collaborator

Failure in build 8 (f855cb0063c2b6266727ea6e0313c1d71056304b):

  • libtins/4.2@:
    CI failed to create some packages (All logs)

    Logs for packageID 173d8770ea3cdc2bd1bd73cba3a82b24d29f3e7c:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Release
    compiler=apple-clang
    compiler.libcxx=libc++
    compiler.version=11.0
    os=Macos
    os_build=Macos
    [options]
    libtins:shared=True
    
    libtins/4.2: 
    CMake Warning at source_subfolder/CMakeLists.txt:118 (MESSAGE):
      Disabling C++11 features.  Use LIBTINS_ENABLE_CXX11=1 to enable them.
      Unless you are using an old compiler, you should enable this option, as it
      increases the library's performance
    
    
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_INSTALL_DATAROOTDIR
        CMAKE_INSTALL_INCLUDEDIR
        CMAKE_INSTALL_LIBEXECDIR
        CMAKE_INSTALL_OLDINCLUDEDIR
        CMAKE_INSTALL_SBINDIR
    
    
    In file included from /Users/jenkins/w/BuildSingleReference@3/.conan/data/libtins/4.2/_/_/build/173d8770ea3cdc2bd1bd73cba3a82b24d29f3e7c/source_subfolder/src/ip_reassembler.cpp:32:
    /Users/jenkins/w/BuildSingleReference@3/.conan/data/libtins/4.2/_/_/build/173d8770ea3cdc2bd1bd73cba3a82b24d29f3e7c/source_subfolder/src/../include/tins/ip_reassembler.h:195:26: warning: private field 'technique_' is not used [-Wunused-private-field]
        OverlappingTechnique technique_;
                             ^
    1 warning generated.
    /Users/jenkins/w/BuildSingleReference@3/.conan/data/libtins/4.2/_/_/build/173d8770ea3cdc2bd1bd73cba3a82b24d29f3e7c/source_subfolder/src/utils/radiotap_parser.cpp:134:81: warning: unused parameter 'size' [-Wunused-parameter]
    void align_buffer(const uint8_t* buffer_start, const uint8_t*& buffer, uint32_t size, size_t n) {
                                                                                    ^
    1 warning generated.
    Undefined symbols for architecture x86_64:
      "_AES_encrypt", referenced from:
          Tins::Crypto::WPA2::SessionKeys::ccmp_decrypt_unicast(Tins::Dot11Data const&, Tins::RawPDU&) const in crypto.cpp.o
      "_AES_set_encrypt_key", referenced from:
          Tins::Crypto::WPA2::SessionKeys::ccmp_decrypt_unicast(Tins::Dot11Data const&, Tins::RawPDU&) const in crypto.cpp.o
      "_EVP_md5", referenced from:
          Tins::Crypto::WPA2::SessionKeys::SessionKeys(Tins::EAPOLHandshake<Tins::RSNEAPOL> const&, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > const&) in crypto.cpp.o
      "_EVP_sha1", referenced from:
          Tins::Crypto::WPA2::SessionKeys::SessionKeys(Tins::EAPOLHandshake<Tins::RSNEAPOL> const&, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > const&) in crypto.cpp.o
      "_HMAC", referenced from:
          Tins::Crypto::WPA2::SessionKeys::SessionKeys(Tins::EAPOLHandshake<Tins::RSNEAPOL> const&, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > const&) in crypto.cpp.o
      "_PKCS5_PBKDF2_HMAC_SHA1", referenced from:
          Tins::Crypto::WPA2::SupplicantData::SupplicantData(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in crypto.cpp.o
    ld: symbol(s) not found for architecture x86_64
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    make[2]: *** [lib/libtins.4.2.dylib] Error 1
    make[1]: *** [source_subfolder/src/CMakeFiles/tins.dir/all] Error 2
    make: *** [all] Error 2
    libtins/4.2: WARN: Build folder is dirty, removing it: /Users/jenkins/w/BuildSingleReference@3/.conan/data/libtins/4.2/_/_/build/173d8770ea3cdc2bd1bd73cba3a82b24d29f3e7c
    libtins/4.2: ERROR: Package '173d8770ea3cdc2bd1bd73cba3a82b24d29f3e7c' build failed
    libtins/4.2: WARN: Build folder /Users/jenkins/w/BuildSingleReference@3/.conan/data/libtins/4.2/_/_/build/173d8770ea3cdc2bd1bd73cba3a82b24d29f3e7c
    ERROR: libtins/4.2: Error in build() method, line 78
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build '/Users/jenkins/w/BuildSingleReference@3/.conan/data/libtins/4.2/_/_/build/173d8770ea3cdc2bd1bd73cba3a82b24d29f3e7c/build_subfolder' '--' '-j8'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@conan-center-bot
Copy link
Collaborator

Failure in build 9 (de5ca7fe0e7aef40627377d0eca3b29d34a86041):

  • libtins/4.2@:
    CI failed to create some packages (All logs)

    Logs for packageID ac191819b355b5feb1c8cd214a40e8060cc27ef4:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Release
    compiler=apple-clang
    compiler.libcxx=libc++
    compiler.version=10.0
    os=Macos
    os_build=Macos
    [options]
    libtins:shared=True
    
    libtins/4.2: 
    CMake Warning at source_subfolder/CMakeLists.txt:118 (MESSAGE):
      Disabling C++11 features.  Use LIBTINS_ENABLE_CXX11=1 to enable them.
      Unless you are using an old compiler, you should enable this option, as it
      increases the library's performance
    
    
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_INSTALL_DATAROOTDIR
        CMAKE_INSTALL_INCLUDEDIR
        CMAKE_INSTALL_LIBEXECDIR
        CMAKE_INSTALL_OLDINCLUDEDIR
        CMAKE_INSTALL_SBINDIR
    
    
    In file included from /Users/jenkins/w/BuildSingleReference@4/.conan/data/libtins/4.2/_/_/build/ac191819b355b5feb1c8cd214a40e8060cc27ef4/source_subfolder/src/ip_reassembler.cpp:32:
    /Users/jenkins/w/BuildSingleReference@4/.conan/data/libtins/4.2/_/_/build/ac191819b355b5feb1c8cd214a40e8060cc27ef4/source_subfolder/src/../include/tins/ip_reassembler.h:195:26: warning: private field 'technique_' is not used [-Wunused-private-field]
        OverlappingTechnique technique_;
                             ^
    1 warning generated.
    /Users/jenkins/w/BuildSingleReference@4/.conan/data/libtins/4.2/_/_/build/ac191819b355b5feb1c8cd214a40e8060cc27ef4/source_subfolder/src/utils/radiotap_parser.cpp:134:81: warning: unused parameter 'size' [-Wunused-parameter]
    void align_buffer(const uint8_t* buffer_start, const uint8_t*& buffer, uint32_t size, size_t n) {
                                                                                    ^
    1 warning generated.
    Undefined symbols for architecture x86_64:
      "_AES_encrypt", referenced from:
          Tins::Crypto::WPA2::SessionKeys::ccmp_decrypt_unicast(Tins::Dot11Data const&, Tins::RawPDU&) const in crypto.cpp.o
      "_AES_set_encrypt_key", referenced from:
          Tins::Crypto::WPA2::SessionKeys::ccmp_decrypt_unicast(Tins::Dot11Data const&, Tins::RawPDU&) const in crypto.cpp.o
      "_EVP_md5", referenced from:
          Tins::Crypto::WPA2::SessionKeys::SessionKeys(Tins::EAPOLHandshake<Tins::RSNEAPOL> const&, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > const&) in crypto.cpp.o
      "_EVP_sha1", referenced from:
          Tins::Crypto::WPA2::SessionKeys::SessionKeys(Tins::EAPOLHandshake<Tins::RSNEAPOL> const&, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > const&) in crypto.cpp.o
      "_HMAC", referenced from:
          Tins::Crypto::WPA2::SessionKeys::SessionKeys(Tins::EAPOLHandshake<Tins::RSNEAPOL> const&, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > const&) in crypto.cpp.o
      "_PKCS5_PBKDF2_HMAC_SHA1", referenced from:
          Tins::Crypto::WPA2::SupplicantData::SupplicantData(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in crypto.cpp.o
    ld: symbol(s) not found for architecture x86_64
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    make[2]: *** [lib/libtins.4.2.dylib] Error 1
    make[1]: *** [source_subfolder/src/CMakeFiles/tins.dir/all] Error 2
    make: *** [all] Error 2
    libtins/4.2: WARN: Build folder is dirty, removing it: /Users/jenkins/w/BuildSingleReference@4/.conan/data/libtins/4.2/_/_/build/ac191819b355b5feb1c8cd214a40e8060cc27ef4
    libtins/4.2: ERROR: Package 'ac191819b355b5feb1c8cd214a40e8060cc27ef4' build failed
    libtins/4.2: WARN: Build folder /Users/jenkins/w/BuildSingleReference@4/.conan/data/libtins/4.2/_/_/build/ac191819b355b5feb1c8cd214a40e8060cc27ef4
    ERROR: libtins/4.2: Error in build() method, line 78
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build '/Users/jenkins/w/BuildSingleReference@4/.conan/data/libtins/4.2/_/_/build/ac191819b355b5feb1c8cd214a40e8060cc27ef4/build_subfolder' '--' '-j8'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Comment on lines 58 to 67
tools.replace_in_file(
os.path.join(self._source_subfolder, "CMakeLists.txt"),
"OPENSSL",
"OpenSSL"
)
tools.replace_in_file(
os.path.join(self._source_subfolder, "src", "CMakeLists.txt"),
"OPENSSL",
"OpenSSL"
)
Copy link
Contributor

@SpaceIm SpaceIm Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not like this (might work but there might be side effects).
Replace sparingly (OPENSSL_FOUND, OPENSSL_LIBRARIES and OPENSSL_INCLUDE_DIR) and not in source() but in build()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patching might be a better approach (it might be not).

Also, please create a PR in the upstream project to make this change redundant in the future.

Copy link
Contributor

@SpaceIm SpaceIm Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, there is nothing to submit to upstream, it's an issue in cmake_find_package generator of openssl.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's unfortunate, because I think there are many cases like this in the CCI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4597 should fix this issue

@conan-center-bot
Copy link
Collaborator

All green in build 10 (f821eb65594cf48a571130af99d875cf9f413524):

  • libtins/4.2@:
    All packages built successfully! (All logs)

recipes/libtins/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libtins/all/conanfile.py Show resolved Hide resolved
@conan-center-bot
Copy link
Collaborator

All green in build 12 (52623a9464babf922f728c1a891f78d7b7dd6323):

  • libtins/4.2@:
    All packages built successfully! (All logs)

SpaceIm
SpaceIm previously approved these changes Feb 17, 2021
Copy link
Contributor

@SpaceIm SpaceIm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake_find_package_multi is useless I believe, but otherwise LGTM

self._cmake.definitions["LIBTINS_BUILD_TESTS"] = False

self._cmake.definitions["LIBTINS_BUILD_SHARED"] = self.options.shared
self._cmake.definitions["LIBTINS_ENABLE_CXX11"] = tools.valid_min_cppstd(self, 11)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is never clear in my head, does this take into account the compiler's default and the build settings?

Copy link
Contributor

@SpaceIm SpaceIm Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it takes into account compiler.cppstd, and if not set default cpp standard of compiler.

@SSE4 SSE4 closed this Feb 18, 2021
@SSE4 SSE4 reopened this Feb 18, 2021
@conan-center-bot
Copy link
Collaborator

All green in build 14 (8a57b756ed1d60dc6d8b6ffd5f4f2afca1bdd4b4):

  • libtins/4.2@:
    All packages built successfully! (All logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants