-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libtins 4.2 #4587
Add libtins 4.2 #4587
Conversation
Co-authored-by: Ayaz Salikhov <[email protected]>
Co-authored-by: Ayaz Salikhov <[email protected]>
Failure in build 4 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Failure in build 6 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Failure in build 8 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Co-authored-by: SpaceIm <[email protected]>
Failure in build 9 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
recipes/libtins/all/conanfile.py
Outdated
tools.replace_in_file( | ||
os.path.join(self._source_subfolder, "CMakeLists.txt"), | ||
"OPENSSL", | ||
"OpenSSL" | ||
) | ||
tools.replace_in_file( | ||
os.path.join(self._source_subfolder, "src", "CMakeLists.txt"), | ||
"OPENSSL", | ||
"OpenSSL" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not like this (might work but there might be side effects).
Replace sparingly (OPENSSL_FOUND
, OPENSSL_LIBRARIES
and OPENSSL_INCLUDE_DIR
) and not in source()
but in build()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patching might be a better approach (it might be not).
Also, please create a PR in the upstream project to make this change redundant in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, there is nothing to submit to upstream, it's an issue in cmake_find_package generator of openssl.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's unfortunate, because I think there are many cases like this in the CCI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#4597 should fix this issue
All green in build 10 (
|
Co-authored-by: SpaceIm <[email protected]>
Co-authored-by: SpaceIm <[email protected]>
Co-authored-by: SpaceIm <[email protected]>
All green in build 12 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmake_find_package_multi
is useless I believe, but otherwise LGTM
self._cmake.definitions["LIBTINS_BUILD_TESTS"] = False | ||
|
||
self._cmake.definitions["LIBTINS_BUILD_SHARED"] = self.options.shared | ||
self._cmake.definitions["LIBTINS_ENABLE_CXX11"] = tools.valid_min_cppstd(self, 11) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is never clear in my head, does this take into account the compiler's default and the build settings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it takes into account compiler.cppstd, and if not set default cpp standard of compiler.
All green in build 14 (
|
Specify library name and version: libtins/4.2
conan-center hook activated.