explicitly link pythia6_pdfdummy where needed #46684

smuzaffar · 2024-11-13T06:28:37Z

This change along with cms-sw/cmsdist#9514 should properly link lhapdf library for ASNEEDED IBs. Currently pythia6 tool also link pythia6_pdfdummy library which provides the pdfset symbol. For ASNEEDED IBs, complier decided to not link lhapdf as the needed pdfset symbol was available via pythia6_pdfdummy. cmsdist PR moves pythia6_pdfdummy in to a separate tool file which is then only linked where it is needed.

Fixes #45747

cmsbuild · 2024-11-13T06:29:05Z

cms-bot internal usage

smuzaffar · 2024-11-13T06:29:34Z

test parameters:

pull_request = [pythia6]Move pythia6_pdfdummy in to separate tool cmsdist#9514
full_cmssw = true
workflows = 132.0,143.201,143.202,148.0,158.0,159.0,159.02,159.03,160.0,160.02,160.03,160.501,161.0,161.02,161.03,300.0,301.0,302.0,310.0,311.0,312.0,320.0,321.0,322.0,330.0,331.0,332.0,574.0,577.0

cmsbuild · 2024-11-13T06:32:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46684/42624

cmsbuild · 2024-11-13T06:32:39Z

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

GeneratorInterface/GenExtensions (generators)

@bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2024-11-13T06:33:39Z

please test

smuzaffar · 2024-11-13T08:08:49Z

please test

smuzaffar · 2024-11-13T10:09:23Z

please test for CMSSW_14_2_ASNEEDED_X

cmsbuild · 2024-11-13T13:43:03Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a10d50/42793/summary.html
COMMIT: 363de65
CMSSW: CMSSW_14_2_X_2024-11-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46684/42793/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 10 lines to the logs
Reco comparison results: 20 differences found in the comparisons
DQMHistoTests: Total files compared: 69
DQMHistoTests: Total histograms compared: 5726165
DQMHistoTests: Total failures: 428
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 5725717
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 68 files compared)
Checked 324 log files, 287 edm output root files, 69 DQM output files
TriggerResults: no differences found

cmsbuild · 2024-11-13T16:02:47Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a10d50/42798/summary.html
COMMIT: 363de65
CMSSW: CMSSW_14_2_ASNEEDED_X_2024-11-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46684/42798/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a10d50/42798/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a10d50/42798/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMGUIUpload had ERRORS

Comparison Summary

Summary:

You potentially added 202 lines to the logs
Reco comparison results: 2612 differences found in the comparisons
DQMHistoTests: Total files compared: 69
DQMHistoTests: Total histograms compared: 5726165
DQMHistoTests: Total failures: 2277
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 5723868
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 68 files compared)
Checked 324 log files, 287 edm output root files, 69 DQM output files
TriggerResults: no differences found

smuzaffar · 2024-11-13T16:06:34Z

please test for CMSSW_14_2_ASNEEDED_X

lets test full cmssw ( i.e all unit tests)

cmsbuild · 2024-11-14T00:17:43Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a10d50/42815/summary.html
COMMIT: 363de65
CMSSW: CMSSW_14_2_ASNEEDED_X_2024-11-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46684/42815/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@mmusich fix HLT online DQM client to cope with PbPb HLT strip collections #46622
@yeckang [GEM][Geometry] Resolving the issue of the overlapped chamber and add new GE21 chambers #46620
@bsunanda Phase2-hgx360H Change names from 2026 to Run4 in several scripts of Geometry/Hcal* and Geometry/HGCal* #46626
@Dr15Jones Added MinimizeSourceAndOutputTime #46603
@AdrianoDee Fix maxHitsInModule for SiPixelRecHitFromSoAAlpaka #46686
@bsunanda Phase2-hgx360N Change 2026 to Run4 in defining many scenarios in the scripts of CondTools/Geometry #46681
@woohyeonHeo Update the time resoultion of GEM Digitization #46653
@mbluj Protect TauSpinnerTable producer against crash with samples with HTT mixed with other processes #46679
@felicepantaleo TICL: protect from empty seeding region #46651
@Dr15Jones Thread safe caching of module info in HLTConfigData #46630
@fwyzard Fix BuildFiles, includes and comments #46657
@fwyzard Remove unused code from HeterogeneousCore/AlpakaCore #46654
@bsunanda Run3-gem81 Added the modified RPC geometry for the 2025 scenario as provided by Jongwon Shin #46670
@bsunanda Phase2-hgx360J Add the dd4hep version of the modified code of passive material description of V19 geometry of HGCal #46659
@civanch [SIM] Fixed compilation warning with the new Geant4 11.3 #46675
@nurfikri89 [JME, Nano] Add eta and phi of muon-subtracted raw jet for MET type-1 correction consistency #46676
@bsunanda Phase2-hgx360L Change 2026 to Run4 for scenario declarations in various scripts of Validation/HGCalValidation #46677
@jonathon-langford Adding HTXS variables to nanoAOD for on-the-fly 1.3 categorisation #46343
@mroguljic Fix qBin iteration in PixelCPEFastParamsHost.cc #46392
@mmusich make SiPixelPhase1TrackResiduals emit warnings if applyVertexCut_ is true and collection is invalid or empty #46645
@mmusich Add fillDescriptions to modules used in cosmics HLT reco #46647
@bsunanda Phase2-hgx360I Change names from 2026 to Run4 in several scripts of Geometry (CaloTopology|ForwardCommonData|GEMGeometry|MTDCommonData|MuonNumbering|TrackerCommonData|TrackerGeometryBuilder) #46648
@bsunanda Phase2-hgx360E Use the new way of defining passive materials for the HGCal v19 geometry #46596
@bsunanda Phase2-hgx360k Update he name of the file dict2026geometry to dictRun4 in Geometry/CMSCommonData and Fireworks/Geometry #46661

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a10d50/42815/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a10d50/42815/git-merge-result

Comparison Summary

Summary:

You potentially removed 123 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 643 differences found in the comparisons
DQMHistoTests: Total files compared: 69
DQMHistoTests: Total histograms compared: 5726165
DQMHistoTests: Total failures: 3631
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 5722514
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 37.138 KiB( 68 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 2.531 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 13234.0,... ): 1.689 KiB Physics/NanoAODDQM
Checked 324 log files, 287 edm output root files, 69 DQM output files
TriggerResults: no differences found

smuzaffar · 2024-11-14T07:16:45Z

@cms-sw/generators-l2 can you please review and sign this PR? This is just a technical update which will allow us to enable --as-needed link flag for cmssw

lviliani · 2024-11-14T14:54:30Z

+1

cmsbuild · 2024-11-14T14:54:54Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#9514

cmsbuild · 2024-11-14T14:59:38Z

REMINDER @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio: This PR was tested with cms-sw/cmsdist#9514, please check if they should be merged together

mandrenguyen · 2024-11-15T09:53:54Z

+1

explicitly link pythia6_pdfdummy where needed

363de65

cmsbuild added this to the CMSSW_14_2_X milestone Nov 13, 2024

cmsbuild added generators-pending pending-signatures tests-pending orp-pending code-checks-pending labels Nov 13, 2024

cmsbuild added the requires-external label Nov 13, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 13, 2024

cmsbuild added tests-started and removed tests-pending labels Nov 13, 2024

smuzaffar mentioned this pull request Nov 13, 2024

[pythia6]Move pythia6_pdfdummy in to separate tool cms-sw/cmsdist#9514

Merged

This was referenced Nov 13, 2024

[ASNEEDED_X] Multiple RelVals failing with SIGSEGV #45747

Closed

Simplify declaration of making Alpaka-based library to depend on the main library of the same package #45415

Closed

cmsbuild added tests-approved and removed tests-started labels Nov 13, 2024

cmsbuild added generators-approved fully-signed and removed generators-pending pending-signatures labels Nov 14, 2024

cmsbuild added orp-approved and removed orp-pending labels Nov 15, 2024

cmsbuild merged commit e2ad6a9 into cms-sw:master Nov 15, 2024
18 checks passed

cmsbuild mentioned this pull request Nov 15, 2024

Remove redefinition of EDM_ML_DEBUG in HcalDigitizer.cc #46708

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

explicitly link pythia6_pdfdummy where needed #46684

explicitly link pythia6_pdfdummy where needed #46684

smuzaffar commented Nov 13, 2024

cmsbuild commented Nov 13, 2024 •

edited

Loading

smuzaffar commented Nov 13, 2024 •

edited

Loading

cmsbuild commented Nov 13, 2024

cmsbuild commented Nov 13, 2024

smuzaffar commented Nov 13, 2024

smuzaffar commented Nov 13, 2024

smuzaffar commented Nov 13, 2024

cmsbuild commented Nov 13, 2024

cmsbuild commented Nov 13, 2024

smuzaffar commented Nov 13, 2024 •

edited

Loading

cmsbuild commented Nov 14, 2024

smuzaffar commented Nov 14, 2024

lviliani commented Nov 14, 2024

cmsbuild commented Nov 14, 2024

cmsbuild commented Nov 14, 2024

mandrenguyen commented Nov 15, 2024

explicitly link pythia6_pdfdummy where needed #46684

explicitly link pythia6_pdfdummy where needed #46684

Conversation

smuzaffar commented Nov 13, 2024

cmsbuild commented Nov 13, 2024 • edited Loading

smuzaffar commented Nov 13, 2024 • edited Loading

cmsbuild commented Nov 13, 2024

cmsbuild commented Nov 13, 2024

smuzaffar commented Nov 13, 2024

smuzaffar commented Nov 13, 2024

smuzaffar commented Nov 13, 2024

cmsbuild commented Nov 13, 2024

Comparison Summary

cmsbuild commented Nov 13, 2024

Unit Tests

Comparison Summary

smuzaffar commented Nov 13, 2024 • edited Loading

cmsbuild commented Nov 14, 2024

Comparison Summary

smuzaffar commented Nov 14, 2024

lviliani commented Nov 14, 2024

cmsbuild commented Nov 14, 2024

cmsbuild commented Nov 14, 2024

mandrenguyen commented Nov 15, 2024

cmsbuild commented Nov 13, 2024 •

edited

Loading

smuzaffar commented Nov 13, 2024 •

edited

Loading

smuzaffar commented Nov 13, 2024 •

edited

Loading