Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update a vertex smearing parameters for 2024 pp ref MC #46639

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

ashleyahram
Copy link

@ashleyahram ashleyahram commented Nov 8, 2024

PR description:

  • This PR adds a vertex smearing for 2024 pp ref MC. Beamspot position derived from runs 387590 to 387721, barycentre location provided by Tracker Alignment Group (cmsTalk)

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

  • We will need a backport for 14_1_X

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2024

A new Pull Request was created by @ashleyahram for master.

It involves the following packages:

  • Configuration/StandardSequences (operations)
  • IOMC/EventVertexGenerators (simulation)

@antoniovilela, @civanch, @cmsbuild, @davidlange6, @fabiocos, @kpedro88, @mandrenguyen, @mdhildreth, @rappoccio can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @fabiocos, @felicepantaleo, @grzanka, @makortel, @missirol, @mmusich, @mtosi, @rovere, @sameasy, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Nov 8, 2024

@ashleyahram shleyahram, just for your info, since this year in order to be able to consume the gen-level beam spot in production we need also a DB tag for SimBeamSpotRcd, see e.g PR #43242

@mmusich
Copy link
Contributor

mmusich commented Nov 8, 2024

@cmsbuild, please test

@ashleyahram
Copy link
Author

@ashleyahram shleyahram, just for your info, since this year in order to be able to consume the gen-level beam spot in production we need also a DB tag for SimBeamSpotRcd, see e.g PR #43242

Thank you for your information. I'll implement this too.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2024

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2afc0/42690/summary.html
COMMIT: beb7a45
CMSSW: CMSSW_14_2_X_2024-11-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46639/42690/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2afc0/42690/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2afc0/42690/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3342634
  • DQMHistoTests: Total failures: 423
  • DQMHistoTests: Total nulls: 20
  • DQMHistoTests: Total successes: 3342171
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 46.914 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 24834.911,... ): 7.819 KiB MTD/Tracks
  • Checked 195 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Nov 9, 2024

+1

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants