Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MTD validation]: update and reorganization of MtdTracksValidation #46618

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

martinamalberti
Copy link
Contributor

PR description:

This PR provides an update of the MtdTracksValidation class, including

PR validation:

Code compiles, runs and produces the desired plots. It was tested on the following samples:

  • SingleMuPt10: /store/relval/CMSSW_14_2_0_pre2/RelValSingleMuPt10/GEN-SIM-RECO/141X_mcRun4_realistic_v1_STD_RegeneratedGS_2026D110_noPU-v1/2580000/f3bc2ac7-6d7f-4fd5-ab55-a10c375be68e.root
  • MinBias: /store/relval/CMSSW_14_2_0_pre2/RelValMinBias_14TeV/GEN-SIM-RECO/141X_mcRun4_realistic_v1_STD_RegeneratedGS_2026D110_noPU-v1/2580000/ed421aa3-3974-4c13-8318-39034e4b96be.root

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46618/42519

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2024

A new Pull Request was created by @martinamalberti for master.

It involves the following packages:

  • Validation/MtdValidation (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@fabiocos, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

fabiocos commented Nov 7, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1c617/42645/summary.html
COMMIT: 5bf7820
CMSSW: CMSSW_14_2_X_2024-11-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46618/42645/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3342634
  • DQMHistoTests: Total failures: 430
  • DQMHistoTests: Total nulls: 20
  • DQMHistoTests: Total successes: 3342164
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 46.914 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 24834.911,... ): 7.819 KiB MTD/Tracks
  • Checked 195 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 92082d2 into cms-sw:master Nov 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants