Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOTMaster] Updated root to tip of branch master #9512

Conversation

iarspider
Copy link
Contributor

@iarspider iarspider commented Nov 11, 2024

Changes. Superseeds #9502

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_14_2_X/rootmaster.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 11, 2024

cms-bot internal usage

@iarspider
Copy link
Contributor Author

please test with cms-sw/cmssw#46635 for CMSSW_14_2_ROOT6_X

@iarspider
Copy link
Contributor Author

please abort

@cmsbuild
Copy link
Contributor

Pull request #9512 was updated.

@iarspider
Copy link
Contributor Author

please test with cms-sw/cmssw#46635 for CMSSW_14_2_ROOT6_X

@cmsbuild
Copy link
Contributor

Pull request #9512 was updated.

@smuzaffar
Copy link
Contributor

@iarspider , you also need to update dd4hep

@iarspider
Copy link
Contributor Author

@iarspider , you also need to update dd4hep

Did that already, thanks!

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b6ca8/42729/summary.html
COMMIT: 9ac2d11
CMSSW: CMSSW_14_2_ROOT6_X_2024-11-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9512/42729/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b6ca8/42729/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b6ca8/42729/git-merge-result

Build

I found compilation error when building:

>> Checking EDM Class Version for src/CalibFormats/CaloObjects/src/classes_def.xml in libCalibFormatsCaloObjects.so
>> Skipped running EDM Class Version test
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libCalibFormatsCaloObjects.so
@@@@ ----> OK  EDM Class Transients 
gmake: *** [tmp/el8_amd64_gcc12/edm_checks/libAnalysisDataFormatsTrackInfo.so] Error 1
@@@@ ----> OK  EDM Class Transients 
>> Checking EDM Class Version for src/CalibMuon/DTCalibration/test/stubs/classes_def.xml in libtestDTCalibration.so
@@@@ ----> OK  EDM Class Transients 
>> Skipped running EDM Class Version test
>> Checking EDM Class Version for src/CalibPPS/AlignmentRelative/src/classes_def.xml in libCalibPPSAlignmentRelative.so


@iarspider
Copy link
Contributor Author

iarspider commented Nov 12, 2024

test parameters:

  • release = CMSSW_14_2_ROOT6_X
  • full_cmssw = true

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b6ca8/42765/summary.html
COMMIT: 9ac2d11
CMSSW: CMSSW_14_2_ROOT6_X_2024-11-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9512/42765/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b6ca8/42765/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b6ca8/42765/git-merge-result

Unit Tests

I found 4 errors in the following unit tests:

---> test TestFWCoreReflectionClassVersionUpdate had ERRORS
---> test TestIOPoolInputNoParentDictionary had ERRORS
---> test testFWCoreConcurrency had ERRORS
and more ...

Comparison Summary

Summary:

@iarspider
Copy link
Contributor Author

iarspider commented Nov 12, 2024

src/FWCore/Reflection/test/TestFWCoreReflectionClassVersionUpdate and src/IOPool/Input/test/TestIOPoolInputNoParentDictionary - usual failures when ROOT version changes

src/FWCore/Concurrency/test/testFWCoreConcurrency - timed out

src/DQMServices/Demo/test/TestDQMGUIUpload - known failure cms-sw/cmssw#46682

@smuzaffar I think we can merge it, and keep an eye on testFWCoreConcurrency.

@smuzaffar
Copy link
Contributor

looks good

@smuzaffar smuzaffar merged commit 6f9b043 into cms-sw:IB/CMSSW_14_2_X/rootmaster Nov 12, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants