Replace deprecated constants for compression level

[iarspider]

PR description:

Deprecated for a long time, removed in 6.36 commit. The change should be backwards-compatible.

The kZLIB constant is also mentioned in PhysicsTools/NanoAODTools/python/postprocessing/framework/postprocessor.py, may need to be updated as well.

PR validation:

Bot tests

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46635/42542

• There are other open Pull requests which might conflict with changes you have proposed:
  • File PhysicsTools/NanoAOD/plugins/NanoAODOutputModule.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File PhysicsTools/NanoAOD/plugins/rntuple/NanoAODRNTupleOutputModule.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• IOPool/Output (core)
• PhysicsTools/NanoAOD (xpog)

@Dr15Jones, @cmsbuild, @ftorrresd, @hqucms, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc, @makortel, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test
to make sure that this change is indeed backwards-compatible

[cmsbuild]

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a5e3a/42681/summary.html
COMMIT: 2453221
CMSSW: CMSSW_14_2_X_2024-11-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46635/42681/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @makortel Exclude PluginManager cache from MaxMemoryPreload monitoring #46542
• @fwyzard Update testPrefixScan to work with different warp sizes #46629
• @mmusich fix a bunch of tests broken by cms-sw/cmssw#46582 #46608

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a5e3a/42681/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a5e3a/42681/git-merge-result

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3343138
• DQMHistoTests: Total failures: 386
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3342732
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 195 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[makortel]

Comparison differences are related to #46416

[makortel]

+core

[iarspider]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46635/42560

• There are other open Pull requests which might conflict with changes you have proposed:
  • File PhysicsTools/NanoAOD/plugins/NanoAODOutputModule.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File PhysicsTools/NanoAOD/plugins/rntuple/NanoAODRNTupleOutputModule.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

[cmsbuild]

Pull request #46635 was updated. @ftorrresd, @hqucms can you please check and sign again.

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a5e3a/42706/summary.html
COMMIT: c0970db
CMSSW: CMSSW_14_2_X_2024-11-10-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46635/42706/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3343588
• DQMHistoTests: Total failures: 427
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3343141
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[smuzaffar]

@cms-sw/xpog-l2 can you please review this PR. This will allow us to test latest ROOT changes in our ROOT6 IBs

[ftorrresd]

enable nano

[ftorrresd]

please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a5e3a/42727/summary.html
COMMIT: c0970db
CMSSW: CMSSW_14_2_X_2024-11-11-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46635/42727/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 4 lines to the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3343588
• DQMHistoTests: Total failures: 415
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3343153
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially removed 486 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 21
• DQMHistoTests: Total histograms compared: 55722
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 55722
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
• Checked 102 log files, 58 edm output root files, 21 DQM output files
• TriggerResults: no differences found

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.001	3.052	3.052	0.000 ( +0.0% )	2.78	2.70	+2.9%	2.511	2.506
2500.002	3.164	3.164	0.000 ( +0.0% )	2.49	2.42	+2.6%	2.943	2.946
2500.003	3.105	3.105	0.000 ( +0.0% )	2.60	2.53	+3.0%	2.925	2.926
2500.011	1.621	1.621	0.000 ( +0.0% )	4.30	4.12	+4.3%	2.609	2.598
2500.012	2.153	2.153	0.000 ( +0.0% )	2.57	2.52	+1.9%	2.801	2.795
2500.013	1.975	1.975	0.000 ( +0.0% )	3.60	3.50	+3.0%	2.708	2.701
2500.021	0.022	0.022	0.000 ( +0.0% )	0.93	0.86	+8.6%	2.560	2.550
2500.022	0.022	0.022	0.000 ( +0.0% )	0.89	0.83	+7.5%	2.550	2.546
2500.023	0.022	0.022	0.000 ( +0.0% )	0.88	0.82	+6.7%	2.411	2.421
2500.024	0.022	0.022	0.000 ( +0.0% )	0.68	0.62	+8.7%	2.644	2.642
2500.031	0.035	0.035	0.000 ( +0.0% )	0.79	0.74	+5.9%	2.615	2.616
2500.032	0.036	0.036	0.000 ( +0.0% )	0.79	0.74	+5.8%	2.577	2.583
2500.033	0.037	0.037	0.000 ( +0.0% )	0.75	0.69	+8.2%	2.662	2.666
2500.034	0.036	0.036	0.000 ( +0.0% )	0.75	0.70	+6.8%	2.642	2.644
2500.101	2.788	2.788	0.000 ( +0.0% )	7.06	6.56	+7.6%	2.616	2.610
2500.111	1.447	1.447	0.000 ( +0.0% )	13.71	13.16	+4.2%	2.318	2.323
2500.112	1.867	1.867	0.000 ( +0.0% )	11.64	11.12	+4.7%	2.396	2.390
2500.131	0.747	0.747	0.000 ( +0.0% )	18.22	16.96	+7.4%	1.509	1.480
2500.201	2.617	2.617	0.000 ( +0.0% )	5.91	5.49	+7.5%	2.173	2.174
2500.211	1.786	1.786	0.000 ( +0.0% )	11.99	11.21	+6.9%	2.380	2.381
2500.212	2.182	2.182	0.000 ( +0.0% )	10.26	9.37	+9.6%	2.464	2.456
2500.221	2.028	2.028	0.000 ( +0.0% )	6.19	5.83	+6.2%	2.084	2.088
2500.222	3.415	3.415	0.000 ( +0.0% )	5.78	5.47	+5.7%	2.182	2.179
2500.223	9.380	9.380	0.000 ( +0.0% )	1.78	1.67	+6.3%	2.260	2.209
2500.224	6.063	6.063	0.000 ( +0.0% )	0.59	0.56	+4.7%	2.202	2.199
2500.225	6.111	6.111	0.000 ( +0.0% )	0.55	0.53	+3.6%	2.411	2.401
2500.226	3.109	3.109	0.000 ( +0.0% )	6.02	5.58	+7.9%	2.177	2.124
2500.227	1.437	1.437	0.000 ( +0.0% )	11.80	10.90	+8.3%	1.431	1.429
2500.231	1.449	1.449	0.000 ( +0.0% )	10.19	9.28	+9.8%	2.272	2.271
2500.232	2.441	2.441	0.000 ( +0.0% )	9.73	8.92	+9.0%	2.384	2.379
2500.233	4.933	4.933	0.000 ( +0.0% )	2.68	2.44	+9.7%	2.450	2.433
2500.234	3.700	3.700	0.000 ( +0.0% )	0.75	0.70	+6.9%	2.159	2.403
2500.235	3.730	3.730	0.000 ( +0.0% )	0.71	0.69	+3.6%	2.356	2.605
2500.236	2.232	2.232	0.000 ( +0.0% )	10.27	9.36	+9.7%	2.381	2.379
2500.237	1.016	1.016	0.000 ( +0.0% )	17.40	16.01	+8.7%	1.438	1.461
2500.241	9.404	9.404	0.000 ( +0.0% )	3.84	3.35	+14.6%	1.922	1.921
2500.242	10.331	10.331	0.000 ( +0.0% )	0.90	0.81	+11.8%	1.709	1.708
2500.243	2.712	2.712	0.000 ( +0.0% )	8.29	7.87	+5.3%	1.077	1.069
2500.244	485.976	485.976	0.000 ( +0.0% )	0.57	0.52	+10.0%	1.555	1.672
2500.245	823.202	823.202	0.000 ( +0.0% )	0.76	0.69	+10.6%	1.243	1.658
2500.901	1.777	1.777	0.000 ( +0.0% )	21.46	19.35	+10.9%	1.416	1.418
2500.902	1.626	1.626	0.000 ( +0.0% )	21.83	19.97	+9.3%	1.318	1.323
2500.911	13.995	13.995	0.000 ( +0.0% )	3.73	3.48	+7.1%	1.090	1.086
2500.912	0.437	0.438	-0.002 ( -0.4% )	1.60	1.17	+37.0%	0.970	0.973
2500.913	0.110	0.110	0.000 ( +0.0% )	1.20	1.11	+8.3%	0.978	0.977

[ftorrresd]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1