[RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel

[mmusich]

PR description:

Following up to cms-sw/cms-sw.github.io#118 (comment), just to see what it would break.

PR validation:

None

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44372/39420

• This PR adds an extra 992KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Framework/test/stubs/TestOneAnalyzers.cc modified in PR(s): Remove code related to legacy modules and SharedResources #44271
  • File FWCore/Integration/plugins/ProducerWithPSetDesc.cc modified in PR(s): Generated cfi files can now use new module syntax #44363
  • File PhysicsTools/NanoAOD/plugins/rntuple/NanoAODRNTupleOutputModule.cc modified in PR(s): [ROOTMaster] Fix include for RNTuple* (redo of #44256) #44328

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• CalibCalorimetry/HcalPlugins (alca)
• CalibTracker/SiStripESProducers (alca)
• CalibTracker/StandaloneTrackerTopology (alca)
• CommonTools/RecoUtils (analysis)
• CondCore/CondHDF5ESSource (db)
• CondCore/ESSources (alca, db)
• CondFormats/MFObjects (alca)
• CondFormats/RecoMuonObjects (alca, db)
• CondTools/BeamSpot (alca, db)
• CondTools/Ecal (db)
• CondTools/RunInfo (db)
• DQM/SiStripMonitorHardware (dqm)
• DQMServices/FileIO (dqm)
• DQMServices/FwkIO (dqm)
• DataFormats/Common (core)
• DataFormats/DetId (simulation)
• DataFormats/FEDRawData (daq)
• DataFormats/HLTReco (hlt)
• DataFormats/L1Scouting (daq)
• DataFormats/L1ScoutingRawData (daq)
• DataFormats/L1TGlobal (l1)
• DataFormats/Scouting (core)
• DataFormats/SiStripCluster (reconstruction)
• DetectorDescription/DDCMS (geometry)
• EventFilter/HcalRawToDigi (reconstruction)
• FWCore/Framework (core)
• FWCore/Integration (core)
• FWCore/Modules (core)
• FWCore/ServiceRegistry (core)
• FWCore/Services (core)
• GeneratorInterface/GenFilters (generators)
• GeneratorInterface/LHEInterface (generators)
• Geometry/TrackerGeometryBuilder (geometry)
• GeometryReaders/XMLIdealGeometryESSource (geometry)
• HLTrigger/HLTanalyzers (hlt)
• IOPool/Input (core)
• IgTools/IgProf (core)
• JetMETCorrections/Modules (reconstruction)
• JetMETCorrections/Type1MET (reconstruction)
• L1Trigger/L1TCaloLayer1 (l1)
• L1Trigger/L1TCalorimeter (l1)
• L1Trigger/Phase2L1GT (l1, upgrade)
• L1Trigger/Phase2L1ParticleFlow (l1, upgrade)
• MagneticField/GeomBuilder (reconstruction)
• PhysicsTools/HepMCCandAlgos (analysis)
• PhysicsTools/NanoAOD (xpog)
• PhysicsTools/PatUtils (reconstruction, xpog)
• RecoBTag/Combined (reconstruction)
• RecoBTag/ImpactParameter (reconstruction)
• RecoBTag/SecondaryVertex (reconstruction)
• RecoBTag/SoftLepton (reconstruction)
• RecoBTau/JetTagComputer (reconstruction)
• RecoEgamma/EgammaElectronAlgos (reconstruction)
• RecoEgamma/EgammaTools (reconstruction)
• RecoEgamma/ElectronIdentification (reconstruction)
• RecoEgamma/PhotonIdentification (reconstruction)
• RecoHI/HiCentralityAlgos (reconstruction)
• RecoJets/JetProducers (reconstruction)
• RecoLocalCalo/CaloTowersCreator (reconstruction)
• RecoLocalCalo/Castor (reconstruction)
• RecoLocalCalo/EcalRecProducers (reconstruction)
• RecoLocalCalo/HcalRecAlgos (reconstruction)
• RecoLocalCalo/HcalRecProducers (reconstruction)
• RecoLuminosity/LumiProducer (reconstruction)
• RecoMuon/DetLayers (reconstruction)
• RecoMuon/MuonIdentification (reconstruction)
• RecoMuon/TransientTrackingRecHit (reconstruction)
• RecoParticleFlow/PFRecHitProducer (reconstruction)
• RecoTracker/GeometryESProducer (reconstruction)
• RecoTracker/TkNavigation (reconstruction)
• SimCalorimetry/EcalTrigPrimProducers (l1)
• TopQuarkAnalysis/TopTools (analysis)
• TrackingTools/GsfTools (reconstruction)
• TrackingTools/GsfTracking (reconstruction)
• TrackingTools/KalmanUpdators (reconstruction)
• TrackingTools/MaterialEffects (reconstruction)
• TrackingTools/TransientTrack (reconstruction)
• Validation/HLTrigger (dqm)
• Validation/HcalHits (dqm)

@jfernan2, @consuegs, @epalencia, @saumyaphor4252, @rvenditti, @hqucms, @Martin-Grunewald, @smorovic, @mmusich, @civanch, @smuzaffar, @antoniovagnerini, @bsunanda, @mkirsano, @srimanob, @mandrenguyen, @syuvivida, @menglu21, @bbilin, @alberto-sanchez, @vlimant, @SiewYan, @tvami, @mdhildreth, @makortel, @aloeliger, @francescobrivio, @emeschi, @subirsarkar, @nothingface0, @Dr15Jones, @cmsbuild, @GurpreetSinghChahal, @tjavaid, @perrotta can you please review it and eventually sign? Thanks.
@fabiocos, @lgray, @alesaggio, @dgulhan, @Ming-Yan, @bsunanda, @JyothsnaKomaragiri, @andrzejnovak, @jazzitup, @Fedespring, @mmarionncern, @namapane, @fwyzard, @wang0jin, @abbiendi, @rociovilar, @emilbols, @schoef, @JanFSchulte, @hatakeyamak, @HuguesBrun, @mtosi, @ram1123, @yetkinyilmaz, @sobhatta, @rsreds, @CeliaFernandez, @a-kapoor, @GiacomoSguazzoni, @vargasa, @tocheng, @andrea21z, @gouskos, @afiqaize, @Martin-Grunewald, @clelange, @Prasant1993, @valsdav, @mkirsano, @silviodonato, @mariadalfonso, @apsallid, @PonIlya, @alberto-sanchez, @AlexDeMoor, @nhanvtran, @missirol, @echabert, @youyingli, @cericeci, @jdolen, @ahinzmann, @kurtejung, @slomeo, @gkasieczka, @demuller, @threus, @robervalwalsh, @trocino, @sroychow, @thomreis, @mandrenguyen, @jdamgov, @battibass, @makortel, @felicepantaleo, @jlidrych, @yuanchao, @VourMa, @abdoulline, @gbenelli, @yslai, @jhgoh, @gpetruc, @sameasy, @AnnikaStein, @VinInn, @mmusich, @jainshilpi, @yenjie, @varuns23, @idebruyn, @venturia, @Sam-Harper, @barvic, @arossi83, @jandrea, @seemasharmafnal, @bellan, @fioriNTU, @wddgit, @argiro, @Senphy, @rovere, @ReyerBand, @rchatter, @rappoccio this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[perrotta]

-alca

• Keep this out of our radars if it is intended "just to see what it would break"

[perrotta]

-db

• Keep this out of our radars if it is intended "just to see what it would break"

[tvami]

-analysis

• should the PR just be closed?

[mmusich]

should the PR just be closed?

not yet.

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.