-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROOTMaster] Fix include for RNTuple* (redo of #44256) #44328
Conversation
cms-bot internal usage |
hold |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44328/39356
|
Pull request has been put on hold by @iarspider |
A new Pull Request was created by @iarspider for master. It involves the following packages:
@vlimant, @hqucms, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44328/39414
|
unhold |
please test |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67ae33/38059/summary.html Comparison SummarySummary:
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67ae33/38053/summary.html Comparison SummarySummary:
|
@cms-sw/alca-l2 @cms-sw/xpog-l2 can you please review this? This is needed for ROOT master updates which are pending for over a month now |
there has been multiple back and forth on this, I hope we can settle on a smoother integration not requiring to sign a million PR instead of one |
+1 |
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
REMINDER @antoniovilela, @rappoccio, @sextonkennedy: This PR was tested with cms-sw/cmsdist#9056, please check if they should be merged together |
+1 |
PR description:
Redo #44256
PR validation:
Bot tests in cms-sw/cmsdist#9047