Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOTMaster] Fix include for RNTuple* (redo of #44256) #44328

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

iarspider
Copy link
Contributor

@iarspider iarspider commented Mar 6, 2024

PR description:

Redo #44256

PR validation:

Bot tests in cms-sw/cmsdist#9047

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

cms-bot internal usage

@iarspider
Copy link
Contributor Author

hold
Should only be merged together with ROOTmaster update - see linked cmsdist PR

@cmsbuild cmsbuild added the hold label Mar 6, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44328/39356

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

Pull request has been put on hold by @iarspider
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@vlimant, @hqucms, @cmsbuild can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44328/39414

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #44328 was updated. @consuegs, @perrotta, @hqucms, @vlimant, @cmsbuild, @saumyaphor4252 can you please check and sign again.

@iarspider
Copy link
Contributor Author

unhold

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #44328 was updated. @hqucms, @saumyaphor4252, @perrotta, @consuegs, @vlimant can you please check and sign again.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67ae33/38059/summary.html
COMMIT: dc416f2
CMSSW: CMSSW_14_1_X_2024-03-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44328/38059/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67ae33/38053/summary.html
COMMIT: dc416f2
CMSSW: CMSSW_14_1_ROOT6_X_2024-03-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44328/38053/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor

@cms-sw/alca-l2 @cms-sw/xpog-l2 can you please review this? This is needed for ROOT master updates which are pending for over a month now

@vlimant
Copy link
Contributor

vlimant commented Mar 13, 2024

there has been multiple back and forth on this, I hope we can settle on a smoother integration not requiring to sign a million PR instead of one

@vlimant
Copy link
Contributor

vlimant commented Mar 13, 2024

+1

@perrotta
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

REMINDER @antoniovilela, @rappoccio, @sextonkennedy: This PR was tested with cms-sw/cmsdist#9056, please check if they should be merged together

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants