Generated cfi files can now use new module syntax #44363

Dr15Jones · 2024-03-10T22:25:44Z

PR description:

new syntax used if there is an unambiguous default description.
possibly ambiguous parts of a default description require explicit types to be used.

PR validation:

Framework code and framework unit tests pass.

cmsbuild · 2024-03-10T22:26:09Z

cms-bot internal usage

cmsbuild · 2024-03-10T22:32:26Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44363/39410

This PR adds an extra 132KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44363/39410/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44363/39410/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

Dr15Jones · 2024-03-10T22:40:11Z

please test

cmsbuild · 2024-03-10T22:46:19Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44363/39411

This PR adds an extra 132KB to repository

cmsbuild · 2024-03-10T22:46:46Z

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

FWCore/Integration (core)
FWCore/ParameterSet (core)

@smuzaffar, @makortel, @Dr15Jones can you please review it and eventually sign? Thanks.
@missirol, @makortel, @wddgit this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2024-03-11T10:07:35Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46ecc9/38026/summary.html
COMMIT: daf4f67
CMSSW: CMSSW_14_1_X_2024-03-10-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44363/38026/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 19191 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 1
DQMHistoTests: Total histograms compared: 0
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 0
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
Checked 66 log files, 0 edm output root files, 1 DQM output files

FWCore/Integration/plugins/ProducerWithPSetDesc.cc

FWCore/Integration/test/cfi_dumpPython.py

FWCore/ParameterSet/interface/ParameterDescriptionNode.h

FWCore/ParameterSet/interface/ParameterSwitch.h

FWCore/ParameterSet/src/ParameterDescription.cc

FWCore/ParameterSet/interface/ParameterDescriptionNode.h

FWCore/ParameterSet/interface/PluginDescription.h

FWCore/ParameterSet/interface/ParameterDescriptionNode.h

Dr15Jones · 2024-05-14T13:50:59Z

please test

cmsbuild · 2024-05-14T13:56:19Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44363/40252

This PR adds an extra 136KB to repository

cmsbuild · 2024-05-14T13:56:48Z

Pull request #44363 was updated. @makortel, @Dr15Jones, @smuzaffar can you please check and sign again.

cmsbuild · 2024-05-14T19:50:33Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46ecc9/39376/summary.html
COMMIT: 0ce7374
CMSSW: CMSSW_14_1_X_2024-05-13-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44363/39376/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

4.764.76_ZMuSkim2012D/step2_ZMuSkim2012D.log

Comparison Summary

Summary:

You potentially added 5 lines to the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3339016
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3338996
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

Dr15Jones · 2024-05-14T20:28:12Z

The failure was unrelated to this PR and stemmed from a remote file failing to be opened:

----- Begin Fatal Exception 14-May-2024 19:21:25 CEST-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/data/Run2012D/SingleMu/RAW-RECO/ZMu-15Apr2014-v1/00000/0C402854-EECC-E311-AE34-E0CB4E553656.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://cms-xrd-global.cern.ch//eos/cms/store/data/Run2012D/SingleMu/RAW-RECO/ZMu-15Apr2014-v1/00000/0C402854-EECC-E311-AE34-E0CB4E553656.root
      [b] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/data/Run2012D/SingleMu/RAW-RECO/ZMu-15Apr2014-v1/00000/0C402854-EECC-E311-AE34-E0CB4E553656.root
      [c] Input file root://xrootd-cms.infn.it//store/data/Run2012D/SingleMu/RAW-RECO/ZMu-15Apr2014-v1/00000/0C402854-EECC-E311-AE34-E0CB4E553656.root could not be opened.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/data/Run2012D/SingleMu/RAW-RECO/ZMu-15Apr2014-v1/00000/0C402854-EECC-E311-AE34-E0CB4E553656.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.
' (errno=3011, code=400). No additional data servers were found.
      [e] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/data/Run2012D/SingleMu/RAW-RECO/ZMu-15Apr2014-v1/00000/0C402854-EECC-E311-AE34-E0CB4E553656.root?tried=+1213xrootd-cms-redir-int.cr.cnaf.infn.it,&xrdcl.requuid=fad12701-c22c-46f6-a8b6-5800a47b3419
      [f] Problematic data server: cms-xrd-global.cern.ch:1094
      [g] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

makortel · 2024-05-16T21:40:13Z

+core

cmsbuild · 2024-05-16T21:40:43Z

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2024-05-20T14:32:27Z

please test

Trying again, seems transient.

cmsbuild · 2024-05-20T20:36:59Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46ecc9/39434/summary.html
COMMIT: 0ce7374
CMSSW: CMSSW_14_1_X_2024-05-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44363/39434/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 10 lines to the logs
Reco comparison results: 13 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3338976
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3338944
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

rappoccio · 2024-05-22T15:37:01Z

+1

cmsbuild added this to the CMSSW_14_1_X milestone Mar 10, 2024

cmsbuild added core-pending pending-signatures tests-pending orp-pending code-checks-pending labels Mar 10, 2024

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 10, 2024

Dr15Jones force-pushed the cfiChange branch from b65e931 to daf4f67 Compare March 10, 2024 22:39

cmsbuild added code-checks-pending and removed code-checks-rejected labels Mar 10, 2024

cmsbuild added tests-started and removed tests-pending labels Mar 10, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 10, 2024

cmsbuild added tests-approved and removed tests-started labels Mar 11, 2024

cmsbuild mentioned this pull request Mar 11, 2024

[RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

Open

makortel mentioned this pull request Mar 14, 2024

Generated cfi files can now use new module syntax cms-sw/framework-team#848

Closed

Dr15Jones commented Mar 14, 2024

View reviewed changes

This was referenced Mar 18, 2024

Added python type annotation to some configuration classes #44453

Merged

new Prompt Lepton ID MVA (and renaming) #44503

Merged

makortel reviewed Mar 28, 2024

View reviewed changes

Dr15Jones force-pushed the cfiChange branch from daf4f67 to d83dd6f Compare April 4, 2024 19:50

cmsbuild added the code-checks-pending label May 14, 2024

cmsbuild added tests-started and removed tests-pending labels May 14, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels May 14, 2024

cmsbuild added tests-rejected and removed tests-started labels May 14, 2024

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels May 16, 2024

cmsbuild added tests-started and removed tests-rejected labels May 20, 2024

cmsbuild added tests-approved and removed tests-started labels May 20, 2024

cmsbuild added orp-approved and removed orp-pending labels May 22, 2024

cmsbuild merged commit 356b35d into cms-sw:master May 22, 2024
11 checks passed

mmusich mentioned this pull request May 29, 2024

cfipython file changes in 14_1_0_pre4 (compared to pre3) lead to failures in ConfDb parsing #45087

Closed

Dr15Jones deleted the cfiChange branch May 30, 2024 14:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generated cfi files can now use new module syntax #44363

Generated cfi files can now use new module syntax #44363

Dr15Jones commented Mar 10, 2024

cmsbuild commented Mar 10, 2024 •

edited

Loading

cmsbuild commented Mar 10, 2024

Dr15Jones commented Mar 10, 2024

cmsbuild commented Mar 10, 2024

cmsbuild commented Mar 10, 2024

cmsbuild commented Mar 11, 2024

Dr15Jones commented May 14, 2024

cmsbuild commented May 14, 2024

cmsbuild commented May 14, 2024

cmsbuild commented May 14, 2024

Dr15Jones commented May 14, 2024

makortel commented May 16, 2024

cmsbuild commented May 16, 2024

rappoccio commented May 20, 2024

cmsbuild commented May 20, 2024

rappoccio commented May 22, 2024

Generated cfi files can now use new module syntax #44363

Generated cfi files can now use new module syntax #44363

Conversation

Dr15Jones commented Mar 10, 2024

PR description:

PR validation:

cmsbuild commented Mar 10, 2024 • edited Loading

cmsbuild commented Mar 10, 2024

Dr15Jones commented Mar 10, 2024

cmsbuild commented Mar 10, 2024

cmsbuild commented Mar 10, 2024

cmsbuild commented Mar 11, 2024

Comparison Summary

Dr15Jones commented May 14, 2024

cmsbuild commented May 14, 2024

cmsbuild commented May 14, 2024

cmsbuild commented May 14, 2024

RelVals-INPUT

Comparison Summary

Dr15Jones commented May 14, 2024

makortel commented May 16, 2024

cmsbuild commented May 16, 2024

rappoccio commented May 20, 2024

cmsbuild commented May 20, 2024

Comparison Summary

rappoccio commented May 22, 2024

cmsbuild commented Mar 10, 2024 •

edited

Loading