Replace usleep with std::this_thread::sleep_for #46143

Dr15Jones · 2024-09-27T20:41:38Z

PR description:

POSIX has deprecated the use of usleep

This was pointed out by the 'flaw finder' on the IB page.

PR validation:

code compiles.

Dr15Jones · 2024-09-27T20:41:47Z

please test

cmsbuild · 2024-09-27T20:42:03Z

cms-bot internal usage

cmsbuild · 2024-09-27T20:44:46Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46143/41937

There are other open Pull requests which might conflict with changes you have proposed:
- File FWCore/Framework/test/stubs/ToyIntProducers.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File FWCore/Integration/plugins/AcquireIntESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File FWCore/Modules/src/TimeStudyModules.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

cmsbuild · 2024-09-27T20:45:12Z

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

FWCore/Concurrency (core)
FWCore/Framework (core)
FWCore/Integration (core)
FWCore/Modules (core)
FWCore/Sources (core)
IOMC/RandomEngine (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

makortel · 2024-09-27T20:57:32Z

FWCore/Concurrency/README.md

@@ -170,7 +170,7 @@ Example: protecting `std::cout` so printouts do not intertwine.
  oneapi::tbb::task_group group;
  for(int i=0; i<3; ++i) {
    group.run([&queue, &group] {
-      usleep(1000);
+      std::this_thread::sleep_for(1000);


Could you add a unit of time for this example?

POSIX has deprecated the use of usleep

cmsbuild · 2024-09-27T21:05:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46143/41938

There are other open Pull requests which might conflict with changes you have proposed:
- File FWCore/Framework/test/stubs/ToyIntProducers.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File FWCore/Integration/plugins/AcquireIntESProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File FWCore/Modules/src/TimeStudyModules.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

cmsbuild · 2024-09-27T21:05:10Z

Pull request #46143 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

Dr15Jones · 2024-09-30T14:05:07Z

please test

cmsbuild · 2024-09-30T17:45:47Z

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-247edf/41815/summary.html
COMMIT: 5437d35
CMSSW: CMSSW_14_2_X_2024-09-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46143/41815/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

2022.1000012022.100001_RunJetHT2022C_10k/step1_dasquery.log
2023.0000012023.000001_RunMuonEG2023C_10k/step1_dasquery.log
2023.0010012023.001001_RunDisplacedJet2023C_10k/step1_dasquery.log

Expand to see more relval errors ...

2023.100001
2022.100001
2023.000001
2023.001001
2023.100001

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 107 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3331342
DQMHistoTests: Total failures: 3274
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3328048
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 193 log files, 163 edm output root files, 44 DQM output files
TriggerResults: no differences found

Dr15Jones · 2024-09-30T17:48:38Z

failures due to das query failures. Not caused by this PR.

makortel · 2024-09-30T17:50:48Z

Comparison differences are related to #39803

makortel · 2024-09-30T17:51:09Z

+core

cmsbuild · 2024-09-30T17:51:13Z

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

makortel · 2024-09-30T17:51:20Z

ignore tests-rejected with external-failure

mandrenguyen · 2024-10-02T04:51:58Z

+1

cmsbuild added this to the CMSSW_14_2_X milestone Sep 27, 2024

cmsbuild added core-pending pending-signatures orp-pending tests-started code-checks-pending labels Sep 27, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 27, 2024

makortel reviewed Sep 27, 2024

View reviewed changes

makortel mentioned this pull request Sep 27, 2024

Replace usleep with std::this_thread::sleep_for cms-sw/framework-team#1046

Closed

Replace usleep with std::this_thread::sleep_for

5437d35

POSIX has deprecated the use of usleep

Dr15Jones force-pushed the usleepReplace branch from d4f7fc6 to 5437d35 Compare September 27, 2024 21:03

cmsbuild added tests-pending code-checks-pending and removed tests-started code-checks-approved labels Sep 27, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 27, 2024

cmsbuild added tests-started and removed tests-pending labels Sep 30, 2024

cmsbuild added tests-rejected and removed tests-started labels Sep 30, 2024

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Sep 30, 2024

cmsbuild added tests-approved tests-external-failure and removed tests-rejected labels Sep 30, 2024

cmsbuild added orp-approved and removed orp-pending labels Oct 2, 2024

cmsbuild merged commit cbe2a3e into cms-sw:master Oct 2, 2024
10 of 11 checks passed

This was referenced Oct 2, 2024

Fixes after root-project/root#16443 #46195

Merged

[ROOTMaster] Updated root to tip of branch master cms-sw/cmsdist#9441

Merged

Dr15Jones deleted the usleepReplace branch October 8, 2024 17:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace usleep with std::this_thread::sleep_for #46143

Replace usleep with std::this_thread::sleep_for #46143

Dr15Jones commented Sep 27, 2024

Dr15Jones commented Sep 27, 2024

cmsbuild commented Sep 27, 2024 •

edited

Loading

cmsbuild commented Sep 27, 2024

cmsbuild commented Sep 27, 2024

makortel Sep 27, 2024

Dr15Jones Sep 27, 2024

cmsbuild commented Sep 27, 2024

cmsbuild commented Sep 27, 2024

Dr15Jones commented Sep 30, 2024

cmsbuild commented Sep 30, 2024

Dr15Jones commented Sep 30, 2024

makortel commented Sep 30, 2024

makortel commented Sep 30, 2024

cmsbuild commented Sep 30, 2024

makortel commented Sep 30, 2024

mandrenguyen commented Oct 2, 2024

Replace usleep with std::this_thread::sleep_for #46143

Replace usleep with std::this_thread::sleep_for #46143

Conversation

Dr15Jones commented Sep 27, 2024

PR description:

PR validation:

Dr15Jones commented Sep 27, 2024

cmsbuild commented Sep 27, 2024 • edited Loading

cmsbuild commented Sep 27, 2024

cmsbuild commented Sep 27, 2024

makortel Sep 27, 2024

Choose a reason for hiding this comment

Dr15Jones Sep 27, 2024

Choose a reason for hiding this comment

cmsbuild commented Sep 27, 2024

cmsbuild commented Sep 27, 2024

Dr15Jones commented Sep 30, 2024

cmsbuild commented Sep 30, 2024

RelVals-INPUT

Comparison Summary

Dr15Jones commented Sep 30, 2024

makortel commented Sep 30, 2024

makortel commented Sep 30, 2024

cmsbuild commented Sep 30, 2024

makortel commented Sep 30, 2024

mandrenguyen commented Oct 2, 2024

cmsbuild commented Sep 27, 2024 •

edited

Loading