Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo: fixes testPrintTkMaps unit test #46631

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Nov 8, 2024

This PR fixes a typo which went in via #46561. Without this PR tests fail when cmssw is build in full mode e.g. cms-sw/cmsdist#9509 (comment)

I have tested this change locally and now it properly read the local data file if available otherwise fall back to release area data file

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2024

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • DQM/TrackerRemapper (dqm)

@antoniovagnerini, @rseidita can you please review it and eventually sign? Thanks.
@fioriNTU, @idebruyn, @jandrea, @mmusich, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a1844c/42675/summary.html
COMMIT: 992c338
CMSSW: CMSSW_14_2_X_2024-11-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46631/42675/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor

mmusich commented Nov 8, 2024

type bug-fix

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 17c619c into cms-sw:master Nov 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants