Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the use of hls external from Calibration/HcalAlCaRecoProducers as unnecessary #46619

Merged

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Nov 6, 2024

PR description:

Came up while looking what packages use hls.

Resolves cms-sw/framework-team#1077

PR validation:

Code compiles

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2024

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • Calibration/HcalAlCaRecoProducers (alca)

@atpathak, @cmsbuild, @consuegs, @perrotta can you please review it and eventually sign? Thanks.
@bsunanda, @mmusich, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Nov 6, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6638db/42632/summary.html
COMMIT: ce559c6
CMSSW: CMSSW_14_2_X_2024-11-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46619/42632/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3343138
  • DQMHistoTests: Total failures: 397
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3342721
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 195 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Nov 7, 2024

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9a63b97 into cms-sw:master Nov 8, 2024
11 checks passed
@makortel makortel deleted the cleanupCalibrationHcalAlCaRecoProducers branch November 8, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the use of hls external from Calibration/HcalAlCaRecoProducers as unnecessary
4 participants