Add fillDescriptions to modules used in cosmics HLT reco

[mmusich]

PR description:

When deep-importing a new path in confDB I noticed the following recurring warning messages:

Modules (4):
  -> hltCombinatorialcosmicseedfinderP5 [CtfSpecialSeedGenerator] CHANGED
       PSet UpperScintillatorParameters [REMOVED]
       PSet LowerScintillatorParameters [REMOVED]
       untracked uint32 DontCountDetsAboveNClusters = 20 [REMOVED]
  -> hltCombinedP5SeedsForCTF [SeedCombiner] CHANGED
       untracked InputTag PairCollection = hltCombinatorialcosmicseedfinderP5 [REMOVED]
       untracked InputTag TripletCollection = hltSimpleCosmicBONSeeds [REMOVED]

Upon inspection of the modules, I gathered that most of these are incorrect, in the sense that the confDB parsing is expecting some parameters that either of the wrong type or are not needed.
To fix the issue I propose to:

• introduce a fillDescriptions method for CtfSpecialSeedGenerator and introduce a customization for the wrong parameters in the HLT menu.
• introduce a fillDescriptions method for SeedCombiner, clean up configuration in RecoTrackerP5_cff and customize HLT menu

PR validation:

Run successfully with this branch:

• runTheMatrix.py -l 7.3 (cosmics reco)
• addOnTests.py

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46647/42564

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)
• RecoTracker/Configuration (reconstruction)
• RecoTracker/SpecialSeedGenerators (reconstruction)
• RecoTracker/TkSeedGenerator (reconstruction)

@Martin-Grunewald, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @missirol, @mmusich, @mtosi, @rovere, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

type bug-fix, hlt-integration

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5003be/42708/summary.html
COMMIT: ab12932
CMSSW: CMSSW_14_2_X_2024-11-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46647/42708/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 11 differences found in the comparisons
• DQMHistoTests: Total files compared: 47
• DQMHistoTests: Total histograms compared: 3450336
• DQMHistoTests: Total failures: 433
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3449883
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
• Checked 206 log files, 177 edm output root files, 47 DQM output files
• TriggerResults: no differences found

[mmusich]

+hlt

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1

[Martin-Grunewald]

This for loop is inside the for loop from above, is this really the intention?

[mmusich]

no.