Run3hcx378A Provide a way to avoid Digitization for the ZDC detector #46570
Conversation
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46570/42460 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46570/42461 |
|
A new Pull Request was created by @bsunanda for master. It involves the following packages:
@antoniovilela, @civanch, @cmsbuild, @davidlange6, @fabiocos, @kpedro88, @mandrenguyen, @mdhildreth, @rappoccio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild Please test |
|
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
|
|
@civanch Please approve this. It is required by the ZDC people |
|
+1 |
|
@antoniovilela, @mandrenguyen Please approve this PR |
|
+1 |
cmsbuild
added
operations-approved
fully-signed
orp-approved
and removed
operations-pending
pending-signatures
orp-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
There was a problem hiding this comment.
@bsunanda @hjbossi I'm noticing this PR only now. Besides these minor fixes, which are needed (also for a possible backport PR): is this modifier also expected to be used to switch off ZDC digitization also in Phase2 workflows? See for example the comment in #46537 (comment)
| @@ -64,3 +65,7 @@ | |||
| # remove HE processing for phase 2, completely put in HGCal land | |||
| from Configuration.Eras.Modifier_phase2_hgcal_cff import phase2_hgcal | |||
| phase2_hgcal.toModify(hcalSimBlock, killHE = cms.bool(True) ) | |||
|
|
|||
| # remove HE processing for phase 2, completely put in HGCal land | |||
There was a problem hiding this comment.
This comment does not refer to the current case
| @@ -30,7 +30,7 @@ | |||
| #include <boost/foreach.hpp> | |||
| #include <memory> | |||
|
|
|||
| //#define EDM_ML_DEBUG | |||
| #define EDM_ML_DEBUG | |||
There was a problem hiding this comment.
This should be commented back
There was a problem hiding this comment.
There is #46708 with the fix.
PR description:
Provide a way to avoid Digitization for the ZDC detector
PR validation:
By using the following lines in the step2 of the workflow of 12834.0, the digitization of ZDC was switched off:
from Configuration.Eras.Era_Run3_2024_cff import Run3_2024
from Configuration.Eras.Modifier_zdcNoDigi_cff import zdcNoDigi
process = cms.Process('HLT',Run3_2024,zdcNoDigi)
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special