Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the time resoultion of GEM Digitization #46653

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

woohyeonHeo
Copy link
Contributor

@woohyeonHeo woohyeonHeo commented Nov 11, 2024

PR description:

Update on GEM Digitization simulation

PR validation:

  • The code format has applied with scram build code-format and tested with scram build code-checks
  • The branch has tested with the following command
runTheMatrix.py -w upgrade -l 3211.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 11, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gjdngus9809 for master.

It involves the following packages:

  • SimMuon/GEMDigitizer (upgrade, simulation)

@Moanwar, @civanch, @cmsbuild, @kpedro88, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@giovanni-mocellin, @jhgoh, @jshlee, @slomeo, @watson-ij this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@woohyeonHeo
Copy link
Contributor Author

@watson-ij

@watson-ij
Copy link
Contributor

please test

@woohyeonHeo woohyeonHeo changed the title From cmssw 14 2 x 2024 11 10 0000 Update the time resoultion of GEM Digitization Nov 11, 2024
@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a973b5/42718/summary.html
COMMIT: 5e36a3f
CMSSW: CMSSW_14_2_X_2024-11-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46653/42718/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a973b5/42718/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a973b5/42718/git-merge-result

Comparison Summary

Summary:

@civanch
Copy link
Contributor

civanch commented Nov 12, 2024

+1

@Moanwar
Copy link
Contributor

Moanwar commented Nov 12, 2024

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2af458b into cms-sw:master Nov 13, 2024
11 checks passed
@woohyeonHeo woohyeonHeo deleted the from-CMSSW_14_2_X_2024-11-10-0000 branch November 14, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants