TICL: protect from empty seeding region

[felicepantaleo]

This PR fixes #46527

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46651/42571

[cmsbuild]

A new Pull Request was created by @felicepantaleo for master.

It involves the following packages:

• RecoHGCal/TICL (reconstruction, upgrade)

@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@apsallid, @forthommel, @hatakeyamak, @lecriste, @missirol, @rovere, @sameasy, @sobhatta, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[felicepantaleo]

type bug-fix

[felicepantaleo]

type hgcal

[felicepantaleo]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: RelVals
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-027805/42714/summary.html
COMMIT: 3588b75
CMSSW: CMSSW_14_2_X_2024-11-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46651/42714/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 2023.0020012023.002001_RunZeroBias2023D_10k/step1_dasquery.log
• 2023.002001``````
• 2024.0000012024.000001_RunZeroBias2024B_10k/step1_dasquery.log

Expand to see more relval errors ...

• 2024.000001
• 29696.0
• 29700.0
• 29634.0
• 29834.999
• 24834.911
• 29634.911
• 2023.002001
• 2024.000001

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46651/42579

[felicepantaleo]

@cmsbuild please test

[cmsbuild]

Pull request #46651 was updated. @Moanwar, @jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please check and sign again.

[felicepantaleo]

@cmsbuild ignore tests-rejected with ib-failure

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-027805/42724/summary.html
COMMIT: 5032d9e
CMSSW: CMSSW_14_2_X_2024-11-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46651/42724/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3343588
• DQMHistoTests: Total failures: 418
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3343150
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[Moanwar]

+Upgrade

[jfernan2]

solves #46527

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

please test workflow 32034.0 for CMSSW_14_2_UBSAN_X

lets test it for UBSAN to see if the src/RecoHGCal/TICL/plugins/PatternRecognitionbyCA.cc:226:86: runtime error: member access within null pointer of type 'const struct value_type' error is fixed

[mandrenguyen]

+1

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-027805/42799/summary.html
COMMIT: 5032d9e
CMSSW: CMSSW_14_2_UBSAN_X_2024-11-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46651/42799/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 32034.0A fatal system signal has occurred: segmentation violation