Apply suggested fix for Wdangling-reference

[iarspider]

PR description:

As suggested by @makortel here: https://github.com/cms-sw/cmssw/pull/45735/files/917d36f1e24533647eaff38bcf4400794d7fac13#r1723513370 I changed the way Wdangling-reference warnings are fixed.

PR validation:

Bot tests

[iarspider]

please test for el9_amd64_gcc13

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45765/41476

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• CalibTracker/SiStripCommon (alca)
• RecoLocalCalo/HcalRecAlgos (reconstruction)

@consuegs, @jfernan2, @mandrenguyen, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@ReyerBand, @abdoulline, @apsallid, @argiro, @bsunanda, @echabert, @gbenelli, @mariadalfonso, @missirol, @mmusich, @rchatter, @robervalwalsh, @rsreds, @thomreis, @tocheng, @wang0jin, @youyingli, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae718d/41051/summary.html
COMMIT: a8d271a
CMSSW: CMSSW_14_1_X_2024-08-16-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45765/41051/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @lecriste Parametrized magnetic field in alpaka #44360
• @AdrianoDee 2024 Data RelVals and InputInfo Events Skimming (actually) Working #45055
• @tcuisset TICLv5 : Superclustering DNN #45333
• @srimanob Clean up Phase-2 Geometry D86, D88, D91, D92, D93, D94, D97 #45370
• @denizsun HCAL DQM Online Histogram for Bad Quality Events #45571
• @y19y19 Particle Transformer sonic producer #45579
• @archiron Validation/RecoEgamma Phase2 vertex_pt correction #45590
• @mmusich add hlt (HLT) label to Phase-2 HLT modules (sequences) #45636
• @Dr15Jones Removed unnecessary xz dependency from GeneratorProducts #45657
• @stahlleiton Add Phase2 PbPb reco process modifier #45683
• @iarspider Disable testTorchSimpleDnn for non-amd64 architectures #45688
• @AdrianoDee Use BS from GT for 2022, 2023 and 2024 HI wfs #45695
• @smuzaffar use eigen3 header instead of tf third_party/eigen3 #45701
• @tvami Remove TestBPHSpecificDecay test #45709
• @AdrianoDee Having Upgrade Matrix Failing for Duplicate Suffixes #45715
• @bsunanda Run3-gem70X Update the new geometry file for 2024 GE21 #45716
• @Dr15Jones Avoid copying array in TracksterLinkingbySkeletons #45717
• @bsunanda Phase2-hgx359N Correct the conversion code for fine scintillator tiles of HGCal V19 geometry in the assignment of cassette number #45724
• @bsunanda Run3-gex180X Modify the 2024 scenarios for the corrected positions of the GE21 detectors #45725
• @iarspider [GCC13][AlCa] Avoid storing reference to a temporary object #45728
• @iarspider [GCC13] Avoid Wdangling-reference warning in CaloTPGTranscoderULUTs #45729
• @iarspider [GCC13] Avoid Wdangling-reference warning in HcalTPGCoderULUT.cc #45731
• @iarspider [GCC13] Avoid Wdangling-reference warning in CalibTracker submodules #45732
• @iarspider [GCC13] Avoid Wdangling-reference in GenericTriggerEventFlag #45733
• @iarspider [GCC13] Avoid Wdangling-reference in HcalChannelPropertiesEP #45735
• @mmusich Fix for L1TMuonGlobalParams_PayloadInspector #45738
• @cmsbuild Fix overloaded-virtual warnings in RecoBTag and RecoVertex #45741
• @mmusich initialise phiBinner in device-to-host copy of TrackingRecHitsSoACollection<TrackerTraits> #45743

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae718d/41051/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae718d/41051/git-merge-result

Unit Tests

I found 3 errors in the following unit tests:

---> test testPhase2PixelNtuple had ERRORS
---> test testPhase2SkimmedGeometry had ERRORS
---> test PrimaryVertex had ERRORS

Comparison Summary

Summary:

• You potentially removed 56 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 58691 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3319664
• DQMHistoTests: Total failures: 318625
• DQMHistoTests: Total nulls: 323
• DQMHistoTests: Total successes: 3000696
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 51.513999999999996 KiB( 43 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.544 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 10224.0,... ): 0.520 KiB EgammaV/ElectronMcSignalValidatorMiniAOD
• DQMHistoSizes: changed ( 10224.0,... ): 0.518 KiB EgammaV/ElectronMcSignalValidatorPt1000
• DQMHistoSizes: changed ( 10224.0,... ): 0.506 KiB EgammaV/ElectronMcSignalValidator
• DQMHistoSizes: changed ( 13034.0 ): 2.776 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 140.043 ): -0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 24834.911,... ): 1.371 KiB HLT/Vertexing
• DQMHistoSizes: changed ( 24834.911,... ): 0.867 KiB EgammaV/ElectronMcSignalValidatorMiniAOD
• DQMHistoSizes: changed ( 24834.911,... ): -0.326 KiB HLT/Tracking
• DQMHistoSizes: changed ( 250202.181 ): 0.234 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): ...
• Checked 191 log files, 161 edm output root files, 44 DQM output files

[iarspider]

@cmsbuild ignore tests-rejected with ib-failure
Missing geometry files are due to #45370

[mmusich]

Missing geometry files are due to #45370

#45764 should fix a bunch of them.

[perrotta]

+alca

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1