HCAL DQM Online Histogram for Bad Quality Events

[denizsun]

PR description:

• We have added a histogram to Online HCAL DQM by implementing the required changes in the CMSSW_14_1_0_pre3 [1] release.

• We set up the GUI on the dqmfu-c2b02-46-01 machine by following the instructions provided in [0].
  [0]: https://github.com/cms-DQM/dqmgui_prod_deployment/wiki/Deployment-at-Point-5
  [1]: https://github.com/cms-sw/cmssw/blob/master/DQM/HcalTasks/plugins/RawTask.cc

• A new histogram will be appeared in 00_Shift/Errors

• There is a gitlab issue https://gitlab.cern.ch/cmshcal/docs/-/issues/233.

PR validation:

• All the PR validation checks and the runTheMatrix test are done.

• This PR is not a back port.

• All points of checklist is done.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45571/41067

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DQM/HcalTasks/data/HcalQualityTests.xml modified in PR(s): A new Online HCAL DQM histogram for bad quality events  #45527
  • File DQM/HcalTasks/interface/RawTask.h modified in PR(s): A new Online HCAL DQM histogram for bad quality events  #45527
  • File DQM/HcalTasks/plugins/RawTask.cc modified in PR(s): A new Online HCAL DQM histogram for bad quality events  #45527

[cmsbuild]

A new Pull Request was created by @denizsun for master.

It involves the following packages:

• DQM/HcalTasks (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@DryRun, @abdoulline, @bsunanda this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[tjavaid]

please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25e1c4/40669/summary.html
COMMIT: 45566fd
CMSSW: CMSSW_14_1_X_2024-07-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45571/40669/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3423961
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3423935
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 196 log files, 165 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[tjavaid]

Hi @denizsun , we are testing the PR online at our playback machines. Could you please have a look at the playback GUI plots and opine whether the changes have been well observed? Thanks!

[denizsun]

Hi @tjavaid , I had a look at the GUI plots and looks ok.Thanks!

[nothingface0]

@denizsun Could you provide us with a recent run number (and the lumisection range) which would lead to this alarm going off, so that we can also check the alarm functionality?

[denizsun]

@denizsun Could you provide us with a recent run number (and the lumisection range) which would lead to this alarm going off, so that we can also check the alarm functionality?

@nothingface0 There is a data run #382262. In this run, the problem occurs at the LS changing from 221-224.
There is a run#384187, no problem at all.

[nothingface0]

@denizsun Is there any run more recent than 382262 for triggering the alarm? This one probably won't be available.

[denizsun]

@denizsun Is there any run more recent than 382262 for triggering the alarm? This one probably won't be available.

@nothingface0
The following recent runs have BadQuality Events
Run 384070, LS 100-130
Run 383756, LS 1390-1402
Run 383468, LS 1520-1550

and these shouldn't have trigger BadQulaity events:
Run 383756, LS 150-260
Run 383468, LS 430, 1576, 1839

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45571/41279

[cmsbuild]

Pull request #45571 was updated. @antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

[tjavaid]

please test

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25e1c4/40902/summary.html
COMMIT: 596cca8
CMSSW: CMSSW_14_1_X_2024-08-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45571/40902/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 94 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3422822
• DQMHistoTests: Total failures: 2463
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3420339
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 196 log files, 165 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[tjavaid]

+1

• P5 tests OK. Thanks @nothingface0
• spurious differences seen from unstable WF 12834.7 (open issue spurious differences in outputs of Run-3 wfs *.7 #39803 )
• @denizsun , could you make a backport PR for 14_0_X so that it can be deployed in production ?

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1

[denizsun]

+1

• P5 tests OK. Thanks @nothingface0
• spurious differences seen from unstable WF 12834.7 (open issue spurious differences in outputs of Run-3 wfs *.7 #39803 )
• @denizsun , could you make a backport PR for 14_0_X so that it can be deployed in production ?

@tjavaid could you provide me the instructions for a backport PR?

[nothingface0]

@denizsun we sent you some instructions on how to do it via email :)