Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BS from GT for 2022, 2023 and 2024 HI wfs #45695

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Use BS from GT for 2022, 2023 and 2024 HI wfs #45695

merged 1 commit into from
Aug 17, 2024

Conversation

AdrianoDee
Copy link
Contributor

@AdrianoDee AdrianoDee commented Aug 13, 2024 •
edited
Loading

PR description:

From the combination of:

we should be able to load the BS from the GT also for HI workflows. This PR proposes to do that.

@cms-sw/alca-l2 @francescobrivio @mandrenguyen @stahlleiton

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Aug 13, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 13, 2024 •
edited
Loading

cms-bot internal usage

@AdrianoDee AdrianoDee marked this pull request as ready for review August 13, 2024 15:15
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45695/41283

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@AdrianoDee, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 60KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4cabd/40900/summary.html
COMMIT: 6532005
CMSSW: CMSSW_14_1_X_2024-08-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45695/40900/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4cabd/40900/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4cabd/40900/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 98 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3419884
  • DQMHistoTests: Total failures: 2466
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3417398
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -83.38199999999996 KiB( 44 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): -3.207 KiB RPC/RPCRecHitV
  • Checked 196 log files, 165 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@AdrianoDee
Copy link
Contributor Author

test parameters:

  • workflows=159,160,161

@AdrianoDee AdrianoDee changed the title Use BS from GT for 2022 and 2023 HI wfs Use BS from GT for 2022, 2023 and 2024 HI wfs Aug 14, 2024
@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 60KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4cabd/40917/summary.html
COMMIT: 6532005
CMSSW: CMSSW_14_1_X_2024-08-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45695/40917/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 160.0160.0_HydjetQ_B12_5362GeV_2023_ppReco/step1_HydjetQ_B12_5362GeV_2023_ppReco.log
  • 161.0161.0_HydjetQ_B12_5362GeV_2024/step1_HydjetQ_B12_5362GeV_2024.log

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 60KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4cabd/40922/summary.html
COMMIT: 7b7e4b5
CMSSW: CMSSW_14_1_X_2024-08-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45695/40922/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

mmusich
mmusich reviewed Aug 15, 2024
View reviewed changes
Configuration/PyReleaseValidation/python/relval_steps.py
@@ -36,11 +36,11 @@
step1Up2018HiProdDefaults = merge ([{'--eventcontent':'RAWSIM'},step1Up2018HiDefaults])
# step1 gensim: for 2022 HI prod
step1Up2022HiProdDefaults = merge ([{'--conditions':'auto:phase1_2022_realistic_hi','--era':'Run3_pp_on_PbPb','--beamspot':'Realistic2022PbPbCollision','--eventcontent':'RAWSIM','--geometry':'DB:Extended'},step1Up2018HiDefaults])
step1Up2023HiProdDefaults = merge ([{'--conditions':'auto:phase1_2023_realistic_hi','--era':'Run3_pp_on_PbPb_2023','--beamspot':'Realistic2023PbPbCollision','--eventcontent':'RAWSIM','--geometry':'DB:Extended'},step1Up2018HiDefaults])
step1Up2023HiProdDefaults = merge ([{'--conditions':'auto:phase1_2023_realistic_hi','--era':'Run3_pp_on_PbPb_2023','--beamspot':'DBrealistic','--eventcontent':'RAWSIM','--geometry':'DB:Extended'},step1Up2018HiDefaults])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging from the test results, auto:phase1_2023_realistic_hi (a.k.a.

cmssw/Configuration/AlCa/python/autoCond.py

Line 91 in 1e818e7

'phase1_2023_realistic_hi' : '140X_mcRun3_2023_realistic_HI_v3',

) has a wrong reco beamspot vs sim beamspot pairing:

image

image

@cms-sw/alca-l2 FYI

@perrotta
Copy link
Contributor

Thank you @mmusich for noticing it.
Indeed, phase1_2023_realistic_hi was not updated in autoCond in previous #45346, which only updated the 2024 HI GT. #45704 now fixes it.

@perrotta perrotta mentioned this pull request Aug 15, 2024
Merged
@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio: This PR was tested with #45704, please check if they should be merged together

@AdrianoDee
Copy link
Contributor Author

please test
(#45704 has been included in the latest IB)

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4cabd/40950/summary.html
COMMIT: 7b7e4b5
CMSSW: CMSSW_14_1_X_2024-08-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45695/40950/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3732127
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3732098
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 211 log files, 177 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@AdrianoDee
Copy link
Contributor Author

Thanks to #45704 we went from

image

to

image

so I would say this is ready to go.

@AdrianoDee
Copy link
Contributor Author

+pdmv
2022, 2023, 2024 HI wfs show no differences

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 17369b4 into cms-sw:master Aug 17, 2024
12 checks passed
This was referenced Aug 18, 2024
Merged
Merged
@AdrianoDee AdrianoDee deleted the patch-11 branch September 6, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmusich mmusich mmusich left review comments

Assignees
No one assigned
Labels
code-checks-approved fully-signed orp-approved pdmv-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.
6 participants
@AdrianoDee @cmsbuild @perrotta @srimanob @mandrenguyen @mmusich