Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SimBeamSpotObject record to Run-1/2/3 MC GTs #43197

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Add SimBeamSpotObject record to Run-1/2/3 MC GTs #43197

merged 1 commit into from
Nov 10, 2023

Conversation

francescobrivio
Copy link
Contributor

PR description:

With the agreement of the @cms-sw/alca-l2 conveners, I'm adding the SimBeamSpotObject tags to all Run-1/2/3 MC GTs, following (my own) request in this CMSTalk post.
The CMS talk post contains all the details about the tags and the different scenarios used.

GT differences:

PR validation:

Ran successfully the limited matrix workflows.

Backport:

Not a backport, no backport needed.

@cmsbuild cmsbuild added this to the CMSSW_13_3_X milestone Nov 6, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43197/37516

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2023

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@perrotta, @consuegs, @saumyaphor4252, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos, @Martin-Grunewald, @mmusich, @tocheng, @missirol, @yuanchao, @rsreds this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio francescobrivio mentioned this pull request Nov 6, 2023
Merged
@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@francescobrivio francescobrivio mentioned this pull request Nov 6, 2023
Closed
8 tasks
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ac334/35619/summary.html
COMMIT: dd9b292
CMSSW: CMSSW_13_3_X_2023-11-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43197/35619/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 7 lines from the logs
  • Reco comparison results: 130 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3363010
  • DQMHistoTests: Total failures: 1784
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3361204
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor Author

Differences in 12434.7 are known from #39803

@smuzaffar
Copy link
Contributor

Milestone for this pull request has been moved to CMSSW_14_0_X.Please open a backport if it should also go in to CMSSW_13_3_X.

@smuzaffar smuzaffar modified the milestones: CMSSW_13_3_X, CMSSW_14_0_X Nov 6, 2023
@cmsbuild cmsbuild modified the milestones: CMSSW_14_0_X, CMSSW_13_3_X Nov 6, 2023
@perrotta
Copy link
Contributor

perrotta commented Nov 7, 2023

Thank you @francescobrivio for having provided the SimBeamSpotObject tags to all Run-1/2/3 MC GTs,

For the sake of documentations, these are the tags for the SimBeamSpotObjectsRcd updated by this PR in the different GTs:

run1_design : SimBeamSpot_Realistic8TeVCollisionVtxSmearingParameters_v2_mc
run1_mc :     SimBeamSpot_Realistic8TeVCollisionVtxSmearingParameters_v2_mc
run1_mc_hi :  SimBeamSpot_RealisticHIpPb2013CollisionVtxSmearingParameters_v2_mc
run2_mc_50ns : SimBeamSpot_Realistic50ns13TeVCollisionVtxSmearingParameters_v2_mc
run2_mc_l1stage1 : SimBeamSpot_Realistic50ns13TeVCollisionVtxSmearingParameters_v2_mc
run2_design : SimBeamSpot_GaussVtxSigmaZ4cmSmearingParameters_v2_mc
run2_mc_pre_vfp : SimBeamSpot_Realistic25ns13TeV2016CollisionVtxSmearingParameters_v2_mc
run2_mc :         SimBeamSpot_Realistic25ns13TeV2016CollisionVtxSmearingParameters_v2_mc
run2_mc_cosmics : SimBeamSpot_Realistic25ns13TeV2016CollisionVtxSmearingParameters_v2_mc
run2_mc_hi : SimBeamSpot_RealisticHICollisionFixZ2015VtxSmearingParameters_v2_mc
run2_mc_pa : SimBeamSpot_Realistic8TeVPACollision2016VtxSmearingParameters_v2_mc
phase1_2017_design : SimBeamSpot_GaussVtxSigmaZ4cmSmearingParameters_v2_mc
phase1_2017_realistic : SimBeamSpot_Realistic25ns13TeVEarly2017CollisionVtxSmearingParameters_v2_mc
phase1_2017_cosmics : SimBeamSpot_Realistic25ns13TeVEarly2017CollisionVtxSmearingParameters_v2_mc
phase1_2017_cosmics_peak : SimBeamSpot_Realistic25ns13TeVEarly2017CollisionVtxSmearingParameters_v2_mc
phase1_2018_design : SimBeamSpot_GaussVtxSigmaZ4cmSmearingParameters_v2_mc
phase1_2018_realistic : SimBeamSpot_Realistic25ns13TeVEarly2018CollisionVtxSmearingParameters_v2_mc
phase1_2018_realistic_rd : SimBeamSpot_Realistic25ns13TeVEarly2018CollisionVtxSmearingParameters_v2_mc
phase1_2018_realistic_hi : SimBeamSpot_RealisticPbPbCollision2018VtxSmearingParameters_v2_mc
phase1_2018_realistic_HEfail : SimBeamSpot_Realistic25ns13TeVEarly2018CollisionVtxSmearingParameters_v2_mc
phase1_2018_cosmics : SimBeamSpot_Realistic25ns13TeVEarly2018CollisionVtxSmearingParameters_v2_mc
phase1_2018_cosmics_peak : SimBeamSpot_Realistic25ns13TeVEarly2018CollisionVtxSmearingParameters_v2_mc
phase1_2022_design : SimBeamSpot_GaussVtxSigmaZ4cmSmearingParameters_v2_mc 
phase1_2022_realistic : SimBeamSpot_Realistic25ns13p6TeVEOY2022CollisionVtxSmearingParameters_v2_mc
phase1_2022_realistic_postEE : SimBeamSpot_Realistic25ns13p6TeVEOY2022CollisionVtxSmearingParameters_v2_mc
phase1_2022_cosmics : SimBeamSpot_Realistic25ns13p6TeVEOY2022CollisionVtxSmearingParameters_v2_mc
phase1_2022_cosmics_design : SimBeamSpot_GaussVtxSigmaZ4cmSmearingParameters_v2_mc
phase1_2022_realistic_hi : SimBeamSpot_Realistic2022PbPbCollisionVtxSmearingParameters_v2_mc
phase1_2023_design : SimBeamSpot_GaussVtxSigmaZ4cmSmearingParameters_v2_mc
phase1_2023_realistic : SimBeamSpot_Realistic25ns13p6TeVEarly2023CollisionVtxSmearingParameters_v2_mc
phase1_2023_realistic_postBPix : SimBeamSpot_Realistic25ns13p6TeVEarly2023CollisionVtxSmearingParameters_v2_mc
phase1_2023_cosmics : SimBeamSpot_Realistic25ns13p6TeVEarly2023CollisionVtxSmearingParameters_v2_mc
phase1_2023_cosmics_design : SimBeamSpot_GaussVtxSigmaZ4cmSmearingParameters_v2_mc
phase1_2023_realistic_hi : SimBeamSpot_Realistic2022PbPbCollisionVtxSmearingParameters_v2_mc
phase1_2024_realistic : SimBeamSpot_Realistic25ns13p6TeVEarly2023CollisionVtxSmearingParameters_v2_mc

They look mostly all reasonable to me, but I have a doubt on the very first one in this list: all other "design" GTs use the SimBeamSpot_GaussVtxSigmaZ4cmSmearingParameters_v2_mc tag, while "run1_design" stick on a "realistic" SimBeamSpot tag.

Could you please check?

@mmusich
Copy link
Contributor

mmusich commented Nov 7, 2023 •
edited
Loading

They look mostly all reasonable to me, but I have a doubt on the very first one in this list: all other "design" GTs use the SimBeamSpot_GaussVtxSigmaZ4cmSmearingParameters_v2_mc tag, while "run1_design" stick on a "realistic" SimBeamSpot tag.
Could you please check?

Allow me to chime in, as I was suggesting that here. The reason is rather mundane. There is no python configuration for an ideal Run-1 beamspot in the file https://github.com/cms-sw/cmssw/blob/master/IOMC/EventVertexGenerators/python/VtxSmearedParameters_cfi.py.

In any case as far as I can see from DXR there is no client of the autoCond key run1_design at all, so it's somehow a moot point (actually you might even decide to remove the key from autoCond).

@francescobrivio
Copy link
Contributor Author

francescobrivio commented Nov 7, 2023 •
edited
Loading

Ciao Andrea, thanks for checking!

This choice was made based on how the Run 1 MC matrix relvals are set up currently, i.e. using conditions auto:run1_mc and beamspot Realistic8TeVCollision, and we want to maintain the same configuration.
For example if you take a look at some of them (e.g. 5.1, 9.0, 25.0,...) you'll see that Step 1 is configured as:

  • 5.1:
    cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION:@standardValidation,DQM:@standardDQMFS -n 10 --conditions auto:run1_mc --beamspot Realistic8TeVCollision --datatier GEN-SIM-DIGI-RECO,DQMIO --eventcontent FEVTDEBUGHLT,DQM --fast
  • 9.0:
    cmsDriver.py H200ChargedTaus_Tauola_8TeV_cfi --relval 9000,100 -s GEN,SIM -n 10 --conditions auto:run1_mc --beamspot Realistic8TeVCollision --datatier GEN-SIM --eventcontent RAWSIM
  • 25.0:
    cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --relval 9000,100 -s GEN,SIM -n 10 --conditions auto:run1_mc --beamspot Realistic8TeVCollision --datatier GEN-SIM --eventcontent RAWSIM
  • ...

EDIT: scratch this comment, I got confused between run1 design and realistic 😄

@francescobrivio
Copy link
Contributor Author

@cms-sw/alca-l2 btw this PR has been moved by default to 14_0_X, do you want me to open a 13_3_X backport as well?
i.e. is there a planned MC production in 13_3_X that might benefit from this development?

@perrotta
Copy link
Contributor

perrotta commented Nov 7, 2023

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio francescobrivio mentioned this pull request Nov 7, 2023
Merged
@cmsbuild cmsbuild mentioned this pull request Nov 8, 2023
Merged
@perrotta
Copy link
Contributor

perrotta commented Nov 9, 2023

@rappoccio @antoniovilela can this PR get merged?
There are other GT updates (e.g. #43226) which are waiting for this one being included in the IB

@mmusich mmusich mentioned this pull request Nov 9, 2023
Merged
@francescobrivio francescobrivio mentioned this pull request Nov 9, 2023
Merged
@francescobrivio
Copy link
Contributor Author

A kind ping @cms-sw/orp-l2

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit dad4699 into cms-sw:master Nov 10, 2023
This was referenced Nov 11, 2023
Merged
Merged
@francescobrivio francescobrivio deleted the alca-add_SimBeamSpot_GTs branch November 20, 2023 14:55
@AdrianoDee AdrianoDee mentioned this pull request Aug 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved code-checks-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_14_0_X
Development

Successfully merging this pull request may close these issues.
6 participants
@francescobrivio @cmsbuild @smuzaffar @perrotta @mmusich @antoniovilela