PPS full simulation with beam spot information deom SimBeamSpotObjects #42664

diemort · 2023-08-25T17:11:00Z

PR description:

This PR addresses the issue #41894 to avoid using the BeamSpotObjects from reconstructions and moving to the newly SimBeamSpotObjects in the PPS full simulation. The simulation of generator protons will be based on the simulated beam spot position in accordance with the simulation workflow in central production. The correspoding tag will be provided by AlCa as given in this AlCaDB PR #86.

PR validation:

The changes were validated with the current version of the PPS full simulation and replacing the tag for BeamSpotObectsRcd by the available preliminary tag for SimBeamSpotObectsRcd in PrepDB here via:

process.GlobalTag.toGet = cms.VPSet(
  cms.PSet(
           record = cms.string("SimBeamSpotObjectsRcd"),
           tag = cms.string("SimBeamSpot_Run3RoundOptics25ns13TeVHighSigmaZVtxSmearingParameters_v0_mc"),
           connect = cms.string("frontier://FrontierPrep/CMS_CONDITIONS")
          )
)

As shown below the vertex z position is correctly simulated by the PPS full simulation. The coordinates are centered in zero to perform the proton reconstruction within the PPS acceptance w.r.t. the TOTEM coordinates.

PR passes all code checks.

FYI @fabferro @mundim @wpcarvalho @mmusich @francescobrivio

…ects

cmsbuild · 2023-08-25T17:16:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42664/36735

This PR adds an extra 12KB to repository

cmsbuild · 2023-08-25T17:16:27Z

A new Pull Request was created by @diemort (Gustavo Gil) for master.

It involves the following packages:

SimTransport/PPSProtonTransport (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

civanch · 2023-08-25T17:40:19Z

please test

mmusich · 2023-08-25T17:42:22Z

@civanch

The correspoding tag will be provided by AlCa as given in this AlCaDB PR cms-AlCaDB/AlCaTools#86.

Until this is done, tests should be guaranteed to fail.

cmsbuild · 2023-08-25T18:51:21Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-229cad/34492/summary.html
COMMIT: 257ecf0
CMSSW: CMSSW_13_3_X_2023-08-25-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42664/34492/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

11634.914

----- Begin Fatal Exception 25-Aug-2023 20:09:51 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'FEVTDEBUGoutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGoutput'
   [3] Prefetching for module OscarMTProducer/'g4SimHits'
   [4] Calling method for module PPSSimTrackProducer/'LHCTransport'
Exception Message:
No "SimBeamSpotObjectsRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

11634.0

----- Begin Fatal Exception 25-Aug-2023 20:09:58 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'FEVTDEBUGoutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGoutput'
   [3] Prefetching for module OscarMTProducer/'g4SimHits'
   [4] Calling method for module PPSSimTrackProducer/'LHCTransport'
Exception Message:
No "SimBeamSpotObjectsRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

11634.911

----- Begin Fatal Exception 25-Aug-2023 20:10:09 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'FEVTDEBUGoutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGoutput'
   [3] Prefetching for module OscarMTProducer/'g4SimHits'
   [4] Calling method for module PPSSimTrackProducer/'LHCTransport'
Exception Message:
No "SimBeamSpotObjectsRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

11834.9911834.99_TTbar_14TeV+2021PU_PMXS1S2/step2_TTbar_14TeV+2021PU_PMXS1S2.log
13034.9913034.99_TTbar_14TeV+2024PU_PMXS1S2/step2_TTbar_14TeV+2024PU_PMXS1S2.log
12634.9912634.99_TTbar_14TeV+2023PU_PMXS1S2/step2_TTbar_14TeV+2023PU_PMXS1S2.log

AddOn Tests

hlt_mc_GRun

----- Begin Fatal Exception 25-Aug-2023 19:59:34 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 4 stream: 3
   [1] Running path 'L1TAnalyzerEndpath'
   [2] Prefetching for module L1TGlobalSummary/'L1TGlobalSummary'
   [3] Prefetching for module L1TGlobalProducer/'simGtStage2Digis'
   [4] Prefetching for module L1TStage2Layer2Producer/'simCaloStage2Digis'
   [5] Prefetching for module L1TCaloLayer1/'simCaloStage2Layer1Digis'
   [6] Prefetching for module EcalTrigPrimProducer/'simEcalTriggerPrimitiveDigis'
   [7] Prefetching for module MixingModule/'mix'
   [8] Prefetching for module OscarMTProducer/'g4SimHits'
   [9] Calling method for module PPSSimTrackProducer/'LHCTransport'
Exception Message:
No "SimBeamSpotObjectsRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

hlt_mc_HIon

----- Begin Fatal Exception 25-Aug-2023 19:59:37 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'L1TAnalyzerEndpath'
   [2] Prefetching for module L1TGlobalSummary/'L1TGlobalSummary'
   [3] Prefetching for module L1TGlobalProducer/'simGtStage2Digis'
   [4] Prefetching for module L1TStage2Layer2Producer/'simCaloStage2Digis'
   [5] Prefetching for module L1TCaloLayer1/'simCaloStage2Layer1Digis'
   [6] Prefetching for module EcalTrigPrimProducer/'simEcalTriggerPrimitiveDigis'
   [7] Prefetching for module MixingModule/'mix'
   [8] Prefetching for module OscarMTProducer/'g4SimHits'
   [9] Calling method for module PPSSimTrackProducer/'LHCTransport'
Exception Message:
No "SimBeamSpotObjectsRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

hlt_mc_PIon

----- Begin Fatal Exception 25-Aug-2023 19:59:39 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 3
   [1] Running path 'L1TAnalyzerEndpath'
   [2] Prefetching for module L1TGlobalSummary/'L1TGlobalSummary'
   [3] Prefetching for module L1TGlobalProducer/'simGtStage2Digis'
   [4] Prefetching for module L1TStage2Layer2Producer/'simCaloStage2Digis'
   [5] Prefetching for module L1TCaloLayer1/'simCaloStage2Layer1Digis'
   [6] Prefetching for module EcalTrigPrimProducer/'simEcalTriggerPrimitiveDigis'
   [7] Prefetching for module MixingModule/'mix'
   [8] Prefetching for module OscarMTProducer/'g4SimHits'
   [9] Calling method for module PPSSimTrackProducer/'LHCTransport'
Exception Message:
No "SimBeamSpotObjectsRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

hlt_mc_PRef

diemort · 2023-11-04T13:08:55Z

Related to this PR, any news regarding cms-AlCaDB/AlCaTools#86 @francescobrivio ?

francescobrivio · 2023-11-05T15:56:44Z

Related to this PR, any news regarding cms-AlCaDB/AlCaTools#86 @francescobrivio ?

Dear Gustavo, sorry for the delay!

Things are finally moving and I have just posted on the AlCaDB CMSTalk thread the official request to include the new SimBeamSpotObject tags in all the Run 1/2/3 MC GTs.

Cheers,
Francesco

francescobrivio · 2023-11-06T10:14:29Z

@cmsbuild please test with #43197

cmsbuild · 2023-11-06T13:14:01Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-229cad/35618/summary.html
COMMIT: 257ecf0
CMSSW: CMSSW_13_3_X_2023-11-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42664/35618/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 390 lines from the logs
Reco comparison results: 137 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3363010
DQMHistoTests: Total failures: 2402
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3360586
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

smuzaffar · 2023-11-06T16:50:37Z

Milestone for this pull request has been moved to CMSSW_14_0_X.Please open a backport if it should also go in to CMSSW_13_3_X.

civanch · 2023-11-14T09:06:42Z

#43197 is merged, so let us test this PR again.

civanch · 2023-11-14T09:07:19Z

please test

diemort · 2023-11-14T13:20:24Z

I cannot see the error logs because of a HTTP 404. Does anyone can check them?

francescobrivio · 2023-11-14T13:23:51Z

From here I can see this:

It seems to me that all the failures are in 12434.7 (which is known from #39803), while the other workflows only show errors in tbhe MessageLogger.

diemort · 2023-11-14T13:26:24Z

OK thanks. Let's see if #39803 is resolved.

cmsbuild · 2023-11-15T11:25:03Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-229cad/35783/summary.html
COMMIT: 257ecf0
CMSSW: CMSSW_14_0_X_2023-11-13-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42664/35783/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 290 lines to the logs
Reco comparison results: 18 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3363028
DQMHistoTests: Total failures: 1396
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3361610
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

civanch · 2023-11-16T21:30:36Z

+1

it seems that errors are not related to this PR

cmsbuild · 2023-11-16T21:30:57Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2023-11-17T14:31:53Z

+1

getting beam spot information from simulation based on SimBeamSpotObj…

257ecf0

…ects

cmsbuild added this to the CMSSW_13_3_X milestone Aug 25, 2023

cmsbuild added simulation-pending pending-signatures tests-pending orp-pending code-checks-pending labels Aug 25, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 25, 2023

cmsbuild added tests-started and removed tests-pending labels Aug 25, 2023

cmsbuild added tests-rejected and removed tests-started labels Aug 25, 2023

mmusich mentioned this pull request Aug 26, 2023

Add SimBeamSpotObjects to MC Global Tags cms-AlCaDB/AlCaTools#86

Closed

8 tasks

cmsbuild added requires-external tests-started and removed tests-rejected labels Nov 6, 2023

cmsbuild added tests-approved and removed tests-started labels Nov 6, 2023

smuzaffar removed this from the CMSSW_13_3_X milestone Nov 6, 2023

smuzaffar added this to the CMSSW_14_0_X milestone Nov 6, 2023

cmsbuild modified the milestones: CMSSW_14_0_X, CMSSW_13_3_X Nov 6, 2023

cmsbuild added tests-started and removed requires-external tests-approved labels Nov 14, 2023

cmsbuild added tests-approved and removed tests-started labels Nov 15, 2023

cmsbuild added simulation-approved fully-signed and removed simulation-pending pending-signatures labels Nov 16, 2023

cmsbuild added orp-approved and removed orp-pending labels Nov 17, 2023

cmsbuild merged commit 9ccab08 into cms-sw:master Nov 17, 2023

cmsbuild mentioned this pull request Nov 17, 2023

add verbose option to BeamSpotRcdPrinter and use it in the unit tests #43291

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PPS full simulation with beam spot information deom SimBeamSpotObjects #42664

PPS full simulation with beam spot information deom SimBeamSpotObjects #42664

diemort commented Aug 25, 2023

cmsbuild commented Aug 25, 2023

cmsbuild commented Aug 25, 2023

civanch commented Aug 25, 2023

mmusich commented Aug 25, 2023

cmsbuild commented Aug 25, 2023

diemort commented Nov 4, 2023

francescobrivio commented Nov 5, 2023

francescobrivio commented Nov 6, 2023

cmsbuild commented Nov 6, 2023

smuzaffar commented Nov 6, 2023

civanch commented Nov 14, 2023

civanch commented Nov 14, 2023

diemort commented Nov 14, 2023

francescobrivio commented Nov 14, 2023

diemort commented Nov 14, 2023

cmsbuild commented Nov 15, 2023

civanch commented Nov 16, 2023

cmsbuild commented Nov 16, 2023

rappoccio commented Nov 17, 2023

PPS full simulation with beam spot information deom SimBeamSpotObjects #42664

PPS full simulation with beam spot information deom SimBeamSpotObjects #42664

Conversation

diemort commented Aug 25, 2023

PR description:

PR validation:

cmsbuild commented Aug 25, 2023

cmsbuild commented Aug 25, 2023

civanch commented Aug 25, 2023

mmusich commented Aug 25, 2023

cmsbuild commented Aug 25, 2023

RelVals

RelVals-INPUT

AddOn Tests

diemort commented Nov 4, 2023

francescobrivio commented Nov 5, 2023

francescobrivio commented Nov 6, 2023

cmsbuild commented Nov 6, 2023

Comparison Summary

smuzaffar commented Nov 6, 2023

civanch commented Nov 14, 2023

civanch commented Nov 14, 2023

diemort commented Nov 14, 2023

francescobrivio commented Nov 14, 2023

diemort commented Nov 14, 2023

cmsbuild commented Nov 15, 2023

Comparison Summary

civanch commented Nov 16, 2023

cmsbuild commented Nov 16, 2023

rappoccio commented Nov 17, 2023