add verbose option to BeamSpotRcdPrinter and use it in the unit tests

[mmusich]

PR description:

Title says it all, in response to #43265 (comment)

PR validation:

Run unit tests of the package scram b runtests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43291/37701

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CondTools/BeamSpot/test/testReadWriteBeamSpotsFromDB.sh modified in PR(s): Add new SimBeamSpotHLLHC CondFormat #43186, Fix BeamSpotRcdRead_cfg and add unitTest #43265

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CondTools/BeamSpot (db, alca)

@saumyaphor4252, @francescobrivio, @cmsbuild, @perrotta, @consuegs can you please review it and eventually sign? Thanks.
@rsreds, @mmusich, @yuanchao, @tocheng, @PonIlya this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-08d1ed/35855/summary.html
COMMIT: 27efde0
CMSSW: CMSSW_14_0_X_2023-11-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43291/35855/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 183 lines from the logs
• Reco comparison results: 22 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363070
• DQMHistoTests: Total failures: 1403
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3361645
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

is there anything stopping integration of this?

[rappoccio]

@mmusich there's a merge conflict now, can you fix? thanks.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43291/37766

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CondTools/BeamSpot/test/testReadWriteBeamSpotsFromDB.sh modified in PR(s): Add new SimBeamSpotHLLHC CondFormat #43186

[cmsbuild]

Pull request #43291 was updated. @francescobrivio, @perrotta, @saumyaphor4252, @consuegs can you please check and sign again.

[cmsbuild]

-1

Failed Tests: UnitTests RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-08d1ed/35921/summary.html
COMMIT: 65ac130
CMSSW: CMSSW_14_0_X_2023-11-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43291/35921/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @wddgit Delete references to legacy module types in DQM. #43279
• @fabiocos MTD validation: add plugin to monitor impact of MTD on electron isolation #43259
• @CTPPS PPS - RawToDigi update to handle mappings from CondDB #42711
• @francescobrivio Fix BeamSpotRcdRead_cfg and add unitTest #43265
• @iasonkrom Add CaloIdL_MW seeded filter and split the legs of CaloIdL_TrackIdL_IsoVL filter on nanoAOD filterBits #43247
• @aandvalenzuela [RECO] Fix DEVEL warnings on deprecated copy-constructors #43270
• @wddgit Delete alca legacy module types, cleanup #43277
• @Prasant1993 Add Correct EGM Run3 electron NonIso MVA ID for EB  #43275
• @iarspider-cmssw Replace C-style array with std::array in HLTHPDFilter #43157
• @depasse ECAL : DB PayloadInspector improvement #43272
• @Dr15Jones Added between Event callbacks to Tracer log file #43262
• @CTPPS PPS full simulation with beam spot information deom SimBeamSpotObjects #42664
• @bsunanda Run3-hcx356 Include the updated XML file for ZDC to the 2023 scenario for CMS #43237
• @yuanchao Remove try/catch clause in castor analyzer #43283
• @ericcano SoA fixes (2nd round): fix and add broken / missing SoA (const) row-to-row assignment. #43281
• @aandvalenzuela [ALIGNMENT] Fix DEVEL warnings on deprecated copy-constructors #43268
• @smuzaffar Fix testCSCTriggerMapping test: avoid reading invalid data e.g empty line #43269
• @perrotta Add PPS DAQ mapping to 13_3_X real data Run2 and Run3 GTs #43226
• @bsunanda Run3-sim152 Restore the Run1 code for ZDC hit production using a library parametrisation which can be switched on through parameter setting #43284

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-08d1ed/35921/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-08d1ed/35921/git-merge-result

Unit Tests

I found 2 errors in the following unit tests:

---> test runtestRecoEgammaElectronIdentification had ERRORS
---> test testTauEmbeddingProducers had ERRORS

RelVals

• 136.8311

----- Begin Fatal Exception 17-Nov-2023 17:51:10 CET-----------------------
An exception of category 'MVA config failure: ' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=ElectronMVAValueMapProducer label='electronMVAValueMapProducer'
Exception Message:
Concerning ElectronMVAEstimatorRun2RunIIIWinter22NoIsoV1
Variable ele_hcalPFClusterIso not found in variable definition file!
----- End Fatal Exception -------------------------------------------------

• 136.7611

----- Begin Fatal Exception 17-Nov-2023 17:51:10 CET-----------------------
An exception of category 'MVA config failure: ' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=ElectronMVAValueMapProducer label='electronMVAValueMapProducer'
Exception Message:
Concerning ElectronMVAEstimatorRun2RunIIIWinter22NoIsoV1
Variable ele_hcalPFClusterIso not found in variable definition file!
----- End Fatal Exception -------------------------------------------------

• 136.88811

----- Begin Fatal Exception 17-Nov-2023 17:51:11 CET-----------------------
An exception of category 'MVA config failure: ' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=ElectronMVAValueMapProducer label='electronMVAValueMapProducer'
Exception Message:
Concerning ElectronMVAEstimatorRun2RunIIIWinter22NoIsoV1
Variable ele_hcalPFClusterIso not found in variable definition file!
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

• 4.53
• 135.4
• 136.731
• 136.793
• 136.874
• 158.01
• 139.001
• 9.0
• 2018.1
• 1306.0
• 25.0
• 312.0
• 1330.0
• 141.044
• 10042.0
• 13234.0
• 14034.0
• 10024.0
• 14234.0
• 25202.0
• 10824.0
• 11634.0
• 2500.4
• 11634.911
• 10224.0
• 11634.914
• 12434.0
• 12434.7
• 24900.0
• 24896.0
• 12634.0
• 24834.0
• 23234.0
• 250202.181
• 25034.999
• 24834.911

RelVals-INPUT

• 4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
• 136.72411136.72411_RunJetHT2016B_reminiaodUL/step2_RunJetHT2016B_reminiaodUL.log
• 136.72412136.72412_RunJetHT2016B_reminiaodUL/step2_RunJetHT2016B_reminiaodUL.log

Expand to see more relval errors ...

• 136.7611
• 136.76111
• 136.7721
• 136.77211
• 136.8311
• 136.83111
• 136.9
• 136.88811
• 140.201
• 140.5611
• 140.202
• 158.01
• 159.01
• 1325.5
• 1325.51
• 1325.5161
• 1325.517
• 1325.516
• 1325.518
• 134.0
• 144.6
• 1002.0
• 13234.0
• 13434.0
• 14034.0
• 14234.0
• 2500.0
• 2500.001
• 2500.002
• 2500.1
• 2500.3
• 2500.2
• 2500.31
• 2500.21
• 2500.4
• 2500.311
• 2500.01
• 2500.011
• 2500.211
• 2500.012

[mmusich]

please test

[mmusich]

@perrotta you might want to sign again irrespective of the failed test (due to the broken IB). Last push just resolved the merge conflict

[perrotta]

@perrotta you might want to sign again irrespective of the failed test (due to the broken IB). Last push just resolved the merge conflict

Indeed...
And rerunning the tests won't change their outcome, I fear

[perrotta]

The failing workflow are not identically the same as the ones failing in the IB. They certainly have the same origin, but let have a look at the new tests just launched first.

[mmusich]

They certainly have the same origin, but let have a look at the new tests just launched first.

There is absolutely no point in that, as the PR is not touching any code used in relvals. Why are you deliberately delaying the merge here (and many other PRs in the past)?

[perrotta]

There is absolutely no point in that, as the PR is not touching any code used in relvals. Why are you deliberately delaying the merge here (and many other PRs in the past)?

Even if the release managers decide to keep integrating in spite of the storm of errors in the IBs after the last merging of 22 PRs all at once, I imagine that given their time zones none of them two will wake up before 11 am (CET) to integrate new ones in time for the 1100 IB.

Since you relaunched the tests (unnecessarily, in my opinion) let them finish and have a look at their output, as I am curious to see whether the errors keeps appearing in different workflows as in the IB. (And please don't answer "the tests will finish even if you sign this PR now": I know it)

[mmusich]

, I imagine that given their time zones none of them two will wake up before 11 am (CET) to integrate new ones in time for the 1100 IB.

that's a moot point. This PR is orp signed. Once the test finish (I think successfully), this PR will be automatically merged.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-08d1ed/35937/summary.html
COMMIT: 65ac130
CMSSW: CMSSW_14_0_X_2023-11-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43291/35937/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 14 lines from the logs
• Reco comparison results: 15 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363868
• DQMHistoTests: Total failures: 1413
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3362433
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.