Remove try/catch clause in castor analyzer

[yuanchao]

PR description:

Part of code cleaning campaign slides regarding the edm exception use guideline https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideEdmExceptionUse . As the catch action clause in the original source has been commented, error message is directed to edm::LogError.

PR validation:

Tested locally with code-checks and code-format.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is not a backport.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43283/37694

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @yuanchao (Yuan CHAO) for master.

It involves the following packages:

• CalibCalorimetry/CastorCalib (alca)

@cmsbuild, @perrotta, @consuegs, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@tocheng, @rsreds, @mmusich, @yuanchao this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5e211/35834/summary.html
COMMIT: 492a434
CMSSW: CMSSW_14_0_X_2023-11-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43283/35834/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 93 lines to the logs
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363070
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3363048
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[perrotta]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1