Adapt PF code to read Hcal thresholds from GT

[swagata87]

PR description:

HCal thresholds are available in GT now. This is an attempt to adapt PF codes to use the HCal thresholds from GT, instead of using hard-coded values from config files. This was discussed here:
https://indico.cern.ch/event/1220970/contributions/5284605/attachments/2598482/4486203/HCAL_PFlowCutsSeeds_Feb24_2023.pdf

PR validation:

Checked several WFs with runthematrix

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43025/37196

• This PR adds an extra 48KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): revert PR 40443 w/o introducing bricked pixels #42454

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43025/37196/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43025/37196/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43025/37197

• This PR adds an extra 48KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): revert PR 40443 w/o introducing bricked pixels #42454

[cmsbuild]

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)
• RecoParticleFlow/PFClusterProducer (reconstruction)

@mandrenguyen, @mmusich, @jfernan2, @Martin-Grunewald, @cmsbuild, @missirol can you please review it and eventually sign? Thanks.
@sameasy, @wang0jin, @mmarionncern, @silviodonato, @felicepantaleo, @rchatter, @Martin-Grunewald, @hatakeyamak, @argiro, @thomreis, @rovere, @lgray, @ebrondol, @missirol, @seemasharmafnal, @SohamBhattacharya this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[swagata87]

although this is currently a draft PR, let me tag @cms-sw/alca-l2, @abdoulline, and @igv4321 in case they have comments.

HcalPFCuts database table and relevant infrastructure was introduced in
#41128

And after all the PF and EGamma code are adapted to use it this is expected to replace the Era-based treatment used in 2022/2023 as seen from here:
#41581
#41271

tagging EGM @cms-sw/egamma-pog-l2, @Prasant1993
tagging PF @cms-sw/pf-l2 , @laurenhay

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43025/37198

• This PR adds an extra 52KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): revert PR 40443 w/o introducing bricked pixels #42454

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43025/37198/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43025/37198/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43025/37199

• This PR adds an extra 52KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): revert PR 40443 w/o introducing bricked pixels #42454

[cmsbuild]

Pull request #43025 was updated. @mmusich, @Martin-Grunewald, @jfernan2, @mandrenguyen, @missirol, @cmsbuild can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d388a8/35892/summary.html
COMMIT: 9990f0d
CMSSW: CMSSW_14_0_X_2023-11-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43025/35892/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 133 lines from the logs
• Reco comparison results: 153 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363070
• DQMHistoTests: Total failures: 1804
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3361244
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: found differences in 3 / 48 workflows

[mmusich]

+hlt

• for swagata87@9990f0d
• PR according to descriptions and follow-up review.
• change in the DQM bin-by-bin comparison and trigger results (as reported in Adapt PF code to read Hcal thresholds from GT #43025 (comment)) are understood as explained in Adapt PF code to read Hcal thresholds from GT #43025 (comment) and following comments.
• some possible further improvement on the PF side are collected in the issue fillDescriptions for all PFlow producers and better handling of HcalPFCuts #43169
• finally a squash to reduce the number of commits might be desirable (and / or requested by ORP), though based on the discussion at Change EGM code to be able to read HCAL PF thresholds from DB #43164 (comment) and following I gather this is urgent

[jfernan2]

+reconstruction

[mmusich]

@cms-sw/orp-l2 please clarify the integration plan for this PR.

[rappoccio]

@mmusich we discussed with @malbouis and @jordan-martins and it's my understanding that this should stay in 14_0

[rappoccio]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.