Add era modifier for Run3 and HcalPFCuts withTopo to event record

[RSalvatico]

PR description:

This PR addresses the technical baseline changes needed by #43025 and #43164: the addition of an Era Modifier, its implementation into Era_Run3, and mostly the addition of HcalPFCuts to the event record.

PR validation:

runTheMatrix.py -l 10824.0
runTheMatrix.py -l 10024.0

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43305/37750

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/Eras/python/Era_Run3_cff.py modified in PR(s): Adapt PF code to read Hcal thresholds from GT #43025, Change EGM code to be able to read HCAL PF thresholds from DB #43164
  • File Configuration/Eras/python/Modifier_hcalPfCutsFromDB_cff.py modified in PR(s): Adapt PF code to read Hcal thresholds from GT #43025, Change EGM code to be able to read HCAL PF thresholds from DB #43164
  • File RecoLocalCalo/HcalRecAlgos/plugins/HcalChannelPropertiesEP.cc modified in PR(s): Adapt PF code to read Hcal thresholds from GT #43025, Change EGM code to be able to read HCAL PF thresholds from DB #43164

[cmsbuild]

A new Pull Request was created by @RSalvatico (Riccardo Salvatico) for master.

It involves the following packages:

• Configuration/Eras (operations)
• RecoLocalCalo/HcalRecAlgos (reconstruction)

@cmsbuild, @davidlange6, @mandrenguyen, @jfernan2, @antoniovilela, @rappoccio, @fabiocos can you please review it and eventually sign? Thanks.
@apsallid, @bsunanda, @AnnikaStein, @mariadalfonso, @Martin-Grunewald, @rchatter, @argiro, @youyingli, @wang0jin, @ReyerBand, @missirol, @abdoulline, @thomreis, @makortel, @fabiocos this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[RSalvatico]

type egamma

[RSalvatico]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0399b6/35896/summary.html
COMMIT: 4fb477e
CMSSW: CMSSW_14_0_X_2023-11-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43305/35896/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 312 lines from the logs
• Reco comparison results: 139 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363070
• DQMHistoTests: Total failures: 2395
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3360653
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[mmusich]

hold

• once Adapt PF code to read Hcal thresholds from GT #43025 is merged, this PR becomes unnecessary

[cmsbuild]

Pull request has been put on hold by @mmusich
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[mmusich]

as far as I can tell, this PR can be closed now. @RSalvatico

[RSalvatico]

as far as I can tell, this PR can be closed now. @RSalvatico

Closing