Migrate RecHit-based rho producer to use HCal noise cuts from GT #43176

swagata87 · 2023-11-03T08:54:03Z

PR description:

Adapt FixedGridRhoProducerFastjetFromRecHit.cc to use HCal noise cuts from GT.
This producer is used only in HLT and was introduced before the start of Run3 (via #36157) to move away from caloTowers. The HCal noise cuts were previously provided from HLT config. Now it is made GT-based. Although, we still keep the option open to use cuts from config file. If this is deemed unnecessary, we can remove the option and allow only GT-based approach.

Related PRs which are doing similar migrations:

Adapt PF code to read Hcal thresholds from GT #43025 for RecoParticleFlow
Change EGM code to be able to read HCAL PF thresholds from DB #43164 for RecoEgamma

PR validation:

Tested with some Run3 WFs.

swagata87 · 2023-11-03T08:55:56Z

FYI @cms-sw/alca-l2

cmsbuild · 2023-11-03T09:00:37Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43176/37504

This PR adds an extra 36KB to repository

cmsbuild · 2023-11-03T09:01:03Z

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master.

It involves the following packages:

RecoJets/JetProducers (reconstruction)

@mandrenguyen, @jfernan2, @cmsbuild can you please review it and eventually sign? Thanks.
@seemasharmafnal, @nhanvtran, @gkasieczka, @rappoccio, @AnnikaStein, @jdamgov, @mariadalfonso, @yslai, @schoef, @jdolen, @clelange, @ahinzmann, @missirol this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

perrotta · 2023-11-03T09:18:26Z

RecoJets/JetProducers/plugins/FixedGridRhoProducerFastjetFromRecHit.cc

@@ -147,11 +177,15 @@ std::array<double, 4> FixedGridRhoProducerFastjetFromRecHit::getHitP4(const DetI
 }

 //HCAL noise cleaning cuts.
-bool FixedGridRhoProducerFastjetFromRecHit::passedHcalNoiseCut(const HBHERecHit &hit) const {
+bool FixedGridRhoProducerFastjetFromRecHit::passedHcalNoiseCut(const HBHERecHit &hit, float thres) const {
  const auto thisDetId = hit.id();


You can move these two lines inside the if here below

cmsbuild · 2023-11-03T10:44:52Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43176/37505

This PR adds an extra 36KB to repository

cmsbuild · 2023-11-03T10:45:15Z

Pull request #43176 was updated. @cmsbuild, @mandrenguyen, @jfernan2 can you please check and sign again.

swagata87 · 2023-11-03T11:56:33Z

please test with #43171

mmusich · 2023-11-03T12:59:07Z

RecoJets/JetProducers/plugins/FixedGridRhoProducerFastjetFromRecHit.cc

+    const HcalTopology &htopo = es.getData(htopoToken_);
+    const HcalPFCuts &hcalCuts = es.getData(hcalCutsToken_);
+    paramPF_ = std::make_unique<HcalPFCuts>(hcalCuts);
+    paramPF_->setTopo(&htopo);


See #43025 (comment)

cmsbuild · 2023-11-03T14:46:27Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a6261/35578/summary.html
COMMIT: 58fbc98
CMSSW: CMSSW_13_3_X_2023-11-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43176/35578/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 84 lines from the logs
Reco comparison results: 17 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3362691
DQMHistoTests: Total failures: 1395
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3361274
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

smuzaffar · 2023-11-06T16:51:52Z

Milestone for this pull request has been moved to CMSSW_14_0_X.Please open a backport if it should also go in to CMSSW_13_3_X.

cmsbuild · 2023-11-26T17:01:52Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43176/37890

This PR adds an extra 16KB to repository

cmsbuild · 2023-11-26T17:02:17Z

Pull request #43176 was updated. @mandrenguyen, @Martin-Grunewald, @mmusich, @cmsbuild, @jfernan2 can you please check and sign again.

Martin-Grunewald · 2023-11-27T08:07:37Z

please test

cmsbuild · 2023-11-27T11:29:02Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a6261/36075/summary.html
COMMIT: d73a580
CMSSW: CMSSW_14_0_X_2023-11-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43176/36075/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 179 lines from the logs
Reco comparison results: 16 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3367918
DQMHistoTests: Total failures: 1109
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3366787
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

mmusich · 2023-11-27T11:34:23Z

+hlt

see Migrate RecHit-based rho producer to use HCal noise cuts from GT #43176 (comment)
re-sign after squash
difference in PR tests results are due to known instable wf 12434.7

mmusich · 2023-11-28T08:54:02Z

@cms-sw/reconstruction-l2 your signature is required here.

mandrenguyen · 2023-11-28T09:51:36Z

+reconstruction

cmsbuild · 2023-11-28T09:52:08Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2023-11-28T15:51:31Z

+1

cmsbuild added this to the CMSSW_13_3_X milestone Nov 3, 2023

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending labels Nov 3, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 3, 2023

perrotta reviewed Nov 3, 2023

View reviewed changes

swagata87 mentioned this pull request Nov 3, 2023

Change EGM code to be able to read HCAL PF thresholds from DB #43164

Merged

cmsbuild added code-checks-pending and removed code-checks-approved labels Nov 3, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 3, 2023

cmsbuild added tests-started requires-external and removed tests-pending labels Nov 3, 2023

mmusich reviewed Nov 3, 2023

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Nov 3, 2023

smuzaffar modified the milestones: CMSSW_13_3_X, CMSSW_14_0_X Nov 6, 2023

cmsbuild added tests-pending code-checks-pending labels Nov 26, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 26, 2023

cmsbuild added tests-started and removed tests-pending labels Nov 27, 2023

cmsbuild added tests-approved and removed tests-started labels Nov 27, 2023

cmsbuild added hlt-approved and removed hlt-pending labels Nov 27, 2023

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Nov 28, 2023

cmsbuild added orp-approved and removed orp-pending labels Nov 28, 2023

cmsbuild merged commit 0036321 into cms-sw:master Nov 28, 2023
12 checks passed

This was referenced Nov 28, 2023

[LTO] Improve link time by using multiple process for linking cms-sw/cmsdist#8840

Merged

Add recipe for pytorch (C++ interface only) cms-sw/cmsdist#8388

Merged

perrotta mentioned this pull request Nov 30, 2023

Spurious comparison differences in workflows 136.X, 141.044, 4.54, ... #43456

Closed

swagata87 mentioned this pull request May 20, 2024

RecHit based Ecal/Hcal muon isolation #44797

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate RecHit-based rho producer to use HCal noise cuts from GT #43176

Migrate RecHit-based rho producer to use HCal noise cuts from GT #43176

swagata87 commented Nov 3, 2023

swagata87 commented Nov 3, 2023

cmsbuild commented Nov 3, 2023

cmsbuild commented Nov 3, 2023

perrotta Nov 3, 2023

cmsbuild commented Nov 3, 2023

cmsbuild commented Nov 3, 2023

swagata87 commented Nov 3, 2023

mmusich Nov 3, 2023

cmsbuild commented Nov 3, 2023

smuzaffar commented Nov 6, 2023

cmsbuild commented Nov 26, 2023

cmsbuild commented Nov 26, 2023

Martin-Grunewald commented Nov 27, 2023

cmsbuild commented Nov 27, 2023

mmusich commented Nov 27, 2023

mmusich commented Nov 28, 2023

mandrenguyen commented Nov 28, 2023

cmsbuild commented Nov 28, 2023

rappoccio commented Nov 28, 2023

Migrate RecHit-based rho producer to use HCal noise cuts from GT #43176

Migrate RecHit-based rho producer to use HCal noise cuts from GT #43176

Conversation

swagata87 commented Nov 3, 2023

PR description:

PR validation:

swagata87 commented Nov 3, 2023

cmsbuild commented Nov 3, 2023

cmsbuild commented Nov 3, 2023

perrotta Nov 3, 2023

Choose a reason for hiding this comment

cmsbuild commented Nov 3, 2023

cmsbuild commented Nov 3, 2023

swagata87 commented Nov 3, 2023

mmusich Nov 3, 2023

Choose a reason for hiding this comment

cmsbuild commented Nov 3, 2023

Comparison Summary

smuzaffar commented Nov 6, 2023

cmsbuild commented Nov 26, 2023

cmsbuild commented Nov 26, 2023

Martin-Grunewald commented Nov 27, 2023

cmsbuild commented Nov 27, 2023

Comparison Summary

mmusich commented Nov 27, 2023

mmusich commented Nov 28, 2023

mandrenguyen commented Nov 28, 2023

cmsbuild commented Nov 28, 2023

rappoccio commented Nov 28, 2023