Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding lumi=0 defaults to hardcode HB PFCuts for Phase2 #43171

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

abdoulline
Copy link

PR description:

Specifications previously committed in #43139 don't precisely cover a special case of Phase2 wfs without aging, as discussed in
#43025 (comment)
This PR fills this gap.
No wfs expected to be affected at the moment.

PR validation:

HcalPDCutsRcd dump for Phase2 without aging customization shows HB numbers corresponding to those from edmConfigDump of 24834.0_TTbar_14TeV+2026D98 (no aging) configs.

              eta             phi             dep             det     value0     value1      DetId
               -1               1               1              HB  0.1000000  0.1250000   43100401
               -1               1               2              HB  0.2000000  0.2500000   43200401
               -1               1               3              HB  0.3000000  0.3500000   43300401
               -1               1               4              HB  0.3000000  0.3500000   43400401
               -2               1               1              HB  0.1000000  0.1250000   43100801
               -2               1               2              HB  0.2000000  0.2500000   43200801
               -2               1               3              HB  0.3000000  0.3500000   43300801
               -2               1               4              HB  0.3000000  0.3500000   43400801

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43171/37495

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2023

A new Pull Request was created by @abdoulline (Salavat Abdullin) for master.

It involves the following packages:

  • CalibCalorimetry/HcalAlgos (alca)

@consuegs, @cmsbuild, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@mariadalfonso, @tocheng, @rsreds, @bsunanda, @yuanchao, @mmusich this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Nov 2, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0efcc/35565/summary.html
COMMIT: 58e9d75
CMSSW: CMSSW_13_3_X_2023-11-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43171/35565/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 10 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3362691
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3362669
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Nov 2, 2023

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a0d5dce into cms-sw:master Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants