[13_3_X] Adapt PF code to read Hcal thresholds from GT

[swagata87]

Verbatim backport of #43025

Technical PR. No change in physics should be there; except:

• some changes in Phase2 HLT, the cause of which is understood -> Adapt PF code to read Hcal thresholds from GT #43025 (comment) ).
• some non-reproducibility issues Non reproducibility in wf 136.793 #43293

This PR allows HCal thresholds to be read from GT, so that during data-taking the thresholds can be updated more easily, w/o the overhead of needing a new CMSSW release every time there is a threshold update.

If this can enter 13_3_X then a proper validation with high-stat will be possible, which can be useful to gain more confidence before using it for 2024 data-taking.

[cmsbuild]

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for CMSSW_13_3_X.

It involves the following packages:

• Configuration/Eras (operations)
• HLTrigger/Configuration (hlt)
• RecoLocalCalo/HcalRecAlgos (reconstruction)
• RecoParticleFlow/PFClusterProducer (reconstruction)

@mandrenguyen, @jfernan2, @davidlange6, @cmsbuild, @mmusich, @rappoccio, @fabiocos, @Martin-Grunewald, @antoniovilela can you please review it and eventually sign? Thanks.
@ReyerBand, @ebrondol, @rovere, @wang0jin, @apsallid, @Martin-Grunewald, @rchatter, @bsunanda, @seemasharmafnal, @missirol, @hatakeyamak, @makortel, @mariadalfonso, @sameasy, @thomreis, @silviodonato, @argiro, @SohamBhattacharya, @fabiocos, @lgray, @felicepantaleo, @abdoulline, @mmarionncern, @AnnikaStein, @youyingli this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Adapt PF code to read Hcal thresholds from GT #43025

[swagata87]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-367a03/35898/summary.html
COMMIT: ee935b1
CMSSW: CMSSW_13_3_X_2023-11-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43307/35898/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 404 lines from the logs
• Reco comparison results: 151 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363028
• DQMHistoTests: Total failures: 1805
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3361201
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: found differences in 3 / 48 workflows

[jfernan2]

+1

[mmusich]

@swagata87

Moreover, #43171 is not backported to 13_3_X, that will also give rise to differences in phase2 HLT WFs.

this appears to not be correct. I think #43171 was still merged within 13_3_X (at least I see the commit 58e9d75 in the 13_3_X branch history). Please amend the PR description.

[mmusich]

backport of #43025

[mmusich]

type pf

[mmusich]

+hlt

• verbatim backport of Adapt PF code to read Hcal thresholds from GT #43025;
• see Adapt PF code to read Hcal thresholds from GT #43025 (comment) for more detailed analysis.

[swagata87]

this appears to not be correct. I think #43171 was still merged within 13_3_X (at least I see the commit 58e9d75 in the 13_3_X branch history). Please amend the PR description.

ah okay, now the PR description is fixed

[swagata87]

I received a notification from PPD that this development is mainly for 14_0 cycle. I guess this backport is not needed in that case. If I understood the plans correctly, I can probably just close this PR.

[antoniovilela]

hold

• Let's avoid merging the backport, at least for now.

[cmsbuild]

Pull request has been put on hold by @antoniovilela
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[Martin-Grunewald]

code-checks

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43307/37866

ERROR: Unable to merge PR.

See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43307/37866/cms-checkout-topic.log

[mmusich]

@swagata87 please clarify the need of this PR in light of #43355 (comment).

[swagata87]

I think this PR can be closed. I will close it.