revert PR 40443 w/o introducing bricked pixels

[emiglior]

PR description:

This PR is the first step towards the description of the so-called big pixels for the phase-2 InnerTracker as proposed in

https://indico.cern.ch/event/1242584/contributions/5517916/attachments/2691752/4671198/em20230728.pdf

The plan is to describe the phase-2 big pixels in the file pixelStructureTopology.xml or by using the TrackerAdditionalParametersPerDet rcd for geometries loaded from DB.

The goal of this PR is to put back the changes of the infrastructure needed for using the TrackerAdditionalParametersPerDet rcd, introduced for the bricked pixels and then removed with PR#40443 (but without reintroducing the functions related to bricked pixels).

NOTE (similar to PR#34120): the record PTrackerAdditionalParametersPerDetRcd is consumed by the TrackerGeomBuilderFromGeometricDet, which is the same for Runs 2&3 and Phase 2. Therefore, this PR also modifies Runs 2&3, by including the new record. Anyway, for the moment no new parameters are introduced. We will take care setting the new parameters describing big pixels to dummy values for the geometries before phase-2.

PR validation:

• compilation ok after git cms-checkdeps -a
• scram b code-checks, code-format
• checked on ph-2 w/f 25610

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport and no backport needed
(related PR#42448 targeting 13_2_X can be dismissed)

@tvami @mmusich @adewit @gbardell

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42454/36458

• This PR adds an extra 156KB to repository

[cmsbuild]

A new Pull Request was created by @emiglior (Ernesto Migliore) for master.

It involves the following packages:

• Alignment/CommonAlignmentMonitor (alca)
• Alignment/CommonAlignmentProducer (alca)
• Alignment/LaserAlignment (alca)
• Alignment/MillePedeAlignmentAlgorithm (alca)
• Alignment/OfflineValidation (alca)
• Alignment/SurveyAnalysis (alca)
• Alignment/TrackerAlignment (alca)
• CondTools/Geometry (db)
• Configuration/Geometry (geometry, upgrade)
• Geometry/TrackerGeometryBuilder (geometry)

@perrotta, @consuegs, @Dr15Jones, @bsunanda, @makortel, @civanch, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @saumyaphor4252, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@pakhotin, @VourMa, @vargasa, @adewit, @JanFSchulte, @tocheng, @VinInn, @Martin-Grunewald, @missirol, @bsunanda, @tlampen, @mmusich, @mtosi, @fabiocos, @slomeo, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[mmusich]

@emiglior this is already failing the addOnTests

----- Begin Fatal Exception 03-Aug-2023 08:39:57 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing global begin Run run: 1
   [1] Prefetching for module SiPixelPhase1CompareRecHitsSoA/'hltSiPixelRecHitsSoACompareGPUvsCPU'
   [2] Calling method for EventSetup module TrackerDigiGeometryESModule/''
   [3] While getting dependent Record from Record TrackerDigiGeometryRecord
Exception Message:
No "PTrackerAdditionalParametersPerDetRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

I guess you need to add an appropriate ESSource to the HLT menus via customizeHLTforCMSSW.py

[cmsbuild]

-1

Failed Tests: RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-411090/34044/summary.html
COMMIT: aeaa04f
CMSSW: CMSSW_13_3_X_2023-08-02-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42454/34044/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

AddOn Tests

• hlt_mc_GRun

----- Begin Fatal Exception 03-Aug-2023 08:39:57 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing global begin Run run: 1
   [1] Prefetching for module SiPixelPhase1CompareRecHitsSoA/'hltSiPixelRecHitsSoACompareGPUvsCPU'
   [2] Calling method for EventSetup module TrackerDigiGeometryESModule/''
   [3] While getting dependent Record from Record TrackerDigiGeometryRecord
Exception Message:
No "PTrackerAdditionalParametersPerDetRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

• hlt_mc_HIon

----- Begin Fatal Exception 03-Aug-2023 08:39:27 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing global begin Run run: 1
   [1] Prefetching for module SiPixelPhase1CompareRecHitsSoA/'hltSiPixelRecHitsSoACompareGPUvsCPU'
   [2] Calling method for EventSetup module TrackerDigiGeometryESModule/''
   [3] While getting dependent Record from Record TrackerDigiGeometryRecord
Exception Message:
No "PTrackerAdditionalParametersPerDetRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

• hlt_mc_PRef

----- Begin Fatal Exception 03-Aug-2023 08:39:37 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing global begin Run run: 1
   [1] Prefetching for module SiPixelPhase1CompareRecHitsSoA/'hltSiPixelRecHitsSoACompareGPUvsCPU'
   [2] Calling method for EventSetup module TrackerDigiGeometryESModule/''
   [3] While getting dependent Record from Record TrackerDigiGeometryRecord
Exception Message:
No "PTrackerAdditionalParametersPerDetRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

• hlt_data_GRun
• hlt_data_HIon
• hlt_data_PRef

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3150821
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3150796
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[Martin-Grunewald]

Hmm, the addOnTests for HLT are Run3, not Phase2 - why are they affected by this Phase-2 PR?

[mmusich]

why are they affected by this Phase-2 PR?

because this is NOT a phase-2 PR.

[Martin-Grunewald]

why are they affected by this Phase-2 PR?

because this is NOT a phase-2 PR.

Well, then the PR description is misleading and should be improved....

[mmusich]

Well, then the PR description is misleading and should be improved....

it's a draft...

[emiglior]

@emiglior this is already failing the addOnTests

----- Begin Fatal Exception 03-Aug-2023 08:39:57 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing global begin Run run: 1
   [1] Prefetching for module SiPixelPhase1CompareRecHitsSoA/'hltSiPixelRecHitsSoACompareGPUvsCPU'
   [2] Calling method for EventSetup module TrackerDigiGeometryESModule/''
   [3] While getting dependent Record from Record TrackerDigiGeometryRecord
Exception Message:
No "PTrackerAdditionalParametersPerDetRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

I guess you need to add an appropriate ESSource to the HLT menus via customizeHLTforCMSSW.py

Thanks @mmusich for the feedback.
I guess I have to do something along the line to what was done for PR#34120 when the PTrackerAdditionalParametersPerDetRcd was introduced.

What is the suggested way to test it?

[mmusich]

@emiglior

I guess I have to do something along the line to what was done for PR#34120 when the PTrackerAdditionalParametersPerDetRcd was introduced.

yep, something like:

https://github.com/adewit/cmssw/blob/c05d615ba6b94eda2c67763e53ca98f17c19ecd7/HLTrigger/Configuration/python/customizeHLTforCMSSW.py#L132-L135

and

https://github.com/adewit/cmssw/blob/c05d615ba6b94eda2c67763e53ca98f17c19ecd7/HLTrigger/Configuration/python/customizeHLTforCMSSW.py#L143-L144

should do it.

What is the suggested way to test it?

run addOnTests locally in your installation.

[smuzaffar]

Milestone for this pull request has been moved to CMSSW_14_0_X.Please open a backport if it should also go in to CMSSW_13_3_X.

[emiglior]

Hi @smuzaffar
we do not plan a backport to 13_3_X

[smuzaffar]

@emiglior , its up to you or L2's to decide. Today we opened CMSSW_14_0_X release cycles and all PRs for master branch will automatically go to 14.0.X, if this change is needed for 13.3.X then please feel free to open a backport PR

[mmusich]

what is the plan about this PR?

[emiglior]

what is the plan about this PR?

We started to work on proto-code to have a full description of big pixels from geometry-topology to local reco, as my understanding was that a broader overview of the development was envisaged.
We are still at a WIP stage, e.g. it is not meant for 14_0_0.

[mmusich]

We are still at a WIP stage, e.g. it is not meant for 14_0_0.

perhaps this can be closed and re-opened when a more realistic implementation is presented.