-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECAL unpacker and ECAL multifit algorithm migration to alpaka #43257
ECAL unpacker and ECAL multifit algorithm migration to alpaka #43257
Conversation
type ecal |
enable gpu |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43257/37641 ERROR: Build errors found during clang-tidy run.
|
test parameters:
|
code-checks |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43257/37642 ERROR: Build errors found during clang-tidy run.
|
5aaf97d
to
14c3c41
Compare
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43257/37645 ERROR: Build errors found during clang-tidy run.
|
14c3c41
to
8cf598a
Compare
what workflow are you running ? |
Not a workflow, but streamers from run 375631 (hi_run). |
something I can test ? |
that's strange. The unit test for this client was run in the last batch of tests (see https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1276f/36979/unitTests/src/DQM/Integration/test/TestDQMOnlineClient-pixellumi_dqm_sourceclient/testing.log) and no error was reported. Can you try on top of a more recent IB? |
I had to change MessageLogger configurations in some DQM sourceclients to pass the tests but I did not need to touch the pixellumi one. Would it work if the MessageLogger configuration is adjusted in the style of the pixel_dqm_sourceclient-live_cfg.py. |
A difference I see in the logs you posted vs. the logs on the DQM machines is: cmssdt:
DQM machines:
And directly after the line above is the Fatal Exception message. Unsure if it's related to something. |
Ah, this made me realize that the cmssw/HeterogeneousCore/AlpakaCore/python/ProcessAcceleratorAlpaka.py Lines 66 to 68 in d0954a1
relies on python machinery defined in FWCore.ParameterSet.MessageLogger , that is not available if one just defined process.MessageLogger = cms.Service("MessageLogger", ...) . So all uses of that pattern should be changed to modify the existing process.MessageLogger (note that process.load(...) is not needed, MessageLogger is available from cms.Process() construction)
|
Ah... that's because
Could this be problematic for the HLT menu as it runs online ? I guess we can just add |
Not really. The framework calls the The error message in #43257 (comment) comes from MessageLogger's ParameterSet validation code. I was a little bit off in my earlier comment that not every replacement of It is only if the new (Makes me wonder if we should consider somehow preventing the "old configuration API". In general it would be complicated, or potentially break some configurations. But perhaps limiting to the cases of
Depends how the If the If there is
I believe that would work. |
Thanks @thomreis, the following patch seems to work: diff --git a/DQM/Integration/python/clients/pixellumi_dqm_sourceclient-live_cfg.py b/DQM/Integration/python/clients/pixellumi_dqm_sourceclient-live_cfg.py
index 2e62f7a11c7..f76d76317cb 100644
--- a/DQM/Integration/python/clients/pixellumi_dqm_sourceclient-live_cfg.py
+++ b/DQM/Integration/python/clients/pixellumi_dqm_sourceclient-live_cfg.py
@@ -13,12 +13,10 @@ unitTest=False
if 'unitTest=True' in sys.argv:
unitTest=True
-process.MessageLogger = cms.Service("MessageLogger",
- debugModules = cms.untracked.vstring('siPixelDigis',
- 'sipixelEDAClient'),
- cout = cms.untracked.PSet(threshold = cms.untracked.string('ERROR')),
- destinations = cms.untracked.vstring('cout')
-)
+process.MessageLogger.debugModules = cms.untracked.vstring('siPixelDigis',
+ 'sipixelEDAClient')
+process.MessageLogger.cout = cms.untracked.PSet(threshold = cms.untracked.string('ERROR'))
+
#----------------------------
# Event Source
We will take a look at the other clients as well and make a PR for this. |
do you understand why the unit tests didn't catch the issue? |
This only happened for |
there are no specific tests for HI data, but I don't see how this is HI-specific (unless it's bundled with the cmssw |
I see. I only mentioned it because that was how the error was discovered, but I didn't really dig into it. It will take a bit of looking into. |
commit b3af544009d63199380a09ebedeb8f2a9d77631f Merge: 0590269edca 93f14ae8b3f Author: Spizor <[email protected]> Date: Thu Feb 8 15:46:29 2024 +0100 Merge branch 'cms-sw:master' into mtd_sigmatof_1400pre3 commit 93f14ae8b3fa6fb1cf1a14c73f651f6b01d17340 Merge: ae2ba49869a b1e5fc7cba1 Author: cmsbuild <[email protected]> Date: Wed Feb 7 20:16:57 2024 +0100 Merge pull request #43799 from aloeliger/CICADAPatternTestUpdateFix Update CICADA emulator templates and update model version to pattern testing model commit ae2ba49869ab0ee42403d10704f6fbf7e07805c4 Merge: 4bae2d88386 03e79c973ba Author: cmsbuild <[email protected]> Date: Wed Feb 7 20:14:39 2024 +0100 Merge pull request #43825 from makortel/patch-6 Declare InvariantMassError as transient data product commit 4bae2d88386f0e8f2a4ae9dd8c3922cdd6c85e56 Merge: b566e6fd55b 0a5ad0cf175 Author: cmsbuild <[email protected]> Date: Wed Feb 7 20:13:19 2024 +0100 Merge pull request #43826 from makortel/asanL1GTScales Remove unnecessary import of L1GTScales commit b566e6fd55b904e405b459fcf05f806f4aca9b21 Merge: e1c1306a8ba bc0f5783239 Author: cmsbuild <[email protected]> Date: Wed Feb 7 20:09:46 2024 +0100 Merge pull request #43841 from bsunanda/Phase2-hgx352B Phase2-hgx352B Add an example of CMS scenario with only HGCal detector commit e1c1306a8ba034a5cd200b1889249b75c27ccb49 Merge: d2a97ab070c 064a960ca9e Author: cmsbuild <[email protected]> Date: Wed Feb 7 20:08:33 2024 +0100 Merge pull request #43805 from fabiocos/fc-geomD107 Geometry: add Phase2 scenarios D107 = T32+C17+M11+I17+O9+F8 and D108 = T35+C19+M11+I17+O9+F8 commit d2a97ab070cb9fdcda4a592f558a35c9d5fff8a0 Merge: 615d2c4a828 a5ab7b1b80d Author: cmsbuild <[email protected]> Date: Wed Feb 7 16:42:13 2024 +0100 Merge pull request #43834 from smuzaffar/root6-RNTupleModel-fix ROOT6 changes needed for RNTupleModel commit 615d2c4a828ea1a81b68b633e9f7921ae65db6d9 Merge: 585c2ea6cba 5a672dbec4b Author: cmsbuild <[email protected]> Date: Wed Feb 7 16:41:23 2024 +0100 Merge pull request #43798 from brusale/hgcalvalidator_bugfix Fix purity and duplicate calculation in HGCal validation commit 585c2ea6cbae4c1efaab08b8d6a3d5fb35aabf0c Merge: bbecf310e3b 7e660b78c69 Author: cmsbuild <[email protected]> Date: Wed Feb 7 16:41:13 2024 +0100 Merge pull request #43818 from wddgit/legacyCleanupDaq Delete last daq legacy type module commit bbecf310e3b6d042002f13f8a287a5127ab3d34d Merge: 892eed36ce8 ba5c296e89d Author: cmsbuild <[email protected]> Date: Wed Feb 7 16:41:03 2024 +0100 Merge pull request #43855 from hsert/tauHLTPhase2_devel Fix Phase2 ditau HLT path (with DeepTau Isolation) commit 0590269edca42ac83f2a271238e696a5250789df Author: noepalm <[email protected]> Date: Wed Feb 7 16:40:42 2024 +0100 Code checks && format (#2) commit 892eed36ce840282151a85350f786a62ffd85bf4 Merge: 483c0c4bb40 fae6c47c0ea Author: cmsbuild <[email protected]> Date: Wed Feb 7 16:40:17 2024 +0100 Merge pull request #43869 from aloeliger/lowPtMuonFixEventContent Add low pt muon fix objects into phase 2 L1 event content. commit 483c0c4bb40d43a51eebf53d84d6a2c6a25c7d9b Merge: 4583435314b 2aac60985c7 Author: cmsbuild <[email protected]> Date: Wed Feb 7 16:39:05 2024 +0100 Merge pull request #43876 from bsunanda/Run3-gex175 Run3-gex175 Try to have the 2024 version of GE21 commit 4583435314bce865d9e7744f00d6969dcd4e1584 Merge: 56b94a34d97 2abf4288048 Author: cmsbuild <[email protected]> Date: Wed Feb 7 16:38:46 2024 +0100 Merge pull request #43873 from arsahasransu/Scouting2024EGFill_fBramVal_from1400pre3 Implement the GSF Track fBrem Variable Filling for Scouting Electrons: 14_1 commit 56b94a34d97801dd25bd3ea045fa1a11c092a5d4 Merge: f9c88f3a6c5 0cea3354d48 Author: cmsbuild <[email protected]> Date: Wed Feb 7 16:38:04 2024 +0100 Merge pull request #43870 from mmusich/mm_dev_misc_improv_forPhase2 miscellaneous updates to improve validation of phase-2 Tracker Alignment samples commit f9c88f3a6c5e9a9f0be818d7e138cb3c3dcf1ea9 Merge: 2026eac70cd 5a55dd7f2a7 Author: cmsbuild <[email protected]> Date: Wed Feb 7 16:37:41 2024 +0100 Merge pull request #43865 from mmusich/mm_dev_add_test_OnlineVsDevTablesConsistency HLT development: add unit test for online vs dev tables consistency commit 2026eac70cd435e947edf1e500e3a12490170e68 Merge: 3467e953c57 175abbad1a9 Author: cmsbuild <[email protected]> Date: Wed Feb 7 16:36:56 2024 +0100 Merge pull request #43859 from mmusich/mm_dev_fix_phase2_alcareco_muon_selection add phase2 customizations to `TkAlMuonSelectors` to increase selection efficiency commit 3467e953c57c68bcd8116d64244bcf99cddcfa18 Merge: cbdc156e468 98d056017f5 Author: cmsbuild <[email protected]> Date: Wed Feb 7 16:36:10 2024 +0100 Merge pull request #43856 from mmusich/mm_dev_update_TestRun3ScoutingFormats Update `TestRun3ScoutingFormats.sh` for CMSSW_14_0_0_pre3 Scouting DataFormat updates commit cbdc156e46835f2f531434c0d973582df10afdab Merge: 0f181f1408d 4c61faf0564 Author: cmsbuild <[email protected]> Date: Wed Feb 7 16:34:04 2024 +0100 Merge pull request #43821 from gpetruc/linpuppi_rewrite_cmsswmaster Phase-2 L1T Correlator: Rewrite linpuppi emulator with ap_fixed commit 0f181f1408d07694538eaff61896d0d468a95356 Merge: 8d63782a4b9 2fe74705b4a Author: cmsbuild <[email protected]> Date: Wed Feb 7 16:33:44 2024 +0100 Merge pull request #41928 from ericcano/SoA_range_checking SoA range checking: adds inter operability between range checked and non range checked commit 8d63782a4b90419840c7112d57d8eb3f254442c6 Merge: a893c4cea26 522895b299d Author: cmsbuild <[email protected]> Date: Wed Feb 7 16:18:23 2024 +0100 Merge pull request #43874 from mmusich/mm_dev_fix_ASAN_X_DAClusterizerInZ fix `DAClusterizerInZ_vect` for ASAN_X build commit f68c35b94f4165ccb5827e8bec7a7d2fc3716866 Author: noepalm <[email protected]> Date: Wed Feb 7 15:57:59 2024 +0100 Removed debug ifdef condition on print to match previous implementation commit 03d837d6477b4ea8d94c78383442e60e05cd304d Author: noepalm <[email protected]> Date: Wed Feb 7 15:54:41 2024 +0100 Removed useless comments, files + fixed input file path for standalone MTD validation cfg file commit 3a154f9e796e08093f2b44911a42b03709cb3b88 Author: noepalm <[email protected]> Date: Wed Feb 7 14:41:57 2024 +0100 Code checks && code format commit a893c4cea26b7b67c021548f30ef19429c1eab77 Merge: 70c7fb8ed2f 016eb7d6144 Author: cmsbuild <[email protected]> Date: Tue Feb 6 18:03:08 2024 +0100 Merge pull request #43867 from cms-tsg-storm/HLTdevelopment133X_for140X HLT menu development for `13_3_X` (3/N) [`14_1_X`] commit 98d056017f541a7420b08033f5a5aea7499c63f5 Author: mmusich <[email protected]> Date: Sat Feb 3 15:58:45 2024 +0100 Update TestRun3ScoutingFormats.sh for CMSSW_14_0_0_pre3 updates: - Run3ScoutingElectron (version 7) - Run3ScoutingPhoton (version 6) - Run3ScoutingVertex (version 4) commit 2fe74705b4ab9590824299e11c39a08a1bb7a823 Author: Eric Cano <[email protected]> Date: Tue Jun 13 15:01:02 2023 +0200 Document the CMS_SOA_BYTE_SIZE_TYPE macro Explain that using a typedef as a template parameter causes the ROOT dicionary generation to fail. commit 1f4e998e835b6c0003cb24681c6ab7c62d5eca34 Author: Eric Cano <[email protected]> Date: Tue Jun 13 14:26:01 2023 +0200 Adds complete tests for range checking view, both layout and view initialized. commit 9d89dbd27a5215803b9373ce408deeea26584677 Author: Eric Cano <[email protected]> Date: Fri Jun 9 18:22:36 2023 +0200 Fix SoA range checking tests Positivty tests were missing as the indices are of a signed type (for ROOT compatibility). commit 4b8f023248f4e466dc77084e55012897f466025d Author: Eric Cano <[email protected]> Date: Fri Jun 9 17:58:35 2023 +0200 Adds intercompatibility between view with and without range checking. This change allows providing a range checked to the code, presumably to debug without changing the PortableCollections (which always provide non-range checking views). Range and non-range checking variants can be contructed from one another. commit 2aac60985c79027aa90c3e04995ef9617be9a5f9 Author: Sunanda <[email protected]> Date: Tue Feb 6 12:24:25 2024 +0100 Try to have the 2024 version of GE21 commit 2abf428804812b03cbbbb88be51196d4ebc0da54 Author: A.R.Sahasransu <[email protected]> Date: Mon Feb 5 17:04:34 2024 +0100 Properly implement the fBrem parameter filling for scouting electrons commit b792c602b30b0d158093855d755ef95b9301ebda Author: noepalm <[email protected]> Date: Tue Feb 6 09:56:49 2024 +0100 Changed SigmaTof fill location in validation commit 522895b299d55b23921699f26141bb2a3e34362a Author: mmusich <[email protected]> Date: Tue Feb 6 07:40:54 2024 +0100 fix DAClusterizerInZ_vect for ASAN_X build commit 745534060872888517cc4a3bb554c92d24281c43 Author: noepalm <[email protected]> Date: Mon Feb 5 18:11:27 2024 +0100 Change input file to validation commit 1afb957ee2a22d2dd578f5385d703aaf5ceb7120 Author: noepalm <[email protected]> Date: Mon Feb 5 18:07:19 2024 +0100 Saving sigmaTOF in ps commit 064a960ca9eaa558078b99aa6ace0e4bd752d628 Author: Fabio Cossutti <[email protected]> Date: Mon Feb 5 17:54:02 2024 +0100 Add scenario D108 = T35+C19+M11+I17+O9+F8 commit 18459c947967119ddf9de464bacafce6f514297f Author: Fabio Cossutti <[email protected]> Date: Mon Jan 29 11:48:32 2024 +0100 Add geometry scenario D107=T32+C17+M11+I17+O9+F8 commit 0cea3354d4853d2c0be42bdacd544cb5613f1d09 Author: mmusich <[email protected]> Date: Mon Feb 5 16:26:30 2024 +0100 miscellaneous updates to improve validation of phase-2 alcareco samples commit fae6c47c0ea20cb689c111e9317ed457a4d3fc4b Author: Andrew Loeliger <[email protected]> Date: Mon Feb 5 08:42:17 2024 -0600 Add low pt muon fix objects into phase 2 L1 event content. commit bc69f2b1424c8de013ed351bd37bbf233a5f4ec6 Author: noepalm <[email protected]> Date: Mon Feb 5 15:32:11 2024 +0100 Removed useless prints + created member vector in TrackSegments to allocate memory for sigmaTof once commit 016eb7d61445ef65f1fd1f89759cae0849876b65 Author: mmusich <[email protected]> Date: Fri Feb 2 20:38:10 2024 +0100 HLT menu development for 13_3_X (branch: 14_0_X) This is an intermediate update towards the 2024 proton-proton run data-taking. This update includes the integration of the following JIRA tickets: - [CMSHLT-2993](https://its.cern.ch/jira/browse/CMSHLT-2993) [MUO]: HLT path for High-pT muons seeded by the L1 Muon Shower Trigger commit 70c7fb8ed2ff22abb8a635c438fa7dd2313ebb3b Merge: f9209fcdb88 f8fff0ac071 Author: cmsbuild <[email protected]> Date: Mon Feb 5 13:02:52 2024 +0100 Merge pull request #43822 from RSalvatico/FixPhase2HLTHCALThresh Make default Phase2 HLT thresholds from config file the same as in Run3 commit f9209fcdb88c857552308caf1fce9229ac1d8388 Merge: 8b51267e413 bb5a3f648f3 Author: cmsbuild <[email protected]> Date: Mon Feb 5 12:59:36 2024 +0100 Merge pull request #43860 from michael-pitt/UpdateLHCInfoPlotter extend histograms to the Run3 range in CTPPSLHCInfoPlotter commit 8b51267e41333cf8786ee4026857ef0c921439ff Merge: 4bcdafb40d4 92691c0a286 Author: cmsbuild <[email protected]> Date: Mon Feb 5 12:58:06 2024 +0100 Merge pull request #43844 from bsunanda/Run3-Sim154 Run3-Sim154 Try to avoid memory leak issues in SimG4Core/PrintGeomeInfo and Geometry/TrackerCommonData commit 4bcdafb40d4712396770034a3c6770840979b82d Merge: ac33e94a389 c03da0e48c7 Author: cmsbuild <[email protected]> Date: Mon Feb 5 12:44:39 2024 +0100 Merge pull request #43828 from makortel/fixScoutingSchemaEvolution Fix NanoAOD workflow reading 12_4_X file commit ac33e94a389cc171d175f1dfd98deb2729abb301 Merge: f2ffd7b3c9b ed627fef99f Author: cmsbuild <[email protected]> Date: Mon Feb 5 12:32:26 2024 +0100 Merge pull request #43862 from bsunanda/Phase2-hgx352C Phase2-hgx352C Fix the unit test in Configuration/Geometry commit 5a55dd7f2a7b651e97525b2559b70af6f92d7764 Author: mmusich <[email protected]> Date: Mon Feb 5 10:57:19 2024 +0100 add script to check consistency of online tables with respect to development tables and implement unit test commit 1c955d717f9f77696c7bc70375ada3b58862a5d8 Author: mmusich <[email protected]> Date: Mon Feb 5 10:56:15 2024 +0100 fix mistake in integration of CMSHLT-3019 commit ba5c296e89dc1ab1dd1dfc8e3d4f233fff693518 Author: hsert <[email protected]> Date: Sat Feb 3 10:03:00 2024 +0100 tauPhase2HLT: fix for DeepTau Phase2 Training commit ed627fef99f31561104b468385c3ba412d9dc815 Author: Sunanda <[email protected]> Date: Sun Feb 4 07:31:10 2024 +0100 Fix the unit test in Configuration/Geometry commit bb5a3f648f3d20086d90b2a0ac5a89deecbf8ac1 Author: Michael Pitt <[email protected]> Date: Sat Feb 3 19:00:19 2024 +0100 extend histograms to the Run3 range commit 175abbad1a9584d0e630e06c1dee648d451f39a2 Author: mmusich <[email protected]> Date: Sat Feb 3 16:21:21 2024 +0100 add phase2 customizations to TkAlMuonSelectors to increase selection efficiency commit f2ffd7b3c9b926a2db457de7749d4fca2183ba53 Merge: 8086b4119b9 0084c011159 Author: cmsbuild <[email protected]> Date: Sat Feb 3 15:37:02 2024 +0100 Merge pull request #43769 from bsunanda/Phase2-hgx352A Phase2 hgx352A: Add possibilities of more scenarios in some of the checks of G4 Components commit 8086b4119b937dfa9d4fe6218ce18e01b84bd2ba Merge: 11675c3b571 0a7e228ce75 Author: cmsbuild <[email protected]> Date: Sat Feb 3 15:36:10 2024 +0100 Merge pull request #43850 from smorovic/mst-fix-autofs-mount [14_0_X][DAQ] DaqDirector fixes and cleanup, and removal of EvFOutputModule commit 92691c0a28668d55140df1da5e54c59987a2efdc Author: Sunanda <[email protected]> Date: Sat Feb 3 13:15:22 2024 +0100 Take care of Vladimir's comments commit 0a7e228ce75451fc638507cae82340782b31272a Author: Srecko <[email protected]> Date: Fri Feb 2 16:17:54 2024 +0100 - remove EvFOutputModule which was replaced by GlobalEvFOutputModule - clean up unused functionality of EvFDaqDirector (reading PSets from the menu which was never used) commit 11675c3b5710fd1a986b3ad7abe3b95ee38fb1fe Merge: a73dfd9c683 e0a4f5f26b9 Author: cmsbuild <[email protected]> Date: Fri Feb 2 15:26:11 2024 +0100 Merge pull request #43835 from wddgit/removeConvertToStream Remove edmConvertToStreamModule.py, it's no longer needed commit a73dfd9c683b26f756f52cb5369ee35578e09723 Merge: 30569f21a5e 2cd429add6a Author: cmsbuild <[email protected]> Date: Fri Feb 2 15:26:04 2024 +0100 Merge pull request #43833 from wddgit/legacyCleanupAnalysis Delete last analysis legacy type modules commit 30569f21a5ea15bcc51d4685b5ee2aa29175188c Merge: 405dbfc19c6 c9ced900543 Author: cmsbuild <[email protected]> Date: Fri Feb 2 15:24:54 2024 +0100 Merge pull request #43832 from wddgit/legacyCleanupL1 Delete last L1 legacy type module commit 405dbfc19c62016a9a628900a2226db55147de04 Merge: 408ee076a00 a73ce693381 Author: cmsbuild <[email protected]> Date: Fri Feb 2 15:24:37 2024 +0100 Merge pull request #43829 from wddgit/geometryLegacyMigration Migrate last geometry legacy type module commit 408ee076a00158c95d752ad31b16dd07f4d65777 Merge: 87c110d3705 ab3603491d5 Author: cmsbuild <[email protected]> Date: Fri Feb 2 15:24:23 2024 +0100 Merge pull request #43827 from mmusich/mm_fix_refresh_Geant4e_example_cfg update input file for `testG4Refitter` to avoid backward compatibility issue due to not storing `TStreamerInfo` commit 87c110d3705f2802315555d40870115ccdce5599 Merge: 7cc0abaaf9c 8867793d94f Author: cmsbuild <[email protected]> Date: Fri Feb 2 15:23:37 2024 +0100 Merge pull request #43813 from denizsun/my-new-feature SkipEvent is removed [issue#43793] commit 7cc0abaaf9c5400471b4e9ffcac6a9adbbda727d Merge: 481acd025cc d8ad9468e82 Author: cmsbuild <[email protected]> Date: Fri Feb 2 15:23:18 2024 +0100 Merge pull request #43795 from thomreis/cc-timing-config-for-rechits ECAL - Set correct CC tag labels for ECAL RecHit producer commit 481acd025cc2895cf9330147c84ff1e3fea950c9 Merge: 9547b42986a d5058b111ca Author: cmsbuild <[email protected]> Date: Fri Feb 2 15:22:58 2024 +0100 Merge pull request #43791 from quinnanm/axol1tl_emulator_v3pr AXOL1TL change to v3 of model commit 9547b42986aae2b875082a10b5a10d7e9bb83a64 Merge: 695ed785620 fb08b71f633 Author: cmsbuild <[email protected]> Date: Fri Feb 2 15:11:48 2024 +0100 Merge pull request #43842 from cms-tsg-storm/HLTdevelopment133X_for140X HLT development for 13_3 2/N [14_0_X] commit 8cd1c8e7764105eda8cd2d5cbade2651fb36efea Author: Srecko <[email protected]> Date: Wed Nov 22 21:37:42 2023 +0100 fix autofs mount (mkdir could fail first time) commit fb08b71f6338c3dd0488548c781f1ee9afd1f5ab Author: Martin Grunewald <[email protected]> Date: Fri Feb 2 11:11:25 2024 +0100 Cleanup of ../tables and adding OnlineCosmics files commit ad7a95582dec14d51d6bfda7636bd2f9fff2c3ba Author: Sunanda <[email protected]> Date: Fri Feb 2 11:03:33 2024 +0100 Code check commit 6f280e481f131e9a58a9599b957fd3b46e850936 Author: Sunanda <[email protected]> Date: Fri Feb 2 10:46:04 2024 +0100 Try to avoid memory leak issues in SimG4Core/PrintGeomeInfo and Geometry/TrackerCommonData commit 9b5e25fb9e1e6e25074134b1c62e5f187d9a4342 Author: Martin Grunewald <[email protected]> Date: Fri Feb 2 09:59:30 2024 +0100 Cleanup of ../tables and adding OnlineCosmics files commit 49c868918c0a1f1b8004c0630c1a37d638c4f8c3 Author: Martin Grunewald <[email protected]> Date: Fri Feb 2 09:14:12 2024 +0100 Cleanup of ../tables and adding OnlineCosmics files commit c4dce24f4435736a44cf3bd68204efe293c331af Author: Martin Grunewald <[email protected]> Date: Fri Feb 2 09:10:03 2024 +0100 Cleanup of ../tables and adding OnlineCosmics files commit bc0f57832390bc79319ac0ce0c712c53840f41d4 Author: Sunanda <[email protected]> Date: Fri Feb 2 07:26:28 2024 +0100 Add an example of CMS scenario with only HGCal detector commit fbc19bb64482b602c862c6712ad7be65feb920ae Author: Martin Grunewald <[email protected]> Date: Thu Feb 1 16:59:14 2024 +0100 Integration of CMSHLT-3019 CMSHLT-2976 CMSHLT-2974 commit e0a4f5f26b9a850f434fb32828ab2c2701b7a25c Author: W. David Dagenhart <[email protected]> Date: Thu Feb 1 16:13:57 2024 +0100 Remove edmConvertToStreamModule.py, it's no longer needed commit a5ab7b1b80d53f5bd5409d871e5d2b5f922b7eb9 Author: Malik Shahzad Muzaffar <[email protected]> Date: Thu Feb 1 14:57:14 2024 +0100 code formatting commit 375bc4cd10f0de0ad7a6d10fc76339647c5a0cc8 Author: Shahzad Malik Muzaffar <[email protected]> Date: Thu Feb 1 14:37:46 2024 +0100 ROOT6 changes needed for RNTupleModel commit 2cd429add6ad63e3c4836a6aaf0c368d84841ccc Author: W. David Dagenhart <[email protected]> Date: Wed Jan 31 23:53:04 2024 +0100 Delete last analysis legacy type modules commit c9ced9005435af28f4daaa9caf352657407caf2b Author: W. David Dagenhart <[email protected]> Date: Wed Jan 31 22:09:55 2024 +0100 Delete last L1 legacy type module commit c03da0e48c76e93456abef430add72e7b414502f Author: Matti Kortelainen <[email protected]> Date: Wed Jan 31 17:51:07 2024 +0100 Fix NanoAOD workflow reading 12_4_X file The input file contains Scouting data formats, whose evolution causes read failure because of TStreamerInfo being missing from the file because of a ROOT bug at the time. commit a73ce693381d322796eeeedc434f51957d3bcf7f Author: W. David Dagenhart <[email protected]> Date: Wed Jan 31 18:28:45 2024 +0100 Migrate last geometry legacy type module commit ab3603491d5c40b9c2bacad6305712499b0a3a62 Author: mmusich <[email protected]> Date: Wed Jan 31 17:51:40 2024 +0100 update input file for testG4Refitter to avoid bug with bug in not storing TStreamerInfo commit 0a5ad0cf1751f1b3cbfaf35e175e15adf17fd587 Author: Matti Kortelainen <[email protected]> Date: Wed Jan 31 16:47:27 2024 +0100 Remove unnecessary import of L1GTScales This import caused the libL1TriggerPhase2L1GT.so to load, which caused ASAN to report ---- ASan runtime does not come first in initial library list; you should either link runtime to your application or manually preload it with LD_PRELOAD. ---- commit 03e79c973baaacce1bda8c407f9b179d6cbebb16 Author: Matti Kortelainen <[email protected]> Date: Wed Jan 31 09:41:21 2024 -0600 Declare InvariantMassError as transient data product Data products defined in non-DataFormat packages must be transient. commit 695ed7856207edf9efdcd61781836d2d1ba8140d Merge: b097b2ad6ac ef6ee2e44d1 Author: cmsbuild <[email protected]> Date: Wed Jan 31 15:28:41 2024 +0100 Merge pull request #43817 from wddgit/legacyCleanupSim Delete last simulation legacy type module commit b097b2ad6ac1c97755cd09c6bae5f23d147e26f2 Merge: e5181eeb940 5ab8cd95ece Author: cmsbuild <[email protected]> Date: Wed Jan 31 15:27:53 2024 +0100 Merge pull request #43820 from fwyzard/fix_loop_in_vertexFinder_splitVertices Fix loop in vertexFinder::splitVertices(acc, ...) commit e5181eeb940069024f8c072eeea946f5cd7d2cd4 Merge: 2e8c6127501 f238641bf26 Author: cmsbuild <[email protected]> Date: Wed Jan 31 15:27:46 2024 +0100 Merge pull request #43819 from mmusich/mm_fix_EgammaHLTHcalVarProducerFromRecHit `EgammaHLTHcalVarProducerFromRecHit`: fix `HcalPFCuts` consumes pattern commit d8ad9468e8295c9d4324f367845552410fbe63f1 Author: Thomas Reis <[email protected]> Date: Wed Jan 31 11:39:22 2024 +0100 Update ecalRecHit config in ecalcalib sourceclient. commit f8fff0ac071969a927c024ccdc2fc7f9d8ed8758 Author: rselvati <[email protected]> Date: Wed Jan 31 11:17:33 2024 +0100 make Phase2 HLT thresholds in config the same as in Run3 commit 4c61faf05643719ad72a5d577ac76e609e762827 Author: Giovanni <[email protected]> Date: Thu Jan 11 15:46:46 2024 +0100 Rewrite linpuppi emulator with ap_fixed commit 5ab8cd95ece47e951cec1273a8cbc2e7aa08df41 Author: Andrea Bocci <[email protected]> Date: Wed Jan 31 08:32:55 2024 +0100 Fix loop in vertexFinder::splitVertices(acc, ...) commit f238641bf26ea24f186195a80b980255b60d6425 Author: mmusich <[email protected]> Date: Wed Jan 31 05:29:05 2024 +0100 EgammaHLTHcalVarProducerFromRecHit: fix HcalPFCuts consumes pattern commit 7e660b78c69a59cb6f69c588e1ca5be2acca62f0 Author: W. David Dagenhart <[email protected]> Date: Tue Jan 30 23:48:17 2024 +0100 Delete last daq legacy type module commit ef6ee2e44d1be277b7448379d8ad612cda99c134 Author: W. David Dagenhart <[email protected]> Date: Tue Jan 30 23:16:58 2024 +0100 Delete last simulation legacy type module commit 2e8c6127501826db7df9892a699a0710590ed081 Merge: ff42400ab22 c4261244674 Author: cmsbuild <[email protected]> Date: Tue Jan 30 21:15:58 2024 +0100 Merge pull request #43294 from PixelTracksAlpaka/alpaka_port_configs Pixel Alpaka Migration: Configs and Fixes [VII] commit ff42400ab2230d4a6c0469e64cf06d4888995ec1 Merge: 4a8d8c41adb c01d6291efa Author: cmsbuild <[email protected]> Date: Tue Jan 30 16:49:11 2024 +0100 Merge pull request #43792 from mmusich/silenceCPPwarnings silence CPP20 warnings about `maybe-uninitialized` variables in `momentumBiasValidation.C` commit 4a8d8c41adbc05dac188d5a83a91af176a89e5a6 Merge: 6535a605165 e3e5c3ed603 Author: cmsbuild <[email protected]> Date: Tue Jan 30 16:44:41 2024 +0100 Merge pull request #43592 from kdeleo/revised-primaryvertexproducer_1400pre1_PR_151223 Vertex reconstruction: code re-organization + vertex time computation commit 6535a605165e58b3408bfa6d9c96edfc6a813732 Merge: 8ab99f328aa 8665f3dfb6c Author: cmsbuild <[email protected]> Date: Tue Jan 30 16:42:59 2024 +0100 Merge pull request #43645 from missirol/devel_HIDQM use `HIDQM*` streams in online-DQM clients if `runType==hi_run` commit 8ab99f328aa87e28ed147fb58726000207a7257e Merge: cd3bb3b5a25 5edfefea2e3 Author: cmsbuild <[email protected]> Date: Tue Jan 30 16:42:46 2024 +0100 Merge pull request #43696 from kpedro88/TritonModelVersioning Triton model versioning commit cd3bb3b5a25bff7b53daf02fe9c6af26d38e964e Merge: d23804cf8f4 7095b74d329 Author: cmsbuild <[email protected]> Date: Tue Jan 30 16:41:29 2024 +0100 Merge pull request #43778 from iarspider/followup-43771 Replace C-style arrays with std::arrays (follow-up on #43771) commit d23804cf8f4d95fbcb03c20aa1aecfa1e6891085 Merge: aaa7d7cb82c 7383224d24e Author: cmsbuild <[email protected]> Date: Tue Jan 30 16:41:08 2024 +0100 Merge pull request #43779 from wddgit/disableGetFedFromOmdsOption Disable the getFedsFromOmds configuration option in L1RCTProducer commit aaa7d7cb82c24cf4cd7cb130e0d3f9e8a70a07c9 Merge: b6067b1e31b 274e9357df9 Author: cmsbuild <[email protected]> Date: Tue Jan 30 16:40:55 2024 +0100 Merge pull request #43785 from hgc-tpg/hgc-tpg-integration-240125 [HGCAL trigger] Update validation histograms commit b6067b1e31bf342fe1791663701b1d527410380d Merge: 03bf15a8290 40e8ce4871c Author: cmsbuild <[email protected]> Date: Tue Jan 30 16:38:43 2024 +0100 Merge pull request #43804 from iarspider/alpaka_std_shuffle_2 Remove uses of deprecated std::random_shuffle commit 03bf15a8290ac9267a204a93ed552f6f16e74fb0 Merge: 27929542807 737a1d92dcb Author: cmsbuild <[email protected]> Date: Tue Jan 30 16:38:29 2024 +0100 Merge pull request #43808 from youyingli/CMSSW_14_0_X_skimUpdateV1 Update skim configs for full ReReco 2022/2023 commit 279295428077c6a289c9b97523d05d8093e4a68e Merge: 7f686abe3b3 5a9f2570a6e Author: cmsbuild <[email protected]> Date: Tue Jan 30 16:37:51 2024 +0100 Merge pull request #43811 from ericcano/prefixScanWarpPadding Ensures that warp level primitives are called from full warps in prefixScan. commit 7f686abe3b3400c028778edf85de71d5cfc926d1 Merge: 21073b8795b 2b3c8d25995 Author: cmsbuild <[email protected]> Date: Tue Jan 30 15:55:20 2024 +0100 Merge pull request #43760 from bsunanda/Phase2-hgx352 Phase2-hgx352 Modify the scenarios D104, D105 to accommodate modified T35 and I17 (also go back to C17 for D105). Add a new scenario D106 with C23 (same as C22 but without cell definition in Geant4) commit 21073b8795b016c62a04d054615be72e4646017a Merge: 962439553ed 3dab6f457dd Author: cmsbuild <[email protected]> Date: Tue Jan 30 15:49:48 2024 +0100 Merge pull request #43794 from mmusich/mm_dev_addHGCombined_dropBoxMetadata add necessary changes to run the uploads of the Combined High Granularity SiPixel alignment in the PCL commit 962439553edfe1ccd9c1ee43f512f72cb62bc9d6 Merge: 4993ed59221 8962c200f2d Author: cmsbuild <[email protected]> Date: Tue Jan 30 15:47:58 2024 +0100 Merge pull request #43758 from mmasciov/scoutingVertexCov Add non-diagonal errors to scouting vertices commit 4993ed592215ca392a41568d8f4335800cc96a60 Merge: daad3347a2a 128b8059bc6 Author: cmsbuild <[email protected]> Date: Tue Jan 30 15:46:59 2024 +0100 Merge pull request #43788 from cms-tsg-storm/HLTdevelopment133X_for140X HLT menu development for `13_3_X` (1/N) [`14_0_X`] commit 5a9f2570a6e76839b7d02676ca1b6c919b1993b9 Author: Eric Cano <[email protected]> Date: Tue Jan 30 11:26:14 2024 +0100 Ensures that warp level primitives are called from full warps. This ensures compatibility with alpaka 1.1 and all GPU architecture where warp level primitives have undefined behavior if called from incomplete warps (in practice, the kernel hangs). Co-authored-by: Andrea Bocci <[email protected]> commit c42612446745607daeebbbd5febf117800de5b03 Author: adriano <[email protected]> Date: Tue Jan 30 11:01:29 2024 +0100 Adding Alpaka DQM to HLT commit c45975ba12ea193f5bfc7e7c1c45276fbc4538bb Author: adriano <[email protected]> Date: Mon Jan 29 16:43:34 2024 +0100 Fixes for CPU proper execution and HLT customizer commit 341c4c88d7a5531fea834b9dbe73a849b6226f84 Author: Andrea Bocci <[email protected]> Date: Mon Jan 29 19:12:32 2024 +0100 Fix dictionaries of TrackSoA data formats commit cd911723ec6f0e43bca57d5bf202e4151d1188d0 Author: Andrea Bocci <[email protected]> Date: Mon Jan 29 18:54:04 2024 +0100 Fix the range in TestFillKernel commit edca94ea2e3a961b4c320626de4f447765e1ddb6 Author: Andrea Bocci <[email protected]> Date: Mon Jan 29 18:52:51 2024 +0100 Move TrackSoA helper functions from the TracksUtilities struct to the reco namespace commit c33db5c6e825bd7b60ce9902e9cc2534943914a2 Author: Andrea Bocci <[email protected]> Date: Fri Jan 26 17:46:21 2024 +0100 Fix the Alpaka validation sequences to use the makeSerialClone function commit 376d02c1089daffbf2f7298a01b6dfdcd0c821f3 Author: Andrea Bocci <[email protected]> Date: Sat Jan 27 13:06:06 2024 +0100 Implement the makeSerialClone function If `module` is an alpaka-based module, `makeSerialClone(module, **args)` will make a copy of `module`, apply the changes in `**args`, and force the copy to run using the "serial_sync" CPU backend. commit fe57dc18540c8ced72c65f66f70d3f493392b42b Author: Adriano Di Florio <[email protected]> Date: Fri Jan 26 17:45:37 2024 +0100 Fix Alpaka pixel clustering on CPU commit 88871666d75ae05ca62be24f96ae3b4f3b64c8c7 Author: Andrea Bocci <[email protected]> Date: Fri Jan 26 17:11:02 2024 +0100 Ensure than GPU_DEBUG is not #defined commit f6c1a6a495632393e4b3778c59945db999510e7b Author: Adriano Di Florio <[email protected]> Date: Wed Nov 15 18:59:33 2023 +0100 Implement the Alpaka pixel reconstruction workflows Co-authored-by: Andrea Bocci <[email protected]> Co-authored-by: Breno Orzari <[email protected]> Co-authored-by: Dimitris Papagiannis <[email protected]> commit 737a1d92dcb71b604c99182aa19fc5b195aef445 Author: Youying <[email protected]> Date: Mon Jan 29 18:38:32 2024 +0100 Update skim configs for ReReco2022/ReReco2023 commit daad3347a2a273da68705357c82765fe3c91f071 Merge: 16308d55b4d 66176a17266 Author: cmsbuild <[email protected]> Date: Mon Jan 29 18:06:59 2024 +0100 Merge pull request #41288 from PixelTracksAlpaka/alpaka_port_13_1_dqm Pixel Alpaka Migration: DQM [VI] commit 16308d55b4d51b85f249e7b8d721fad6f9563638 Merge: 4aa04be6a46 3f668a2e57d Author: cmsbuild <[email protected]> Date: Mon Jan 29 15:17:59 2024 +0100 Merge pull request #41287 from PixelTracksAlpaka/alpaka_port_13_1_vertex Pixel Alpaka Migration: Vertexing [V] commit 4aa04be6a46ed56a7a94f06ffd12fda63e448ff7 Merge: d0954a1f327 ddda404458c Author: cmsbuild <[email protected]> Date: Mon Jan 29 15:17:00 2024 +0100 Merge pull request #41286 from PixelTracksAlpaka/alpaka_port_13_1_track Pixel Alpaka Migration: Tracking [IV] commit b1e5fc7cba182b366e1f561d1c0175096e743b65 Author: Andrew Loeliger <[email protected]> Date: Mon Jan 29 06:04:27 2024 -0600 Fix mistyped CICADA model name commit 40e8ce4871c3f098ab96cf507b4c77b1f3088603 Author: Ivan Razumov <[email protected]> Date: Mon Jan 29 10:07:21 2024 +0100 Remove uses of deprecated std::random_shuffle commit 8665f3dfb6c84d2d1c22c81bc18682f72f5f3e15 Author: Marino Missiroli <[email protected]> Date: Fri Dec 29 16:44:40 2023 +0100 use "HIDQM*" streams in online-DQM clients if "runType==hi_run" commit d5058b111ca5bd1ade1b4ce340e1d6b4792c7053 Author: Melissa Quinnan <[email protected]> Date: Fri Jan 26 22:51:37 2024 +0100 edits added commit 5edfefea2e32aacc81f686e6c00338d283aeb764 Author: Kevin Pedro <[email protected]> Date: Fri Jan 26 14:46:03 2024 -0600 improve agent finding pattern commit 13361b9d729d34828ee36936b314c6e3fd549250 Author: Andrew Loeliger <[email protected]> Date: Fri Jan 26 10:02:06 2024 -0600 fix format commit 42124f85ce63f33d748d998b21b5498b9a714170 Author: Andrew Loeliger <[email protected]> Date: Fri Jan 26 09:31:53 2024 -0600 Update CICADA emulator templates and update model version to pattern testing model commit 3dab6f457dd87cc6a8e67b59b7322f4cded06c1f Author: mmusich <[email protected]> Date: Fri Jan 26 11:14:44 2024 +0100 add necessary changes to run the uploads of the Combined High Granularity SiPixel alignment in the PCL commit 4f4eb3bc014167e2ae82675e7c210dee3e785bfb Author: Thomas Reis <[email protected]> Date: Fri Jan 26 13:21:06 2024 +0100 Set correct CC tag labels for ECAL RecHit Producer. commit 8867793d94fe73a789adea8077b27397b40cdece Author: Deniz Sunar Cerci <[email protected]> Date: Fri Jan 26 15:57:29 2024 +0100 SkipEvent is removed commit d0954a1f327baf260e0c6e29c8b8adb214800359 Merge: 996029b4c8f dd2b6a332a3 Author: cmsbuild <[email protected]> Date: Fri Jan 26 15:35:59 2024 +0100 Merge pull request #43257 from thomreis/ecal-reco-gpu-alpaka-migration-multifit-integration-140x ECAL unpacker and ECAL multifit algorithm migration to alpaka commit 996029b4c8f76a930af1e610125d2f1d114a0dd0 Merge: 203834e3ae3 18a5acb98a5 Author: cmsbuild <[email protected]> Date: Fri Jan 26 15:33:15 2024 +0100 Merge pull request #41285 from PixelTracksAlpaka/alpaka_port_13_1_local Pixel Alpaka Migration: Local Reconstruction [III] commit 128b8059bc69d551fbee2bf9c2ae1ad6ffcc81b5 Author: mmusich <[email protected]> Date: Mon Nov 20 18:25:24 2023 +0100 Integrate "Special" FOG trigger paths for non-physics production menus and update table and testing scripts This update includes the integration of the following JIRA tickets: - [CMSHLT-2860](https://its.cern.ch/jira/browse/CMSHLT-2860) [TSG]: The FOG "Ubermenu" (merge of FOG's "special" menus) - [CMSHLT-2972](https://its.cern.ch/jira/browse/CMSHLT-2972) [TSG]: Circulating, Cosmics, CRUZET, MWGR -- port to 13_3_X commit e3e5c3ed60324c70b0f407820e10c6c5785863b3 Author: kdeleo <[email protected]> Date: Thu Jan 25 13:42:28 2024 +0100 Squashed commit of the following: commit 81b3967b018bad31b17524009c2c2324e507e754 Author: kdeleo <[email protected]> Date: Wed Jan 24 17:49:02 2024 +0100 const in TOFPIDProducer commit 6b63e89eb5b789dbfe3b19deb72d6d5688e705fb Author: kdeleo <[email protected]> Date: Tue Jan 23 17:35:59 2024 +0100 fix modifiers config in OfflinePrimaryVertices_cfi commit 294dd862f007b5308f652b99df839adf5ea4d0bf Author: kdeleo <[email protected]> Date: Tue Jan 23 14:28:11 2024 +0100 update configurations OfflineValidation and HI commit 4bdf453e854367db70043812f247f6c73308638b Author: kdeleo <[email protected]> Date: Mon Jan 22 17:31:22 2024 +0100 update config for phase2 commit 7a7f05fbc86adb0beed566560d813a69234f3c23 Author: Fabio Cossutti <[email protected]> Date: Sun Jan 21 18:52:18 2024 +0100 Remove duplication of PV configuration: use master fillDescription, remove TkClusParameters_cff, fix filters commit 66158208dd4b5850e28b4545f0be9a5d291cddca Author: kdeleo <[email protected]> Date: Wed Jan 17 15:18:49 2024 +0100 address Slava's comments commit 3fae2e1b566148db775af8791d49d8888999d5ff Author: kdeleo <[email protected]> Date: Tue Jan 9 17:41:11 2024 +0100 code style/format commit f0e6cba5896ffe5980777e13dd8eb868d95da1cd Author: kdeleo <[email protected]> Date: Mon Jan 8 16:21:35 2024 +0100 code update from werdmann to address comments on PR commit 7f8837d09fc53672bdd462463a98d6b0604b0389 Author: kdeleo <[email protected]> Date: Thu Dec 21 16:17:27 2023 +0100 move defaultInvalidTrackTimeReso const to TransientTrackBuilder header, fix verbosity PrimaryVertexProducer, minor style changes commit 537ba5e79943bb6e4aaa6316407fe244bf299a02 Author: kdeleo <[email protected]> Date: Tue Dec 19 17:16:07 2023 +0100 re-add HI parameters, fix const values, add missing headers commit cbb9c82c5729e212c7b1662fbb8b828baa094009 Author: kdeleo <[email protected]> Date: Mon Dec 18 17:20:51 2023 +0100 update primary vertex fitters + code-format commit 5b725f697ea8ecf9452224362c57fc27ccf3d85d Author: kdeleo <[email protected]> Date: Mon Nov 27 12:11:12 2023 +0100 RecoVertex & RecoMTD: remove first iteration of 4D and use 3D with timing, update tofPIDProducer, update 4D time calculation commit 1be46927e0635c8cda0fdf04a07ffe792b9019d9 Author: Wolfram Erdmann <[email protected]> Date: Wed Apr 5 18:34:07 2023 +0200 add missing vertex selection commit 28698660b97a2c59d7ac366d6baaf5f852886dcf Author: Marino Missiroli <[email protected]> Date: Wed Mar 29 21:07:22 2023 +0200 re-added PrimaryVertexProducerAlgorithm commit 75efeb36db62660a1c67ddd5de05838c150a707d Author: Wolfram Erdmann <[email protected]> Date: Thu Mar 30 09:05:31 2023 +0200 remove cputime measurement commit 14bd615af2f205ce92127ac9a2f869253236851e Author: Wolfram Erdmann <[email protected]> Date: Tue Mar 28 14:33:12 2023 +0200 reduce verbosity commit e5edf2a830182f35c54e090b829a3177d72cbc55 Author: Wolfram Erdmann <[email protected]> Date: Tue Mar 28 09:37:05 2023 +0200 remove obsolete include of DAClusterizerInz.h commit a7aebf79f47b2bd14181955c1f3f2ce556b875c9 Author: Wolfram Erdmann <[email protected]> Date: Tue Mar 28 09:05:28 2023 +0200 remove unnecessary class commit 34ee26d17c46cb8de505a54f7ba6fad8658b98fb Author: Wolfram Erdmann <[email protected]> Date: Tue Mar 28 09:03:54 2023 +0200 get back accidentally overwritten configs from 13_1_0_pre1 commit 1a9d7ff95e39013e70bad378dc1a5c0cff52137e Author: Marino Missiroli <[email protected]> Date: Mon Mar 27 19:40:04 2023 +0200 add override keyword to ::vertices in derived classes (DAClusterizerInZT_vect, GapClusterizerInZ) commit d236ffe19244e60ba6f73f83d079066dfdb41301 Author: Marino Missiroli <[email protected]> Date: Mon Mar 27 19:10:34 2023 +0200 code-checks && code-format commit dff646d1a3e731b259a11e0864f31deed38ae5b9 Author: Marino Missiroli <[email protected]> Date: Mon Mar 27 18:56:31 2023 +0200 silence unused-variable warning (Zcutoff) commit 7ebb5efccf4e5c957c1eca34f530048e53c2fd7b Author: Marino Missiroli <[email protected]> Date: Mon Mar 27 18:24:27 2023 +0200 rebase of werdmann:revised-primaryvertexproducer on top of 13_1_0_pre1 Co-authored-by: Fabio Cossutti <[email protected]>\nRemove duplication of PV configuration: use master fillDescription, remove TkClusParameters_cff, fix filters Co-authored-by: Marino Missiroli <[email protected]>\nadd override keyword to ::vertices in derived classes (DAClusterizerInZT_vect, GapClusterizerInZ) Co-authored-by: Marino Missiroli <[email protected]>\ncode-checks && code-format Co-authored-by: Marino Missiroli <[email protected]>\nre-added PrimaryVertexProducerAlgorithm Co-authored-by: Marino Missiroli <[email protected]>\nrebase of werdmann:revised-primaryvertexproducer on top of 13_1_0_pre1 Co-authored-by: Marino Missiroli <[email protected]>\nsilence unused-variable warning (Zcutoff) Co-authored-by: Wolfram Erdmann <[email protected]>\nadd missing vertex selection Co-authored-by: Wolfram Erdmann <[email protected]>\nget back accidentally overwritten configs from 13_1_0_pre1 Co-authored-by: Wolfram Erdmann <[email protected]>\nreduce verbosity Co-authored-by: Wolfram Erdmann <[email protected]>\nremove cputime measurement Co-authored-by: Wolfram Erdmann <[email protected]>\nremove obsolete include of DAClusterizerInz.h Co-authored-by: Wolfram Erdmann <[email protected]>\nremove unnecessary class commit c01d6291efac454307d4a1ff8fc25d9f8437a08c Author: mmusich <[email protected]> Date: Thu Jan 25 17:22:34 2024 +0100 silence CPP20 warnings about maybe-uninitialized variables in momentumBiasValidation.C commit 66176a172662e116a37a6c68c80974d95b0a2910 Author: Adriano Di Florio <[email protected]> Date: Wed Nov 15 18:13:46 2023 +0100 Port the pixel gpu-vs-cpu validation to Alpaka Rename "gpu" to "device" and "cpu" to "host". Co-authored-by: Breno Orzari <[email protected]> Co-authored-by: Dimitris Papagiannis <[email protected]> commit 3f668a2e57ded29e140cb55a9cf5e9b5ea7105e4 Author: Adriano Di Florio <[email protected]> Date: Wed Nov 15 18:20:18 2023 +0100 Port the pixel vertex reconstruction to Alpaka Co-authored-by: Breno Orzari <[email protected]> Co-authored-by: Dimitris Papagiannis <[email protected]> commit dd6f8b575b79ff0496a4509683a9d772613c0575 Author: Melissa Quinnan <[email protected]> Date: Fri Jan 26 03:22:05 2024 +0100 menu fix commit b78e3d28fc1b71c4097703e7076079609f74bb58 Author: mmusich <[email protected]> Date: Tue Dec 12 12:17:28 2023 +0100 HLT menu development for 13_3_X (branch: 14_0_X) This is an intermediate update towards the 2024 proton-proton run data-taking. This update includes the integration of the following JIRA tickets: - [CMSHLT-2975](https://its.cern.ch/jira/browse/CMSHLT-2975) [EXO,TSG]: Bug in configuration of *...NoFiltersNoVertex...* HLT/MC paths - [CMSHLT-2982](https://its.cern.ch/jira/browse/CMSHLT-2982) [EXO,TSG]: Misconfiguration of hltL3fL1DoubleMuf0L2NVf15f7L3SingleMuNVf18DisplacedHybDxy0p1cm - [CMSHLT-2979](https://its.cern.ch/jira/browse/CMSHLT-2979) [EXO,HIG,TSG]: Misconfiguration of hltDiPFJet45MJJ1050 (VBF-parking triggers) - [CMSHLT-2985](https://its.cern.ch/jira/browse/CMSHLT-2985) [EXO,TSG]: Set hltStoppedHSCPIterativeCone4CaloJets.srcPVs to empty InputTag - [CMSHLT-2986](https://its.cern.ch/jira/browse/CMSHLT-2986) [MUO,TSG]: Remove refs to offline products in MuonIdProducer instances at HLT commit ddda404458c779fb42da34f340b721746f89d550 Author: Adriano Di Florio <[email protected]> Date: Wed Nov 15 18:20:18 2023 +0100 Port the pixel track reconstruction to Alpaka Co-authored-by: Breno Orzari <[email protected]> Co-authored-by: Dimitris Papagiannis <[email protected]> commit 18a5acb98a55061a0e54e999eb432acf96da583b Author: Andrea Bocci <[email protected]> Date: Wed Jan 24 14:16:58 2024 +0100 Resolve conflict between alpaka and legacy SiPixelDigisSoA Reuse the new SiPixelDigisLayout types in place of the old SiPixelDigisSoALayout and related types, and move the old SiPixelDigisSoA class into the legacy namespace. commit 87aaae822fd84f02704777a65a32a579a94ac31c Author: Adriano Di Florio <[email protected]> Date: Wed Nov 15 17:44:55 2023 +0100 Port the pixel local reconstruction to Alpaka Co-authored-by: Andrea Bocci <[email protected]> Co-authored-by: Breno Orzari <[email protected]> Co-authored-by: Dimitris Papagiannis <[email protected]> commit 203834e3ae301f2564423dd1cc84bebf660519b9 Merge: 10eeb5fb978 27e1812e48f Author: cmsbuild <[email protected]> Date: Thu Jan 25 16:20:46 2024 +0100 Merge pull request #43689 from mmusich/mm_dev_introducePhase2Cosmics_14_0_X Introduce wf 7.5 (phase-2 cosmics D98) and necessary mods to make it run commit 10eeb5fb9789c257ad79a59a8b0facdd216c6fbc Merge: 2f8832f4338 90b81acea57 Author: cmsbuild <[email protected]> Date: Thu Jan 25 16:20:21 2024 +0100 Merge pull request #43715 from vlimant/IMTon_forNANO remove nano specific setting for IMT commit 2f8832f4338b8c2e904d8e87d4e2cd4cb534e1ee Merge: 3f0a6adb77b 889b2531282 Author: cmsbuild <[email protected]> Date: Thu Jan 25 16:20:12 2024 +0100 Merge pull request #43721 from cms-trackeralign/mm_devel_ZMuMuInHGPCL_from-CMSSW_14_0_X Introduce High Granularity Tracker Alignment Prompt Calibration Loop with Z → µµ data commit 3f0a6adb77bc71cf9449445efda6527da7455f65 Merge: 21821aa4ee9 01963386013 Author: cmsbuild <[email protected]> Date: Thu Jan 25 16:19:55 2024 +0100 Merge pull request #43753 from vlimant/muDPG_auto_config simplify MU-DPG custom nano configuration commit 21821aa4ee983fe22b7d66914b26e4bd9f7ea4f0 Merge: 54e9b5fec61 3f6db1e44a1 Author: cmsbuild <[email protected]> Date: Thu Jan 25 16:19:50 2024 +0100 Merge pull request #43757 from mmusich/mm_dev_TkAlV0s Introduce `AlignmentTracksFromVertexCompositeCandidate` and new alca flavour `TkAlV0s` commit 54e9b5fec6143ce83184740685dda7cf42ab25e8 Merge: 20e35166e59 69af391e83d Author: cmsbuild <[email protected]> Date: Thu Jan 25 16:19:37 2024 +0100 Merge pull request #43776 from iarspider/split-test_config_dp Split testConfigDP into smaller parts commit 20e35166e59ad10b7411f170c6a296cfb01bfe77 Merge: 576e920aa3a e702af07658 Author: cmsbuild <[email protected]> Date: Thu Jan 25 16:18:34 2024 +0100 Merge pull request #43734 from vlimant/rollback_int8_NANO remove support for int8 branches in NANO commit 576e920aa3a5edf15472fac2e2e993fbb92fe7e8 Merge: d3ec91c3b8b b6c6756ed8c Author: cmsbuild <[email protected]> Date: Thu Jan 25 16:18:07 2024 +0100 Merge pull request #43737 from cgsavard/update_disptrkjet_cuts_master Update displaced track jet cuts in GTT commit d3ec91c3b8be81400898a389f3516cbaaace1f5f Merge: 162fd7ef7c8 bfe846731e8 Author: cmsbuild <[email protected]> Date: Thu Jan 25 16:17:36 2024 +0100 Merge pull request #43741 from rdelliga/Pt_residuals MTD Validation: addition of plots for the impact of MTD on Pt resolution commit 162fd7ef7c8d83170a616c0c5693df0737844191 Merge: e85bc44f6bc 059c66764b0 Author: cmsbuild <[email protected]> Date: Thu Jan 25 16:16:54 2024 +0100 Merge pull request #43770 from iarspider/fix-deprecation-RooDataSet Fix usage of deprecated RooDataSet constructors commit e85bc44f6bc5e9dcc8a1fa53a163770dbd8fc58e Merge: de29401113f ff7f52f2ac2 Author: cmsbuild <[email protected]> Date: Thu Jan 25 16:16:03 2024 +0100 Merge pull request #43773 from iarspider/fix-constexpr-format Fix compilation errro in Alignment/OfflineValidation/test/testTrackAnalyzers.cc commit de29401113f70c4f9f0355ba6a9064dc5e68d9f2 Merge: 9b947024a23 676482b3c2e Author: cmsbuild <[email protected]> Date: Thu Jan 25 16:15:46 2024 +0100 Merge pull request #43774 from Sam-Harper/AddSignedGsfTrackVars_1400pre2 Added signed GSF track variable collections to the HLT producer: 14_0 commit 9b947024a23ff4173cd0b6c246242ee2916be1f9 Merge: 7bf48eeb5ca 64f463da352 Author: cmsbuild <[email protected]> Date: Thu Jan 25 16:14:54 2024 +0100 Merge pull request #43781 from cms-sw/revert-43588-PVValidation-likelihood-fit Revert "Use likelihood fit instead of chi-square fit in PVValidation" commit 7bf48eeb5ca79dc8d70cfabac3c3d9c8c4fcd4e6 Merge: bb525104a7d 1d1ae88537a Author: cmsbuild <[email protected]> Date: Thu Jan 25 16:14:39 2024 +0100 Merge pull request #43782 from smuzaffar/chi-sq-revert Revert back to chi-square fit instead of likelihood fit commit 5a672dbec4bdd745cbc6fac272998bb94588351f Author: brusale <[email protected]> Date: Thu Jan 25 15:12:15 2024 +0100 code-format commit 9772748f3b45422a3ece8631e214ff29709d636b Author: brusale <[email protected]> Date: Thu Jan 25 14:03:53 2024 +0100 fix purity and duplicate rate calculation commit 8962c200f2d737cd039950259200278a7c7a0c0b Author: Mario Masciovecchio <[email protected]> Date: Thu Jan 25 04:08:41 2024 -0800 Fix spacing commit bfc549bbd136b7cbb1f2534e8ece9aa6c369f348 Author: mmusich <[email protected]> Date: Thu Jan 25 10:13:10 2024 +0100 add vertexVersion option to TestReadRun3Scouting to support Run3ScoutingVertex v3 commit ee4b1487f616976bd74f3957f5a75c725d898f0d Author: Mario Masciovecchio <[email protected]> Date: Wed Jan 24 09:45:13 2024 -0800 Update following comments commit 8bd2e9177f711963165646e469e58710c0ba68ae Author: Mario Masciovecchio <[email protected]> Date: Fri Jan 19 10:27:52 2024 -0800 Keep earlier order in scouting vertex member data commit a4eaf805be618dc1cd38803bb16b5a6bca42e98b Author: Mario Masciovecchio <[email protected]> Date: Fri Jan 19 09:41:27 2024 -0800 Add non-diagonal errors to scouting vertices commit 274e9357df981be02418427fd62e4945e91f929b Author: Jean-Baptiste Sauvan <[email protected]> Date: Mon Jan 22 14:19:37 2024 +0100 Update validation histograms commit e702af076585b50174e4fa32b96c1fb43567b5bf Author: jean-roch <[email protected]> Date: Thu Jan 25 09:39:07 2024 +0100 both seediEta/Phi in int16 commit 1d1ae88537a547de389ee55404f8579a2213ff47 Author: Shahzad Malik Muzaffar <[email protected]> Date: Wed Jan 24 22:46:06 2024 +0100 Revert back to chi-square fit commit 64f463da3520daca321329658e877e12086d357e Author: Malik Shahzad Muzaffar <[email protected]> Date: Wed Jan 24 22:42:37 2024 +0100 Revert "Use likelihood fit instead of chi-square fit in PVValidation" commit 7383224d24e24afa1f6b878e3f68931e1399b6b3 Author: W. David Dagenhart <[email protected]> Date: Wed Jan 24 18:02:47 2024 +0100 Disable the getFedFromOmds configuration option in L1RCTProducer commit 7095b74d3292340d29b4d93f4e1856869eaa064d Author: Ivan Razumov <[email protected]> Date: Wed Jan 24 14:23:11 2024 +0100 Code-format commit 676482b3c2ecb0ad2656e7fafb73877c6247c99e Author: Sam Harper <[email protected]> Date: Wed Jan 24 13:21:44 2024 +0000 code review comments commit 886ae91d68fe77f0e7657b5f15ff9b22180e53bf Author: Ivan Razumov <[email protected]> Date: Wed Jan 24 09:59:43 2024 +0100 Replace C-style arrays with std::arrays (follow-up on comments in #43771) commit 69af391e83d741b4cfd3f55b34a727fea6be65a3 Author: iarspider <[email protected]> Date: Wed Jan 24 10:32:21 2024 +0100 Update BuildFile.xml commit f2d6925985a1fadedde5c21ce231b34525a3e1e9 Author: Sam Harper <[email protected]> Date: Tue Jan 23 16:41:50 2024 +0000 another bug fix on setting abs vars commit c8dfc097ae2508c8b7bdb0a14f3d7bd40faf0652 Author: Sam Harper <[email protected]> Date: Tue Jan 23 16:10:54 2024 +0000 adjusting pr number commit 360b794de6ee2ee71b551af4a370a568c1b36d10 Author: Sam Harper <[email protected]> Date: Tue Jan 23 16:10:11 2024 +0000 fixing bug filling variables commit 209df8fd8d1d4b2c2bb79fea9d7b573c51f19676 Author: Ivan Razumov <[email protected]> Date: Tue Jan 23 16:25:33 2024 +0100 Split testConfigDP into smaller parts commit bb525104a7ddb93685f8ced6fed1ab793b2d2103 Merge: 84d160709d2 fea46e71a12 Author: cmsbuild <[email protected]> Date: Tue Jan 23 16:21:16 2024 +0100 Merge pull request #43771 from iarspider/fix-deprecated-copy-L1CaloTrigger Fix deprecated-copy warnings in L1CaloTrigger commit 84d160709d29d21a158552868689331ae249d6ac Merge: 884233d3046 9093025b792 Author: cmsbuild <[email protected]> Date: Tue Jan 23 16:21:02 2024 +0100 Merge pull request #43763 from saumyaphor4252/alca-Update_140X_Run3_GTs Update 140X Run3 data and MC GTs commit 884233d3046bd3781e388e41835a66b1b8d690ef Merge: 743099a22e1 2bfaabc1c69 Author: cmsbuild <[email protected]> Date: Tue Jan 23 16:20:35 2024 +0100 Merge pull request #43752 from smuzaffar/fix-warn-ig1 Fix warnings which are ignored by bot commit 743099a22e1faa3bd4b2c453bbf98013e7522955 Merge: f4341e4d582 b055c4cd573 Author: cmsbuild <[email protected]> Date: Tue Jan 23 16:17:52 2024 +0100 Merge pull request #43749 from Dr15Jones/branchIdListLHESource Properly setup meta data in LHESource commit f4341e4d5828656522c2a9e61d3298a7e810b111 Merge: 4c8a2165aca 1bf5c0f07cc Author: cmsbuild <[email protected]> Date: Tue Jan 23 16:17:22 2024 +0100 Merge pull request #43738 from SohamBhattacharya/test-paths_P2-L1-GT-emulator_14_0_0_pre2 [14_0_X] [Phase-2] Change Phase-2 HLT muon paths to use the L1 GT emulator commit 4c8a2165aca97274520701e70a698b6c9dc74c49 Merge: 762c965c689 9e23a7b442e Author: cmsbuild <[email protected]> Date: Tue Jan 23 16:15:37 2024 +0100 Merge pull request #43622 from drkovalskyi/soft_mva_id_for_run3 Soft muon MVA id for run3 commit 762c965c6891f5b15ebd6f84b4f8634399c3d2e3 Merge: 089c6d89f91 e03dde38247 Author: cmsbuild <[email protected]> Date: Tue Jan 23 15:37:47 2024 +0100 Merge pull request #43064 from ericcano/OneToManyFromCUDAToAlpaka Ports prefixScan, OneToManyAssoc and HistoContainer from CUDAUtilities. commit 363a747c0b349a894468848c27591e77b566339a Author: Sam Harper <[email protected]> Date: Tue Jan 23 13:48:19 2024 +0000 adding request of only producing signed variable commit cf64de5f72f0fc907c42a9e5a780302521f5c825 Author: Sam Harper <[email protected]> Date: Thu Jan 18 14:50:27 2024 +0000 adding fbrem to gsftrack var producer commit b4433a0973f97883fec7c9045d51ed038d40e832 Author: A.R.Sahasransu <[email protected]> Date: Wed Jan 17 12:24:55 2024 +0100 Added signed GSF track variable producers commit ff7f52f2ac2db945dd3947781ca8fa6e40e4ac1e Author: Ivan Razumov <[email protected]> Date: Tue Jan 23 14:44:17 2024 +0100 Fix compilation errro in Alignment/OfflineValidation/test/testTrackAnalyzers.cc commit dd2b6a332a39830b48a500ccbcbb0309adddf53a Author: Thomas <[email protected]> Date: Thu Oct 12 14:16:27 2023 +0200 ECAL unpacker and ECAL multifit algorithm migration to alpaka. Co-authored-by: Thomas Reis <[email protected]> Co-authored-by: Davide Valsecchi <[email protected]> Co-authored-by: Jakub Andrzej Gajownik <[email protected]> commit e03dde38247546aa50d232ab9722ef1eb3961db5 Author: Eric Cano <[email protected]> Date: Mon Jan 15 20:11:47 2024 +0100 Final fixes to unit tests of port to Alpaka Reinstates error messages instead of silent call to `REQUIRE(!devices.empty());` Adds maybe_unused attirbut for variable used in assert. commit fea46e71a12c3e54c78b51c93ab4975fd691c017 Author: Ivan Razumov <[email protected]> Date: Tue Jan 23 10:01:31 2024 +0100 Fix deprecated-copy warnings in L1CaloTrigger commit 059c66764b058f38109645f702040203b7bb9790 Author: Ivan Razumov <[email protected]> Date: Tue Jan 23 09:36:13 2024 +0100 Fix usage of deprecated RooDataSet constructors commit 0084c011159859b0e7ee6135fb31f126b5040083 Author: Sunanda <[email protected]> Date: Tue Jan 23 05:10:24 2024 +0100 Add possibilities of more scenarios in some of the checks of G4 Components commit b6c6756ed8c5749751d70b26def8d1bd4e13dda2 Merge: 7b5ea3ea0ce 089c6d89f91 Author: cgsavard <[email protected]> Date: Mon Jan 22 13:21:16 2024 -0700 Merge branch 'master' into update_disptrkjet_cuts_master commit 089c6d89f91f9b6e108680cae7c41ab24cd7ccb5 Merge: 84396776d3d c5a672edaec Author: cmsbuild <[email protected]> Date: Mon Jan 22 16:43:52 2024 +0100 Merge pull request #43759 from Dr15Jones/constexprVertex Changed to constexpr in reco::Vertex commit 84396776d3d6d2c12fa4a22bf65da2cf857a6410 Merge: eb8d04f9e2b 6b1b07abad1 Author: cmsbuild <[email protected]> Date: Mon Jan 22 16:43:25 2024 +0100 Merge pull request #43754 from mmusich/mm_dev_fix_test_payload_sanity fix `test_payload_sanity` unit test script commit eb8d04f9e2bf4864bec6603e546a4617b9991019 Merge: f1968b07149 5c8d4a04370 Author: cmsbuild <[email protected]> Date: Mon Jan 22 16:43:02 2024 +0100 Merge pull request #43750 from Dr15Jones/fixUBSANFieldHandler Fixed UBSAN warning in FieldHandler commit f1968b0714914dc5f2052f72b759be51238ae60b Merge: 6e558cba5f8 331ed1820f7 Author: cmsbuild <[email protected]> Date: Mon Jan 22 16:42:55 2024 +0100 Merge pull request #43746 from pallabidas/Phase-2_GCTObjects_calibration_14X [Phase-2 L1T] calibrated GCT calo jets and taus commit 6e558cba5f8fb1d009158b9769acb59e18e050bc Merge: f09c4d3b013 84535a0eb98 Author: cmsbuild <[email protected]> Date: Mon Jan 22 16:41:49 2024 +0100 Merge pull request #43736 from srimanob/140_UpdatePatatrackWfInRelVal2026 Update Patatrack wf in relval_2026 commit f09c4d3b0135d317d7f68958068577cbbeb799db Merge: 9ca8b505f88 43c8e006f57 Author: cmsbuild <[email protected]> Date: Mon Jan 22 16:41:35 2024 +0100 Merge pull request #43732 from fabiocos/fc-fixTimeCalib20240117 MTD reconstruction: fix BTL time for missing correction in BTL geometry v3 (scenario I17) commit 9ca8b505f88572821e8ee4af1ae9916b029dd4ee Merge: 1351fd0fb15 f689bde0b18 Author: cmsbuild <[email protected]> Date: Mon Jan 22 16:40:47 2024 +0100 Merge pull request #43727 from bsunanda/hgx-TB77A hgx-TB77A Commit changes made by Ashim for 2023 August/Septemeber Test Beam commit 1351fd0fb15fae465e0f1a1950ff2d8efe805419 Merge: 90bddf09047 4cfad47cd3f Author: cmsbuild <[email protected]> Date: Mon Jan 22 16:39:55 2024 +0100 Merge pull request #43726 from makortel/minuit2errorMessage Make Minuit2 error on non-posdef initial matrix an error message instead of an exception commit 90bddf09047341130afd8720f0d8e0ddf2322725 Merge: 8a30dff5928 9793955c413 Author: cmsbuild <[email protected]> Date: Mon Jan 22 16:39:11 2024 +0100 Merge pull request #43705 from gpetruc/barrel_tm18_master L1T Correlator support for TMUX 18 in the barrel commit 8a30dff59287ddaca9c79abbfd50023d13acd500 Merge: 88f92eef282 4ef2e83cfae Author: cmsbuild <[email protected]> Date: Mon Jan 22 16:26:47 2024 +0100 Merge pull request #43704 from hgc-tpg/hgc-tpg-integration-240112 [HGCAL trigger] Update in geometry tester class commit 88f92eef2825da9bd5f6b01421ee96722cace6b7 Merge: c44200ac265 23d87192979 Author: cmsbuild <[email protected]> Date: Mon Jan 22 16:25:10 2024 +0100 Merge pull request #43686 from aloeliger/removeConditionsHack Remove hackConditions as was done in L1T Offline fork commit c44200ac265ea7c629bbcf44be76d53216b270e2 Merge: ddf801ab506 7af27c7525f Author: cmsbuild <[email protected]> Date: Mon Jan 22 16:24:53 2024 +0100 Merge pull request #43653 from Dr15Jones/modernizeSimMuon Moved to global modules in SimMuon commit ddf801ab506cf327b3ce8bdca37554925e4daa6e Merge: 6c07430a205 fb6058455a3 Author: cmsbuild <[email protected]> Date: Mon Jan 22 16:23:39 2024 +0100 Merge pull request #43639 from Duchstf/tau_pt_cali Add update for Tau NN with pT calibration commit 6c07430a205dcddf63cf913ac2e1f234dc66d5de Merge: 9b2ab85ed1b 779091bcfcb Author: cmsbuild <[email protected]> Date: Mon Jan 22 16:21:03 2024 +0100 Merge pull request #41255 from AdrianoDee/phase2_nodigis_guard Guard for No Digis for Phase2 and Patatrack `NuGun` commit 1bf5c0f07cce9abbe22e8b0dfd571f7138a09bbe Author: SohamBhattacharya <[email protected]> Date: Mon Jan 22 10:31:09 2024 +0100 Implemented review comments commit 9093025b79226864ccb777a1fdf9db0d99ce445d Author: Saumya Phor <[email protected]> Date: Fri Jan 19 19:29:46 2024 +0100 Update 140X Run3 data and MC GTs commit 3f6db1e44a14aef55ba66ff1c29055c49f201b19 Author: mmusich <[email protected]> Date: Fri Jan 19 12:03:24 2024 +0100 produce TkAlV0s in HLTPhysics commit 026466b6286f94a1dd10fde447eeb57885de8b16 Author: mmusich <[email protected]> Date: Fri Jan 19 12:02:50 2024 +0100 add ALCARECOTkAlV0s DQM sequences commit eeec868f03fd20d5b33a623538d5e2f9d48779fc Author: mmusich <[email protected]> Date: Thu Dec 14 17:48:42 2023 +0100 add a stub of TkAlV0sAnalyzer commit 2b3c8d25995ad932e130acac2936b5f175f0cb1a Author: Sunanda <[email protected]> Date: Sat Jan 20 05:55:03 2024 +0100 Modify the scenarios D104, D105 to accommodate modified T35 and I17 (also go back to C17 for D105). Add a new scenario D106 with C23 (same as C22 but without cell definition in Geant4) commit c5a672edaec28438e3dcb179b3595a34c47e3666 Author: Christopher Jones <[email protected]> Date: Fri Jan 19 12:48:10 2024 -0600 Changed to constexpr in reco::Vertex This appears to help RNTuple migration. commit 9af4710b6185c1cea3bea71fbd17daba6d786b69 Author: Andrea Bocci <[email protected]> Date: Mon Jan 15 14:35:23 2024 +0100 Moves from elements_with_stride to independent_group_elements commit 4af44b358cd4d7b01b4cef37b034c9b28535a294 Author: Eric Cano <[email protected]> Date: Thu Oct 19 11:37:05 2023 +0200 Ports prefixScan, OneToManyAssoc and HistoContainer from CUDAUtilities. OneToManyAssoc is also separated into various function depending on use case. Co-authored-by: Andrea Bocci <[email protected]> commit 9b2ab85ed1bde269fdf90744fcc7644984f657b2 Merge: 4792b8063af dd81d6385fb Author: cmsbuild <[email protected]> Date: Fri Jan 19 17:45:44 2024 +0100 Merge pull request #43747 from Dr15Jones/fix_fillEventPrincipal Handle empty branch index lists from input commit 4792b8063afa6b9cc68dc259b61bdc70b7054afd Merge: 66cb0ca3a28 58dade5aaa5 Author: cmsbuild <[email protected]> Date: Fri Jan 19 17:45:32 2024 +0100 Merge pull request #43745 from cms-trackeralign/dev_changeMinPrec_forPhase2Alignment `ReferenceTrajectory`: decrease the value of the minumum precision to allow along-strip alignment of Phase2 2S modules commit 66cb0ca3a2818e75996ea64318fdec7b7f5a71c9 Merge: 0340b3edc7f ba8f7a271fa Author: cmsbuild <[email protected]> Date: Fri Jan 19 17:44:22 2024 +0100 Merge pull request #43744 from arsahasransu/Scouting2024EGDataFormatUpdate_from1400pre2 Electron and Photon Scouting Data Format Update for 2024 pp Collisions commit 0340b3edc7f61cc8836f1afee2db596d087af4d6 Merge: 0f8b301431b 366848638b1 Author: cmsbuild <[email protected]> Date: Fri Jan 19 17:41:40 2024 +0100 Merge pull request #43731 from silviodonato/addFillDesc_Merger3 Add fillDescription to CommonTools/UtilAlgos/interface/Merger.h - 140X commit 0f8b301431b8ea2f3b7c21f11e0e9c487c18cd3d Merge: c74a440501a 3da22f135ce Author: cmsbuild <[email protected]> Date: Fri Jan 19 17:39:43 2024 +0100 Merge pull request #43729 from mmusich/mm_dev_TrackingResolution_14_0_X Adapt shortened tracks resolution method to work with AlCaReco event content commit c74a440501a5a18844c8b8da46203a60dacfc1e7 Merge: e35416cce44 ecba17c383a Author: cmsbuild <[email protected]> Date: Fri Jan 19 17:35:45 2024 +0100 Merge pull request #43724 from Dr15Jones/zeroModuleDQMStore DQMStore avoids using 0 as invalid module ID commit e35416cce447010d9e125eeccaa457d29cf19cfd Merge: d55ac3cc274 e3e0824c7c7 Author: cmsbuild <[email protected]> Date: Fri Jan 19 17:31:49 2024 +0100 Merge pull request #43720 from slava77/CMSSW_13_0_0_pre4/tkNtuple-mkf-ph2 add OT tracker cluster masks in TrackingNtuple commit d55ac3cc274aeabf84ef48048c15d12fe27f6373 Merge: 4c6d9b1cce4 1138d271428 Author: cmsbuild <[email protected]> Date: Fri Jan 19 17:31:38 2024 +0100 Merge pull request #43719 from smuzaffar/scram-unit-tests Unit tests to check SCRAM test command works commit 4c6d9b1cce4ae1816e435ccd47f3042b02d6c592 Merge: 411daba0c25 62e7d690b59 Author: cmsbuild <[email protected]> Date: Fri Jan 19 17:30:55 2024 +0100 Merge pull request #43718 from bsunanda/Phase2-hgx350C Phase2-hgx350C Steps to create a scenario of B18 Geometry of HGCal where no innecr cell straucture of full wafers are not created atin Geant4 geometry commit 411daba0c25f4ce2808942cef8f39e447449e31f Merge: ccba54b8308 ea1688eccb2 Author: cmsbuild <[email protected]> Date: Fri Jan 19 17:30:30 2024 +0100 Merge pull request #43717 from bsunanda/Phase2-hgx351 Phase2-hgx351 Modify to analyze flat files contatining only full silisonlayers of EE and HE (usefule for HFNose) commit ccba54b8308724d76481475c3701b608cd953364 Merge: c7b2357e044 5b5b1edd08b Author: cmsbuild <[email protected]> Date: Fri Jan 19 17:30:05 2024 +0100 Merge pull request #43716 from mmusich/mm_dev_update_testTrackAnalyzers Update `testTrackAnalyzers` commit c7b2357e044256c0c813e5d68693e502fbe20825 Merge: f215008bc78 36266858272 Author: cmsbuild <[email protected]> Date: Fri Jan 19 17:28:40 2024 +0100 Merge pull request #43682 from makortel/portableCollectionMember Example of Alpaka-based EventSetup data product that uses PortableCollection member variables commit f215008bc7866bbdc3efe23a06fda6fec0c27b6b Merge: 6c9b354…
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
This PR migrates the ECAL unpacker and ECAL multifit algorithm to alpaka. This is a follow up PR to #42930 , in which the data formats and conditions formats have been defined.
EventFilter modules:
Amplitude and time reconstruction modules:
A customization function for the HLT menu is included that replaces the ECAL CUDA modules in the menu with alpaka ones. The customization function is not called, however, and is intended to be used in a customization function for all alpaka modules.
The
alpaka
modifier is used to run the alpaka modules instead of the legacy CPU modules and the CUDA modules.The matrix workflow 12434.515 runs the alpaka ECAL local reconstruction in the HLT and the offline reconstruction step.
Alternatively, for tests the
gpu
modifier in thecmsDriver.py
command for obtaining a reconstruction configuration can be replaced with thealpaka
modifier. For example in the step3 of the 12434.512 matrix workflow.@valsdav and @Jakub-Gajownik contributed to these development as well.
PR validation:
Tested with the matrix workflow 12434.513, which produces a legacy CPU vs. alpaka(-nvidia/-serial) comparison in DQM. This test requires some modifications to keep running the legacy CPU code for the
cpu
branch of theSwitchProducerCUDA
.For the validation 9k events from the
/store/relval/CMSSW_13_3_0_pre4/RelValZEE_14/GEN-SIM-DIGI-RAW/ 133X_mcRun3_2023_realistic_v1_Standard_13_3_0_pre4-v1
sample were used.An almost perfect agreement is found between results from the the nvidia and serial backends.
Compared to the original CUDA implementation a very good agreement is found as well.
From the TimeReport, the timing of the alpaka-nvida version is close to the native CUDA implementation, while the alpaka-serial version is about 18% slower than the legacy CPU module.