Run3-hcx356 Include the updated XML file for ZDC to the 2023 scenario for CMS

[bsunanda]

PR description:

Include the updated XML file fr ZDC to the 2023 scenario for CMS. There was a small bug fix for the 2021 FlatPlus10Percent scenario where by mistake the GE21 position was wrongly made the same as in the 2023 case.

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43237/37593

• This PR adds an extra 40KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/Geometry/python/dict2021Geometry.py modified in PR(s): revert PR 40443 w/o introducing bricked pixels #42454

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Configuration/Geometry (upgrade, geometry)
• Geometry/CMSCommonData (upgrade, geometry)
• Geometry/ForwardCommonData (geometry)

@Dr15Jones, @makortel, @mdhildreth, @srimanob, @cmsbuild, @civanch, @bsunanda, @AdrianoDee can you please review it and eventually sign? Thanks.
@slomeo, @fabiocos, @vargasa, @Martin-Grunewald, @missirol this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44adaa/35727/summary.html
COMMIT: 725af9f
CMSSW: CMSSW_14_0_X_2023-11-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43237/35727/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test2021Geometry had ERRORS

Comparison Summary

Summary:

• You potentially added 76 lines to the logs
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363010
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3362988
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43237/37604

• This PR adds an extra 44KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/Geometry/python/dict2021Geometry.py modified in PR(s): revert PR 40443 w/o introducing bricked pixels #42454

[cmsbuild]

Pull request #43237 was updated. @bsunanda, @Dr15Jones, @makortel, @civanch, @cmsbuild, @srimanob, @mdhildreth, @AdrianoDee can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44adaa/35808/summary.html
COMMIT: eb164eb
CMSSW: CMSSW_14_0_X_2023-11-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43237/35808/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

• You potentially added 108 lines to the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363028
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3363000
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44adaa/35815/summary.html
COMMIT: eb164eb
CMSSW: CMSSW_14_0_X_2023-11-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43237/35815/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 68 lines to the logs
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363028
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3363002
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[bsunanda]

+geometry

[bsunanda]

@srimanob Please sign it now

[bsunanda]

@srimanob Please approve this

[srimanob]

+Upgrade

Note to @cms-sw/pdmv-l2 @cms-sw/alca-l2 for update of 2023 geometry. I also have a follow up question if we should clone 2023 to 2024 geometry in a follow up PR, then update when we have a final from muon? This may avoid confusion later.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

Note to @cms-sw/pdmv-l2 @cms-sw/alca-l2 for update of 2023 geometry. I also have a follow up question if we should clone 2023 to 2024 geometry in a follow up PR, then update when we have a final from muon? This may avoid confusion later.

I woud say: why not?
As a side note: what is the purpose of adding here a file with the 2026 zdc xml geometry?

[bsunanda]

I think we should wait a while for 2024 geometry. The GE21 scenario will become clear only in Germany. The situation with ZDC will be clear later and that will most likely be applicable for Phase2.

[bsunanda]

@srimanob @perrotta @civanch Sorry I meant January in my last message and not Germany. We shall discuss zdc geometry during next week PPD meeting

[perrotta]

As a side note: what is the purpose of adding here a file with the 2026 zdc xml geometry?

Just in case you did not notice it, @bsunanda

[bsunanda]

That file is appropriate for 2026 as well. I did not modify the scenario and just waiting for a future version where we break the 2026 even more

…

________________________________ From: Andrea Perrotta ***@***.***> Sent: 17 November 2023 15:45 To: cms-sw/cmssw ***@***.***> Cc: Sunanda Banerjee ***@***.***>; Mention ***@***.***> Subject: Re: [cms-sw/cmssw] Run3-hcx356 Include the updated XML file for ZDC to the 2023 scenario for CMS (PR #43237) As a side note: what is the purpose of adding here a file with the 2026 zdc xml geometry? Just in case you did not notice it, @bsunanda<https://github.com/bsunanda> — Reply to this email directly, view it on GitHub<#43237 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOUNDXUD4PUDAZHBZCLYE42LPAVCNFSM6AAAAAA7EVZ4M6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJWGA4TGOJXGY>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[rappoccio]

+1