Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Correct EGM Run3 electron NonIso MVA ID for EB #43275

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Add Correct EGM Run3 electron NonIso MVA ID for EB #43275

merged 1 commit into from
Nov 17, 2023

Conversation

Prasant1993
Copy link
Contributor

PR description:

This PR is to add the correct Run3 Electron Non Isolated MVA-based ID for EB from EGamma POG:
The previous electron Non Isolated MVA ID in EB was wrong. The Non-Isolated and Isolated ID were calculated to be same in EB due to the same weight file for both of them . In this PR it has been corrected.

PR validation:

runTheMatrix tests have been successfully completed

  • runTheMatrix.py -l 12434.0

The electron MVA training weight files for Run3 have been already added here in this PR : cms-data/RecoEgamma-ElectronIdentification#29

This current PR for electron MVA ID will take the input weight files from the above PR to work with.
Please test this PR with cms-data/RecoEgamma-ElectronIdentification#29

Backport

Backport to CMSSW_13_3_X release is necessary.

Tagging EGM Convenors @a-kapoor and @RSalvatico

@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Nov 14, 2023
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43275/37683

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 14, 2023 •
edited
Loading

A new Pull Request was created by @Prasant1993 (Prasant Kumar Rout) for master.

It involves the following packages:

  • RecoEgamma/ElectronIdentification (reconstruction)

@cmsbuild, @mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@lgray, @varuns23, @valsdav, @sobhatta, @ram1123, @afiqaize, @sameasy, @missirol, @Sam-Harper, @jainshilpi, @a-kapoor this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@a-kapoor
Copy link
Contributor

enable nano

@a-kapoor
Copy link
Contributor

please test

@Prasant1993
Copy link
Contributor Author

please test

You should test with cms-data/RecoEgamma-ElectronIdentification#29

@a-kapoor
Copy link
Contributor

please abort

@a-kapoor
Copy link
Contributor

please test with cms-data/RecoEgamma-ElectronIdentification#29

@a-kapoor
Copy link
Contributor

please test with cms-data/RecoEgamma-ElectronIdentification#29

@Prasant1993 Prasant1993 mentioned this pull request Nov 15, 2023
Merged
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22afbd/35833/summary.html
COMMIT: 19a5a95
CMSSW: CMSSW_14_0_X_2023-11-14-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43275/35833/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 193 lines from the logs
  • Reco comparison results: 77 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3363070
  • DQMHistoTests: Total failures: 1417
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3361631
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16335
  • DQMHistoTests: Total failures: 60
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16275
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 34 log files, 16 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.535 2.535 0.000 ( +0.0% ) 5.26 5.35 -1.6% 2.031 2.166
2500.001 2.680 2.680 0.000 ( +0.0% ) 4.72 4.79 -1.4% 2.419 2.554
2500.002 2.616 2.616 0.000 ( +0.0% ) 4.89 4.99 -2.0% 2.418 2.550
2500.01 1.307 1.307 0.000 ( +0.0% ) 9.53 9.96 -4.3% 2.084 2.184
2500.011 1.721 1.721 0.000 ( +0.0% ) 5.15 5.36 -4.0% 2.246 2.322
2500.012 1.568 1.568 0.000 ( +0.0% ) 7.44 7.58 -1.9% 2.156 2.274
2500.1 2.188 2.187 0.000 ( +0.0% ) 5.35 5.39 -0.8% 1.982 1.977
2500.2 2.298 2.298 0.000 ( +0.0% ) 6.07 6.03 +0.7% 1.794 1.897
2500.21 1.174 1.174 0.000 ( +0.0% ) 4.36 4.42 -1.3% 2.091 2.176
2500.211 1.535 1.535 0.000 ( +0.0% ) 3.89 3.85 +0.9% 2.146 2.255
2500.3 2.054 2.053 0.001 ( +0.0% ) 12.93 12.88 +0.4% 1.883 1.886
2500.31 1.249 1.248 0.000 ( +0.0% ) 20.60 20.72 -0.6% 2.158 2.258
2500.311 1.635 1.635 0.000 ( +0.0% ) 13.98 14.62 -4.3% 2.220 2.335
2500.4 2.054 2.053 0.001 ( +0.0% ) 12.93 12.94 -0.0% 1.884 1.888
2500.5 19.556 19.556 0.000 ( +0.0% ) 1.36 1.37 -0.4% 1.297 1.304

jfernan2
jfernan2 reviewed Nov 16, 2023
View reviewed changes
RecoEgamma/ElectronIdentification/data/ElectronIDVariablesRun3NonIso.txt
Copy link
Contributor

@jfernan2 jfernan2 Nov 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this file be moved to https://github.com/cms-data/RecoEgamma-ElectronIdentification instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jfernan2, As you can see in the past, we save few other .txt files in the RecoEgamma/ElectronIdentification/data/ as well. Do you think, it will look good if we just move only this file to cms-data ? The location to these .txt files has to be changed in other several places if we move them now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, my comment was only referring to this txt file, of course

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that you have other files and they are not big, if ORP managers agree I don't have any objection to keep this one too

@RSalvatico
Copy link
Contributor

type egamma

@antoniovilela
Copy link
Contributor

antoniovilela commented Nov 16, 2023 •
edited
Loading

@Prasant1993 @cms-sw/reconstruction-l2
Do you think it would be reasonable for this PR to converge by tomorrow (Fri)? This is not meant to push the review, just to understand if we wait for it in 13_3_0.
Thanks.

@a-kapoor
Copy link
Contributor

a-kapoor commented Nov 16, 2023 •
edited
Loading

@Prasant1993 @cms-sw/reconstruction-l2 Do you think it would be reasonable for this PR to converge by tomorrow (Fri)? This is not meant to push the review, just to understand if we wait for it in 13_3_0. Thanks.

Hi @antoniovilela Yes, we should converge by tomorrow. We would like to have this for 13_3_0 since it is intended have these changes for Nanov13.

@jordan-martins
Copy link
Contributor

Hi guys, this should target 1330. Thanks!

@jfernan2
Copy link
Contributor

+1
Modulo this comment for ORP managers: #43275 (comment)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f19d48d into cms-sw:master Nov 17, 2023
This was referenced Nov 17, 2023
Open
Closed
Merged
Merged
@vlimant
Copy link
Contributor

vlimant commented Jan 24, 2024

assign xpog

@cmsbuild
Copy link
Contributor

New categories assigned: xpog

@vlimant,@hqucms you have been requested to review this Pull request/Issue and eventually sign? Thanks

@vlimant
Copy link
Contributor

vlimant commented Jan 24, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@vlimant
Copy link
Contributor

vlimant commented Jan 24, 2024

NB : I am surprised that this affected MINI/NANO without xpog signature in the first place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfernan2 jfernan2 jfernan2 left review comments

Assignees
No one assigned
Labels
code-checks-approved egamma fully-signed orp-approved reconstruction-approved requires-external tests-approved xpog-approved
Projects
None yet
Milestone
CMSSW_14_0_X
Development

Successfully merging this pull request may close these issues.
8 participants
@Prasant1993 @cmsbuild @a-kapoor @RSalvatico @antoniovilela @jordan-martins @jfernan2 @vlimant