-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Correct EGM Run3 electron NonIso MVA ID for EB #43275
Merged
cmsbuild
merged 1 commit into
cms-sw:master
from
Prasant1993:Add_Electron_correct_NonIso_MVAID_CMSSW_14_0_0_pre0
Nov 17, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
38 changes: 38 additions & 0 deletions
38
RecoEgamma/ElectronIdentification/data/ElectronIDVariablesRun3NonIso.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # File: ElectronIDVariablesRun3NonIso.txt | ||
| # | ||
| # This file is to be read by the MVAVariableHelper class. Lists all the | ||
| # variables which appear in the xml files for the MVA based Electron IDs for Run2. | ||
| # Variables are given line by line. The columns of each entry correspond to: | ||
| # | ||
| # 1. The name under which the variable appears in the weight files. | ||
| # 2. How to get this variable from the electron with the cut parser (NO SPACES!) | ||
| # or if not available, how to get the variables elsewhere. | ||
| # 3. The lower clip value for the variable to avoid crazy values. "None" if no clip. | ||
| # 4. The upper clip value. | ||
| # | ||
|
|
||
| # This selection of ID variables is rather large and not intended to be used by a real ID, | ||
| # but by an ntuplizer which dumps all possible ID variables. | ||
|
|
||
| rho fixedGridRhoFastjetAll None None | ||
| ele_oldsigmaietaieta full5x5_sigmaIetaIeta None None | ||
| ele_oldsigmaiphiiphi full5x5_sigmaIphiIphi None None | ||
| ele_oldcircularity 1.-full5x5_e1x5/full5x5_e5x5 -1. 2. | ||
| ele_oldr9 full5x5_r9 None 5. | ||
| ele_scletawidth superCluster.etaWidth None None | ||
| ele_sclphiwidth superCluster.phiWidth None None | ||
| ele_oldhe full5x5_hcalOverEcal None None | ||
| ele_kfhits closestCtfTrackNLayers None None | ||
| ele_kfchi2 closestCtfTrackNormChi2 None 10. | ||
| ele_gsfchi2 gsfTrack.normalizedChi2 None 200. | ||
| ele_fbrem fbrem -1. None | ||
| ele_gsfhits gsfTrack.hitPattern.trackerLayersWithMeasurement None None | ||
| ele_expected_inner_hits gsfTrack.hitPattern.numberOfLostHits('MISSING_INNER_HITS') None None | ||
| ele_conversionVertexFitProbability convVtxFitProb None None | ||
| ele_ep eSuperClusterOverP None 20. | ||
| ele_eelepout eEleClusterOverPout None 20. | ||
| ele_IoEmIop 1.0/ecalEnergy-1.0/trackMomentumAtVtx.R None None | ||
| ele_deltaetain abs(deltaEtaSuperClusterTrackAtVtx) -0.06 0.06 | ||
| ele_deltaphiin abs(deltaPhiSuperClusterTrackAtVtx) -0.6 0.6 | ||
| ele_deltaetaseed abs(deltaEtaSeedClusterTrackAtCalo) -0.2 0.2 | ||
| ele_psEoverEraw superCluster.preshowerEnergy/superCluster.rawEnergy None None |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this file be moved to https://github.com/cms-data/RecoEgamma-ElectronIdentification instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jfernan2, As you can see in the past, we save few other .txt files in the RecoEgamma/ElectronIdentification/data/ as well. Do you think, it will look good if we just move only this file to cms-data ? The location to these .txt files has to be changed in other several places if we move them now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, my comment was only referring to this txt file, of course
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that you have other files and they are not big, if ORP managers agree I don't have any objection to keep this one too