update createTestDBObjects unit test to use Tracker geometry T33
#45775
Conversation
|
cms-bot internal usage |
|
test parameters: |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45775/41491 |
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@cmsbuild, @consuegs, @francescobrivio, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
type bug-fix |
|
urgent
|
|
-1 Failed Tests: RelVals-INPUT The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here:
RelVals-INPUT
Expand to see more relval errors ...
Comparison SummarySummary:
|
|
@cmsbuild ignore tests-rejected with ib-failure |
|
|
||
| echo -e "TESTING Pixel 2D Template DB code for Phase-2 ..." | ||
| cmsRun ${SCRAM_TEST_PATH}/SiPixel2DTemplateDBObjectUploader_Phase2_cfg.py MagField=3.8 Version=1 Append=mc_25x100_IT615 Map=${SCRAM_TEST_PATH}/../data/phase2_T21_mapping_den.csv TemplateFilePath=CalibTracker/SiPixelESProducers/data/Phase2_IT_v6.1.5_25x100_irradiated_v2_mc denominator=True || die "Failure running SiPixel2DTemplateDBObjectUploader_Phase2_cfg.py" $? | ||
| #echo -e "TESTING Pixel 2D Template DB code for Phase-2 ..." |
There was a problem hiding this comment.
Isn't this test portable to T33?
There was a problem hiding this comment.
to elaborate further, the 2D templates are used in the IT digitizer to simulate radiation damage in the planar sensors (see #40349 and #40417).
According to @tvami there is no 2D template payload available for the T33 (and above) tracker geometries, so apparently there weren't any irradiation scenarios considered (yet).
I am keeping the line commented to re-instantiate the test when at a later time an irradiation scenario becomes available for T33 (or for some subsequent - even final - tracker geometry)
|
+db |
cmsbuild
added
fully-signed
db-approved
and removed
db-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
@mandrenguyen, thanks for merging. |
PR description:
This PR is a companion of #45764.
In response to #45370 (comment), this PR is meant to update the unit tests in
CondTools/SiPixelto use the Tracker geometry T33 as the previously used geometry T21 is not available anymore.PR validation:
scram b runtests_createDBObjectsruns fine.N.B.: this PR requires an update of the external
cms-datarepository: cms-data/CalibTracker-SiPixelESProducers#4If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A