-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a bunch of failing unit tests after D88 and D92 went missing #45764
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45764/41475 |
A new Pull Request was created by @mmusich for master. It involves the following packages:
@Dr15Jones, @antoniovagnerini, @bsunanda, @civanch, @cmsbuild, @consuegs, @jfernan2, @makortel, @mandrenguyen, @mdhildreth, @nothingface0, @perrotta, @rvenditti, @saumyaphor4252, @srimanob, @subirsarkar, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cms-sw/trk-dpg-l2 this leads me to believe there is something wrong in the TrackerTopology
implementation of geometry T35
(in D110
). Perhaps it's linked to the existing issue #43097.
Please take a look.
Alignment/OfflineValidation/test/testPrimaryVertexRelatedValidations_cfg.py
Show resolved
Hide resolved
@@ -46,15 +46,15 @@ | |||
################################################################### | |||
# Ideal geometry producer and standard includes | |||
################################################################### | |||
process.load('Configuration.Geometry.GeometryExtended2026D88Reco_cff') | |||
process.load('Configuration.Geometry.GeometryExtended2026DefaultReco_cff') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately when running runtests_test_CreateRandomMisalignment
this leads to:
----- Begin Fatal Exception 21-Aug-2024 12:54:53 CEST-----------------------
An exception of category 'BadHierarchy' occurred while
[0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
Exception Message:
[AlignableTrackerBuilder] Pixel GeomDet (subdetector 1) is not a GeomDetUnit.
----- End Fatal Exception -------------------------------------------------
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not yet solved, but circumvented for the time being by using a different geometry 2026D107
instead.
Geometry/TrackerGeometryBuilder/test/python/testPixelTopologyMapTest_cfg.py
Show resolved
Hide resolved
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45764/41477 |
+1 |
+Upgrade |
+1 |
@cms-sw/dqm-l2 please have a look |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
PR description:
Title says it all, in partial response to #45370 (comment).
PR validation:
Most of the tests now run correctly:
scram b runtests
of the changed packages.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A
Cc: @srimanob