Run3-377B Correct a few test scripts in CondTools/Geometry (backport of #46386)

[bsunanda]

PR description:

Correct a few test scripts in CondTools/Geometry (backport of #46386)

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #46386

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_14_1_X.

It involves the following packages:

• CondTools/Geometry (db)

@atpathak, @cmsbuild, @consuegs, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @mmusich, @rsreds, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Run3-hcx377A Correct a few test scripts in CondTools/Geometry #46386

[cmsbuild]

cms-bot internal usage

[bsunanda]

@cmsbuild Please test

[bsunanda]

@perrotta Please sign this

[mmusich]

have you considered using the mechanism introduced at #45764 to avoid having to always manually bump up the version here and elsewhere?

[perrotta]

backport of #46386

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e97964/42195/summary.html
COMMIT: 08060ac
CMSSW: CMSSW_14_1_X_2024-10-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46387/42195/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 34 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331166
• DQMHistoTests: Total failures: 2238
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3328908
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 191 log files, 161 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

Is there a good reason to backport this to 14_1_X?

[mandrenguyen]

hold

[cmsbuild]

Pull request has been put on hold by @mandrenguyen
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[bsunanda]

Just to be on par with 14_2_X. Believe 14_1_X will be used for the Heavy Ion run. I see from Salavat's message: (1) in the most recent 14_2_X build CMSSW_14_2_X_2024-10-15-2300 the job ... runs to completion (263 ev)
(2) in the most recent 14_1_X build CMSSW_14_1_X_2024-10-15-2300
idem

[mandrenguyen]

Just to be on par with 14_2_X. Believe 14_1_X will be used for the Heavy Ion run. I see from Salavat's message: (1) in the most recent 14_2_X build CMSSW_14_2_X_2024-10-15-2300 the job ... runs to completion (263 ev) (2) in the most recent 14_1_X build CMSSW_14_1_X_2024-10-15-2300 idem

Still not clearly whether/why this would be needed for 14_1_X.

[perrotta]

Still not clearly whether/why this would be needed for 14_1_X.

@mandrenguyen these are just test scripts updated with the current default Phase2 geometry, instead of an outdated one. This was already done for a bunch of other Phase2 related tests, and apparently these three were just forgotten. (Marco further proposes to implement an already existing procedure to automatically update the phase2 geometry version instead of having to fix all tests one by one: this is certainly welcome for the master, so that it will get propagated to all future releases, and this maintenance will not be needed any more).

I don't see anything worrying in updating these tests: quite likely CMSSW_14_1_X will never be used for Phase2 productions, but nonetheless having tests that can verify if the release is suitable for it doesn't hurt, and certainly does not affect any production for which the release is used.

[perrotta]

+db

• Given my thoughts expressed here above
• I'll let the decision to the release managers whether to unhold this PR and allow it being merged: there will be no effect on the standard workflows and campaigns in either cases, therefore I won't insist further on having this merged.

[mandrenguyen]

+db

* Given my thoughts expressed [here above](https://github.com/cms-sw/cmssw/pull/46387#issuecomment-2416187370)

* I'll let the decision to the release managers whether to unhold this PR and allow it being merged: there will be no effect on the standard workflows and campaigns in either cases, therefore I won't insist further on having this merged.

Fair enough. I just want to have explicit confirmation since the release is currently being validated. By eye this certainly looks safe.

[mandrenguyen]

unhold

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1