add hlt (HLT) label to Phase-2 HLT modules (sequences)

[mmusich]

PR description:

The goal of this PR is to package together the renaming of the HLT module and sequences labels in the HLT phase-2 menu (kindly provided by @AuroraPerego in AuroraPerego@226b557, see discussion at #45500 (comment)) with the necessary updates of the Trigger DQM and Validation sequences configurations consuming said products in order to stay in synch with it (that I provide in mmusich@24f4756)

PR validation:

None, will rely on the bot tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport and it should not be backported.

---

I open this PR in draft mode as I am not sure that I have caught all the products consumed downstream that need to be renamed in the configuration.
I would like to request feedback to:

• @cms-sw/tracking-pog-l2 @elusian @lguzzi @cms-sw/trk-dpg-l2 about the new naming of the collections used for tracker local reconstruction / tracking / vertexing
• @cms-sw/pf-l2 @waredjeb @jsamudio about the naming of the PF modules used in the HLT.
• @cms-sw/hgcal-dpg-l2 if there is any DQM / validation module monitoring HGCal products that need to be taken care of.

Cc: @rovere @SohamBhattacharya @VourMa

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45636/41148

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• DQMOffline/Trigger (dqm)
• HLTrigger/Configuration (hlt)
• Validation/RecoTrack (dqm)
• Validation/RecoVertex (dqm)

@Martin-Grunewald, @antoniovagnerini, @cmsbuild, @mmusich, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@Fedespring, @GiacomoSguazzoni, @HuguesBrun, @JanFSchulte, @Martin-Grunewald, @ReyerBand, @SohamBhattacharya, @VinInn, @VourMa, @argiro, @cericeci, @dgulhan, @felicepantaleo, @jhgoh, @missirol, @mmusich, @mtosi, @rchatter, @rociovilar, @rovere, @silviodonato, @thomreis, @trocino, @venturia, @wang0jin, @wmtford this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[waredjeb]

Maybe I am missing something, but also according to the other EDProducers, shouldn't this be

Suggested change

	PFSuperClusterCollectionBarrel = cms.string('hltParticleFlowSuperClusterECALBarrel'),
	PFSuperClusterCollectionBarrel = cms.string('particleFlowSuperClusterECALBarrel'),

?

[rovere]

As far as I can tell, I agree with @waredjeb regarding consistency.
On the other hand, this product (I mean the barrel one created by this HGCal-labelled module) is never consumed. So any name would do w/o crashes.

[mmusich]

Thank @rovere for the check.

On the other hand, this product (I mean the barrel one created by this HGCal-labelled module) is never consumed. So any name would do w/o crashes.

I would propose to go ahead with the PR as is now to avoid re-triggering a lot of signatures and then fix this immediately after, if people agree.

[mmusich]

Fixed at #45768. Let me know if you spot other problems.

[waredjeb]

Hi @mmusich thanks a lot!
I think I might have to go through it couple of times!

For what concerns TICL/HGCAL, I think we also need to modify the RecoHGCal Event content https://github.com/cms-sw/cmssw/blob/master/RecoHGCal/Configuration/python/RecoHGCal_EventContent_cff.py adding the new HLT collections to FEVTDEBUGHLToutput

We can make a commit on top of this PR such that you can just cherry-pick it

[mmusich]

I think we also need to modify the RecoHGCal Event content .

Good point! The same holds true for the tracking products .

[cmsbuild]

+1

Size: This PR adds an extra 220KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea66c8/40760/summary.html
COMMIT: 24f4756
CMSSW: CMSSW_14_1_X_2024-08-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45636/40760/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 305 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 908 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3524886
• DQMHistoTests: Total failures: 5236
• DQMHistoTests: Total nulls: 2
• DQMHistoTests: Total successes: 3519628
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 7.322999999999999 KiB( 45 files compared)
• DQMHistoSizes: changed ( 23234.0,... ): 1.371 KiB HLT/Vertexing
• DQMHistoSizes: changed ( 23234.0,... ): -0.326 KiB HLT/Tracking
• DQMHistoSizes: changed ( 29696.0,... ): 0.004 KiB MessageLogger/Warnings
• Checked 200 log files, 170 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[AuroraPerego]

We can make a commit on top of this PR such that you can just cherry-pick it

Hi @mmusich, I think you can use this commit. I've checked that the collections are saved in the event content. Let us know if it works :)

[srimanob]

+Upgrade

[tjavaid]

+1

• spurious differences seen from unstable WF 12834.7 (open issue spurious differences in outputs of Run-3 wfs *.7 #39803 )

[mmusich]

+hlt

• TriggerResults are unchanged
• changes in the DQM output are expected (see add hlt (HLT) label to Phase-2 HLT modules (sequences) #45636 (comment))
• see caveat at add hlt (HLT) label to Phase-2 HLT modules (sequences) #45636 (comment) (will fix immediately after this PR is merged in a HLT-only PR).

[antoniovilela]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.