-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use eigen3 header instead of tf third_party/eigen3 #45701
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45701/41314 |
A new Pull Request was created by @smuzaffar for master. It involves the following packages:
@cmsbuild, @valsdav, @y19y19 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test with cms-sw/cmsdist#9360 |
+1 Size: This PR adds an extra 16KB to repository The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
@cms-sw/ml-l2 , can you please review this? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This change allows to pick up eigen3 header from our distribution of eigen instead of tensorflow/third_party/eigen3. This is needed for TF 2.16 but should work for old versions of TF too. This should be test with cms-sw/cmsdist#9360 and should be merged only after cms-sw/cmsdist#9360 is in IB.
[a] cms-sw/cmsdist#9241 (comment)