Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "PUPPI MET in RECO" #29748

Merged
merged 1 commit into from
May 6, 2020
Merged

Revert "PUPPI MET in RECO" #29748

merged 1 commit into from
May 6, 2020

Conversation

silviodonato
Copy link
Contributor

@silviodonato silviodonato commented May 6, 2020 •
edited
Loading

See #29744
We are getting errors related to #29254 in many workflows.
In addition, the errors seems hardly reproducible, and then we risk to crash the relval production.
So I'm going to revert temporarly #29254 before the night IB in order to build CMSSW_11_1_0_pre7
https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/ib/CMSSW_11_1_X

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone May 6, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

The code-checks are being triggered in jenkins.

@silviodonato
Copy link
Contributor Author

please test

@silviodonato silviodonato mentioned this pull request May 6, 2020
Closed
@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29748/15181

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6138/console Started: 2020/05/06 16:24

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

CommonTools/ParticleFlow
CommonTools/PileupAlgos
DataFormats/METReco
DataFormats/PatCandidates
ElectroWeakAnalysis/Utilities
HLTriggerOffline/Exotica
JetMETCorrections/Type1MET
PhysicsTools/PatAlgos
PhysicsTools/PatUtils
RecoMET/Configuration
RecoMET/METAlgorithms
RecoMET/METProducers

@perrotta, @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU, @slava77, @santocch can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @jdolen, @ahinzmann, @smoortga, @missirol, @ferencek, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @mtosi, @mariadalfonso, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @cbernet, @gpetruc, @andrzejnovak this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit 8c0e2bf into master May 6, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

+1
Tested at: 0c912b0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4315a2/6138/summary.html
CMSSW: CMSSW_11_1_X_2020-05-05-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4315a2/6138/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4315a2/6138/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4315a2/6138/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 311 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697527
  • DQMHistoTests: Total failures: 81
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2697127
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@silviodonato silviodonato mentioned this pull request May 7, 2020
Closed
@jfernan2
Copy link
Contributor

jfernan2 commented Jun 4, 2020

+1
For the records

@smuzaffar smuzaffar deleted the revert-29254-puppiNoLep_weight_in_aod branch June 13, 2020 17:27
@jfernan2
Copy link
Contributor

+1
For the records

@cmsbuild
Copy link
Contributor

Pull request #29748 was updated. @simonepigazzini, @vlimant, @tvami can you please check and sign again.

@vlimant
Copy link
Contributor

vlimant commented Sep 19, 2023

what is going on @jfernan2 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending code-checks-approved comparison-available dqm-approved orp-approved pending-signatures reconstruction-approved tests-approved xpog-pending
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.
4 participants
@silviodonato @cmsbuild @jfernan2 @vlimant