Clean up BuildFiles under RecoLocalCalo/

[fwyzard]

Clean up BuildFile.xml filea with xmllint --format.

[fwyzard]

@cmsbuild, please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29702/15102

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalCalo/EcalRecAlgos/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File RecoLocalCalo/EcalRecAlgos/test/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File RecoLocalCalo/EcalRecProducers/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File RecoLocalCalo/EcalRecProducers/plugins/BuildFile.xml modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6069/console Started: 2020/05/05 19:34

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

RecoLocalCalo/CaloTowersCreator
RecoLocalCalo/Castor
RecoLocalCalo/CastorReco
RecoLocalCalo/EcalDeadChannelRecoveryAlgos
RecoLocalCalo/EcalRecAlgos
RecoLocalCalo/EcalRecProducers
RecoLocalCalo/HGCalRecAlgos
RecoLocalCalo/HGCalRecProducers
RecoLocalCalo/HcalLaserReco
RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@edjtscott, @vandreev11, @deguio, @sethzenz, @felicepantaleo, @riga, @rovere, @lgray, @cseez, @apsallid, @pfs, @lecriste, @hatakeyamak, @mariadalfonso, @argiro, @abdoulline, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Tested at: 42d0cd7

CMSSW: CMSSW_11_1_X_2020-05-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Clean up BuildFiles under HLTriggerOffline/ #29637 @fwyzard: Clean up BuildFiles under HLTriggerOffline/
• Added particle flow candidates to particle flow validation #29628 @chosila: Added particle flow candidates to particle flow validation

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4138be/6069/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4138be/6069/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4138be/6069/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

• AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Tue May 5 21:43:14 2020-date Tue May 5 21:38:05 2020 s - exit: 35584

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Clean up BuildFiles under HLTriggerOffline/ #29637 @fwyzard: Clean up BuildFiles under HLTriggerOffline/
• Added particle flow candidates to particle flow validation #29628 @chosila: Added particle flow candidates to particle flow validation

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4138be/6069/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4138be/6069/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4138be/6069/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2696239
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2695917
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 495.627 KiB( 33 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): 21.549 KiB ParticleFlow/PackedCandidates
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6131/console Started: 2020/05/06 10:48

[cmsbuild]

+1
Tested at: 42d0cd7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4138be/6131/summary.html
CMSSW: CMSSW_11_1_X_2020-05-05-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4138be/6131/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2697527
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2697207
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[perrotta]

+1

• Technical
• Changes are only in white spaces and empty lines
• Jenkins tests pass
• (Trying to clean up the queue of pendig pull requests for reconstruction)

[silviodonato]

merge