Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up BuildFiles under FWCore/ #29674

Merged
merged 2 commits into from
May 6, 2020
Merged

Clean up BuildFiles under FWCore/ #29674

merged 2 commits into from
May 6, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 5, 2020

Clean up BuildFile.xml filea with xmllint --format.

@fwyzard
Copy link
Contributor Author

fwyzard commented May 5, 2020

@cmsbuild, please test

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone May 5, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The code-checks are being triggered in jenkins.

fwyzard added 2 commits May 5, 2020 14:59
@fwyzard
Clean up BuildFiles under FWCore/
0988afe 
Clean up BuildFile.xml filea with `xmllint --format`.
@fwyzard
Fix missing '=' sign
9bd0246
@fwyzard fwyzard force-pushed the branch_lintBuildFile_FWCore branch from bdf955a to 9bd0246 Compare May 5, 2020 13:00
@fwyzard
Copy link
Contributor Author

fwyzard commented May 5, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29674/15074

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6041/console Started: 2020/05/05 17:28

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

FWCore/Catalog
FWCore/Common
FWCore/Concurrency
FWCore/FWLite
FWCore/Framework
FWCore/Integration
FWCore/MessageLogger
FWCore/MessageService
FWCore/Modules
FWCore/ParameterSet
FWCore/ParameterSetReader
FWCore/PluginManager
FWCore/PrescaleService
FWCore/PyDevParameterSet
FWCore/PythonFramework
FWCore/PythonParameterSet
FWCore/ROOTTests
FWCore/Reflection
FWCore/SOA
FWCore/ServiceRegistry
FWCore/Services
FWCore/SharedMemory
FWCore/Skeletons
FWCore/Sources
FWCore/TFWLiteSelector
FWCore/TFWLiteSelectorTest
FWCore/TestProcessor
FWCore/Utilities
FWCore/Version

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

-1

Tested at: 9bd0246

CMSSW: CMSSW_11_1_X_2020-05-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f068f/6041/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f068f/6041/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f068f/6041/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test TestFWCoreServicesDriver had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f068f/6041/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f068f/6041/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f068f/6041/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696239
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2695919
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 495.627 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 21.549 KiB ParticleFlow/PackedCandidates
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

silviodonato
silviodonato reviewed May 6, 2020
View reviewed changes
FWCore/Skeletons/scripts/mkTemplates/EDProducer/BuildFile.xml
@@ -4,5 +4,5 @@
@example_myparticle <use name="PhysicsTools/UtilAlgos"/>
@example_myparticle <use name="DataFormats/MuonReco"/>
@example_myparticle <use name="DataFormats/EgammaCandidates"/>
@example_myparticle <use name "DataFormats/Candidate"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fwyzard

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit b16f2df into cms-sw:master May 6, 2020
@makortel
Copy link
Contributor

makortel commented May 6, 2020

+1

post-merge

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing).

@cmsbuild cmsbuild mentioned this pull request May 6, 2020
Merged
@fwyzard fwyzard deleted the branch_lintBuildFile_FWCore branch May 8, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silviodonato silviodonato silviodonato left review comments

Assignees
No one assigned
Labels
code-checks-approved comparison-available core-approved fully-signed orp-approved tests-rejected
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.
4 participants
@fwyzard @cmsbuild @silviodonato @makortel