Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up BuildFiles under Utilities/ #29736

Merged
merged 1 commit into from
May 6, 2020
Merged

Clean up BuildFiles under Utilities/ #29736

merged 1 commit into from
May 6, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 5, 2020

Clean up BuildFile.xml filea with xmllint --format.

@fwyzard
Copy link
Contributor Author

fwyzard commented May 5, 2020

@cmsbuild, please test

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone May 5, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29736/15136

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

Utilities/BinningTools
Utilities/DCacheAdaptor
Utilities/DavixAdaptor
Utilities/General
Utilities/LStoreAdaptor
Utilities/PPS
Utilities/StaticAnalyzers
Utilities/StorageFactory
Utilities/Xerces
Utilities/XrdAdaptor

@smuzaffar, @civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

ERROR: empty variable. PR had errors - #29736.

@Dr15Jones
Copy link
Contributor

@smuzaffar any idea what the error message is from?
ERROR: empty variable. PR had errors - #29736.

smuzaffar
smuzaffar reviewed May 5, 2020
View reviewed changes
Utilities/StorageFactory/test/BuildFile.xml Outdated
<flags NO_TESTRUN="1"/>
</bin>
<bin file="mkstemp.cpp" name="test_StorageFactory_Mkstemp">
</bin><bin file="local2.cpp" name="test_StorageFactory_Local2">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look correct. @Dr15Jones

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I'm guessing this is caused by the fact that BuildFile.xml files in general are not actually fully XML conformant (i.e. XML requires one and only one top level node while the BuildFile.xml format does not.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says

we want to wait until the framework decides on a threading model to implement a fix

maybe it's obsolete ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says

we want to wait until the framework decides on a threading model to implement a fix

maybe it's obsolete ?

The test was disabled in e09f0ac. @Dr15Jones Would you be able to tell if there is anything that would prevent the test to run?

@fwyzard
Clean up BuildFiles under Utilities/
cf28ce8 
Clean up BuildFile.xml filea with `xmllint --format`.
@fwyzard fwyzard force-pushed the branch_lintBuildFile_Utilities branch from 6155ca5 to cf28ce8 Compare May 5, 2020 15:46
@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The code-checks are being triggered in jenkins.

@fwyzard
Copy link
Contributor Author

fwyzard commented May 5, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29736/15148

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6103/console Started: 2020/05/05 21:47

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

Pull request #29736 was updated. @smuzaffar, @civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild, @santocch can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+1
Tested at: cf28ce8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2cd38b/6103/summary.html
CMSSW: CMSSW_11_1_X_2020-05-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2cd38b/6103/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2cd38b/6103/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2cd38b/6103/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696239
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2695918
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 495.627 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 21.549 KiB ParticleFlow/PackedCandidates
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@civanch
Copy link
Contributor

civanch commented May 6, 2020

+1

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 9c2a083 into cms-sw:master May 6, 2020
@makortel
Copy link
Contributor

makortel commented May 6, 2020

+1

post-merge

@cmsbuild cmsbuild mentioned this pull request May 6, 2020
Merged
@santocch
Copy link

santocch commented May 7, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@fwyzard fwyzard deleted the branch_lintBuildFile_Utilities branch May 8, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smuzaffar smuzaffar smuzaffar left review comments

@Dr15Jones Dr15Jones Dr15Jones left review comments

@makortel makortel makortel left review comments

Assignees
No one assigned
Labels
analysis-approved code-checks-approved comparison-available core-approved fully-signed orp-approved simulation-approved tests-approved
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.
8 participants
@fwyzard @cmsbuild @Dr15Jones @civanch @silviodonato @makortel @santocch @smuzaffar