Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up BuildFiles under GeneratorInterface/ #29656

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 5, 2020

Clean up BuildFile.xml filea with xmllint --format.

@fwyzard
Copy link
Contributor Author

fwyzard commented May 5, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29656/15055

  • This PR adds an extra 56KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6024/console Started: 2020/05/05 14:28

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

GeneratorInterface/AMPTInterface
GeneratorInterface/AlpgenInterface
GeneratorInterface/BeamHaloGenerator
GeneratorInterface/CascadeInterface
GeneratorInterface/Core
GeneratorInterface/CosmicMuonGenerator
GeneratorInterface/EvtGenInterface
GeneratorInterface/ExhumeInterface
GeneratorInterface/ExternalDecays
GeneratorInterface/GenExtensions
GeneratorInterface/GenFilters
GeneratorInterface/Herwig6Interface
GeneratorInterface/Herwig7Interface
GeneratorInterface/HiGenCommon
GeneratorInterface/HijingInterface
GeneratorInterface/Hydjet2Interface
GeneratorInterface/HydjetInterface
GeneratorInterface/LHEInterface
GeneratorInterface/MCatNLOInterface
GeneratorInterface/PartonShowerVeto
GeneratorInterface/PhotosInterface
GeneratorInterface/PomwigInterface
GeneratorInterface/PyquenInterface
GeneratorInterface/Pythia6Interface
GeneratorInterface/Pythia8Interface
GeneratorInterface/ReggeGribovPartonMCInterface
GeneratorInterface/RivetInterface
GeneratorInterface/TauolaInterface

@SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @cbaus, @agrohsje, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

-1

Tested at: 553fc12

CMSSW: CMSSW_11_1_X_2020-05-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b4609/6024/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b4609/6024/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b4609/6024/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

  • Build:

I found compilation error when building:

Copying tmp/slc7_amd64_gcc820/src/GeneratorInterface/Pythia8Interface/test/testGeneratorInterfacePythia8InterfaceTP/testGeneratorInterfacePythia8InterfaceTP to productstore area:
Entering library rule at src/GeneratorInterface/Pythia8Interface/test
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-05-1100/src/GeneratorInterface/Pythia8Interface/test/ZJetsAnalyzer.cc 
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-05-1100/src/GeneratorInterface/Pythia8Interface/test/analyserhepmc/LeptonAnalyserHepMC.cc 
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-05-1100/src/GeneratorInterface/Pythia8Interface/test/ZJetsAnalyzer.cc:4:
/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_X_2020-05-05-1100/src/SimDataFormats/GeneratorProducts/interface/HepMCProduct.h:9:10: fatal error: TMatrixD.h: No such file or directory
 #include 
          ^~~~~~~~~~~~
compilation terminated.
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-05-1100/src/GeneratorInterface/Pythia8Interface/test/analyserhepmc/LeptonAnalyserHepMC.cc:1:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-05-1100/src/GeneratorInterface/Pythia8Interface/test/analyserhepmc/LeptonAnalyserHepMC.h:1:10: fatal error: HepMC/GenEvent.h: No such file or directory

  • Clang:

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

Entering library rule at src/GeneratorInterface/Pythia8Interface/test
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-05-1100/src/GeneratorInterface/Pythia8Interface/test/ZJetsAnalyzer.cc 
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-05-1100/src/GeneratorInterface/Pythia8Interface/test/analyserhepmc/LeptonAnalyserHepMC.cc 
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-05-1100/src/GeneratorInterface/Pythia8Interface/test/analyserhepmc/JetInputHepMC.cc 
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-05-1100/src/GeneratorInterface/Pythia8Interface/test/analyserhepmc/LeptonAnalyserHepMC.cc:1:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-05-1100/src/GeneratorInterface/Pythia8Interface/test/analyserhepmc/LeptonAnalyserHepMC.h:1:10: fatal error: 'HepMC/GenEvent.h' file not found
#include "HepMC/GenEvent.h"
         ^~~~~~~~~~~~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-05-1100/src/GeneratorInterface/Pythia8Interface/test/analyserhepmc/JetInputHepMC.cc:1:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-05-1100/src/GeneratorInterface/Pythia8Interface/test/analyserhepmc/JetInputHepMC.h:8:10: fatal error: 'HepMC/GenEvent.h' file not found
#include 


The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b4609/6024/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b4609/6024/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

Verified

This commit was signed with the committer’s verified signature.
fwyzard Andrea Bocci
Clean up BuildFile.xml filea with `xmllint --format`.
@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The code-checks are being triggered in jenkins.

@fwyzard
Copy link
Contributor Author

fwyzard commented May 5, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29656/15139

  • This PR adds an extra 60KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

Pull request #29656 was updated. @SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez, @qliphy can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

ERROR: empty variable. PR had errors - #29656.

@fwyzard
Copy link
Contributor Author

fwyzard commented May 5, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6105/console Started: 2020/05/05 21:51

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+1
Tested at: ad430cf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b4609/6105/summary.html
CMSSW: CMSSW_11_1_X_2020-05-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b4609/6105/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b4609/6105/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b4609/6105/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696239
  • DQMHistoTests: Total failures: 30
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2695890
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 495.627 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 21.549 KiB ParticleFlow/PackedCandidates
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit b0f1b66 into cms-sw:master May 6, 2020
@fwyzard fwyzard deleted the branch_lintBuildFile_GeneratorInterface branch May 8, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants