Run-3 ALCT and LCT data formats #29456

dildick · 2020-04-10T16:48:20Z

PR description:

This PR extends the ALCT and LCT data formats for Run-3. Detailed information can be found in this note: https://gitlab.cern.ch/tdr/notes/DN-20-016/blob/master/temp/DN-20-016_temp.pdf

Edited Summary:

ALCT changes (section 3.1 in DN-20-016)

3 highest bits in BXN[4:0], BXN[4:2], will be reassigned for high-multiplicity triggering
a new high-multiplicity trigger member hmt_ was added
a new member version_ that indicates Run3 or Legacy was added

CLCT changes

a new member version_ that indicates Run3 or Legacy was added

LCT changes (section 3.2 in DN-20-016)

2 bits are reallocated to encode the 1/4 and 1/8 strip bit (see also Run-3 CLCT and LCT data formats (CCLUT-3) #29205 )
4-bit quality becomes a 3-bit for ME1/1, or 2-bit for non-ME1/1
4-bit pattern ID is reinterpreted as 4-bit bending value
2-bit (3-bit) high-multiplicity trigger word for each ME1/1 (non-ME1/1) chamber
a new high-multiplicity trigger member hmt was added
a new member version_ that indicates Run3 or Legacy was added

PR validation:

Tested with WF 22034.0

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

cmsbuild · 2020-04-10T16:48:40Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-04-10T16:53:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29456/14646

This PR adds an extra 24KB to repository

cmsbuild · 2020-04-10T16:53:35Z

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/CSCDigi
DataFormats/L1CSCTrackFinder

@cmsbuild, @rekovic, @benkrikler, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@ptcox, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

dildick · 2020-04-10T16:53:41Z

@civanch I think I still need to add a member in order to distinguish Run-1/2 from Run-3 ALCTs and LCTs. I was able to do this for CLCTs in #29205 with the comparator code value. For ALCTs and LCTs, there is no obvious choice with the existing members. Some CSC folks suggested to add a flag isRun3. Can you offer a recommendation?

civanch · 2020-04-12T14:44:57Z

please test

cmsbuild · 2020-04-12T14:45:25Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5670/console Started: 2020/04/12 17:52

civanch · 2020-04-12T14:48:34Z

@dildick , addition of an extra flag seems to be a working solution. However, it is not the first case when in a sub-detector we have to modify data structure, let us discuss with experts what is optimal in the case of a minor change as you have.

cmsbuild · 2020-04-12T17:10:28Z

+1
Tested at: af35b55
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c06e6/5670/summary.html
CMSSW: CMSSW_11_1_X_2020-04-12-0000
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-04-12T17:10:31Z

Comparison job queued.

cmsbuild · 2020-04-12T18:37:24Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c06e6/5670/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2695166
DQMHistoTests: Total failures: 21
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2694826
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

dildick · 2020-04-13T16:33:44Z

@silviodonato Do you have a suggestion I can implement?

civanch · 2020-04-14T07:13:56Z

@makortel , @bsunanda , can you, please, comment what is optimal solution for a producer if data format slightly changed for Run-3?

dildick · 2020-04-17T16:09:16Z

Glad to see that the unit test passed this time. Other than that, the comparisons look good; no failures in the CSC system that I can tell.

abrinke1 · 2020-04-17T16:16:31Z

DataFormats/CSCDigi/src/CSCCLCTDigi.cc

@@ -81,7 +84,7 @@ void CSCCLCTDigi::clear() {
  }
 }

-int CSCCLCTDigi::getKeyStrip(int n) const {
+uint16_t CSCCLCTDigi::getKeyStrip(const uint16_t n) const {
  // 10-bit case for strip data word
  if (compCode_ != -1 and n == 8) {


This is for Run 3 only, I guess? Just to confirm: the "compCode" has never been used in Run 2, i.e. it was unused in firmware, and was always set to -1 in software? (See getCompCode() function above.)

Yes, correct. I suppose we can update this function so that for Run-1/2 it always returns the half-strip, whatever the argument.

I think that's already what it does, no? See below, "// 8-bit case for strip data word (all other cases)"

Yes, it does.

abrinke1 · 2020-04-17T16:20:04Z

Looks like there were 0 changes in any of the DQM histograms, including L1T: https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_1_X_2020-04-16-2300+4c06e6/35939/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15/

…

On Fri, Apr 17, 2020 at 11:10 AM Sven Dildick ***@***.***> wrote: Glad to see that the unit test passed this time. Other than that, the comparisons look good; no failures in the CSC system that I can tell. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29456 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABHVOUHKT3FKJEUST3FYXPDRNB5L3ANCNFSM4MFR6A6Q> .

dildick · 2020-04-21T14:16:15Z

Hi, are there more comments on this PR?

perrotta · 2020-04-23T07:37:12Z

+1

Reconstruction code is only marginally touched by this PR: minor reco changes in EventFilter/CSCRawToDigi/src/CSCDigiToRaw.cc, justified by the change from int to uint16_t in the return value of two functions defined elsewhere
Jenkins tests pass and show no differences in reco outputs

civanch · 2020-04-24T09:16:11Z

+1

silviodonato · 2020-04-27T14:18:27Z

@rekovic do you have any comments?

dildick · 2020-05-01T13:01:30Z

Hi, can this PR be integrated?

silviodonato · 2020-05-04T09:03:57Z

Reminder @rekovic (CMSSW_11_1_0_pre7 is scheduled for tomorrow)

rekovic · 2020-05-06T08:57:30Z

@dildick
Please make a follow-up PR with changing the name of getter function to follow the naming rules 2.11 (http://cms-sw.github.io/cms_coding_rules.html)

+1

rekovic · 2020-05-06T08:58:06Z

+1

cmsbuild · 2020-05-06T08:58:29Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-05-06T08:59:25Z

+1

dildick · 2020-05-07T15:34:53Z

@rekovic I see. I'll need to remove the "get" from each getter function... Is there a chance this introduces an issue with reading old MC/data with newer code?

Sven Dildick added 2 commits April 10, 2020 10:57

Run-3 data formats

357ff0c

Increment class version for TrackStub

af35b55

cmsbuild added this to the CMSSW_11_1_X milestone Apr 10, 2020

cmsbuild added code-checks-pending comparison-pending l1-pending orp-pending pending-signatures simulation-pending tests-pending labels Apr 10, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 10, 2020

cmsbuild added tests-started and removed tests-pending labels Apr 12, 2020

cmsbuild added tests-approved and removed tests-started labels Apr 12, 2020

cmsbuild added comparison-available and removed comparison-pending labels Apr 12, 2020

abrinke1 reviewed Apr 17, 2020

View reviewed changes

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Apr 23, 2020

cmsbuild added simulation-approved and removed simulation-pending labels Apr 24, 2020

cmsbuild mentioned this pull request Apr 24, 2020

Tau decay hook #29557

Closed

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels May 6, 2020

cmsbuild added orp-approved and removed orp-pending labels May 6, 2020

cmsbuild merged commit 97be8ff into cms-sw:master May 6, 2020

cmsbuild mentioned this pull request May 6, 2020

Revert "PUPPI MET in RECO" #29748

Merged

dildick deleted the from-CMSSW_11_1_X_2020-04-08-1100-run3-dataformats branch May 7, 2020 00:07

dildick mentioned this pull request May 8, 2020

CMS code rules for CSC digi and trigger objects #29782

Closed

dildick mentioned this pull request May 13, 2021

Dedicated data members for Run-3 CSC trigger primitives #33727

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run-3 ALCT and LCT data formats #29456

Run-3 ALCT and LCT data formats #29456

dildick commented Apr 10, 2020 •

edited

Loading

cmsbuild commented Apr 10, 2020

cmsbuild commented Apr 10, 2020

cmsbuild commented Apr 10, 2020

dildick commented Apr 10, 2020 •

edited

Loading

civanch commented Apr 12, 2020

cmsbuild commented Apr 12, 2020 •

edited

Loading

civanch commented Apr 12, 2020

cmsbuild commented Apr 12, 2020

cmsbuild commented Apr 12, 2020

cmsbuild commented Apr 12, 2020

dildick commented Apr 13, 2020

civanch commented Apr 14, 2020

dildick commented Apr 17, 2020

abrinke1 Apr 17, 2020

dildick Apr 17, 2020

abrinke1 Apr 17, 2020

dildick Apr 17, 2020 •

edited

Loading

abrinke1 commented Apr 17, 2020 via email

dildick commented Apr 21, 2020

perrotta commented Apr 23, 2020

civanch commented Apr 24, 2020

silviodonato commented Apr 27, 2020

dildick commented May 1, 2020

silviodonato commented May 4, 2020

rekovic commented May 6, 2020

rekovic commented May 6, 2020

cmsbuild commented May 6, 2020

silviodonato commented May 6, 2020

dildick commented May 7, 2020

Run-3 ALCT and LCT data formats #29456

Run-3 ALCT and LCT data formats #29456

Conversation

dildick commented Apr 10, 2020 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Apr 10, 2020

cmsbuild commented Apr 10, 2020

cmsbuild commented Apr 10, 2020

dildick commented Apr 10, 2020 • edited Loading

civanch commented Apr 12, 2020

cmsbuild commented Apr 12, 2020 • edited Loading

civanch commented Apr 12, 2020

cmsbuild commented Apr 12, 2020

cmsbuild commented Apr 12, 2020

cmsbuild commented Apr 12, 2020

dildick commented Apr 13, 2020

civanch commented Apr 14, 2020

dildick commented Apr 17, 2020

abrinke1 Apr 17, 2020

Choose a reason for hiding this comment

dildick Apr 17, 2020

Choose a reason for hiding this comment

abrinke1 Apr 17, 2020

Choose a reason for hiding this comment

dildick Apr 17, 2020 • edited Loading

Choose a reason for hiding this comment

abrinke1 commented Apr 17, 2020 via email

dildick commented Apr 21, 2020

perrotta commented Apr 23, 2020

civanch commented Apr 24, 2020

silviodonato commented Apr 27, 2020

dildick commented May 1, 2020

silviodonato commented May 4, 2020

rekovic commented May 6, 2020

rekovic commented May 6, 2020

cmsbuild commented May 6, 2020

silviodonato commented May 6, 2020

dildick commented May 7, 2020

dildick commented Apr 10, 2020 •

edited

Loading

dildick commented Apr 10, 2020 •

edited

Loading

cmsbuild commented Apr 12, 2020 •

edited

Loading

dildick Apr 17, 2020 •

edited

Loading